Commit graph

7274 commits

Author SHA1 Message Date
Ivailo Monev
5f535dba7f mark the no type name case in QMetaType::unregisterType() as unlikely
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-09 18:45:00 +03:00
Ivailo Monev
a333a6042d mark the no type name, destructor or constructor cases in QMetaType as unlikely
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-09 18:40:54 +03:00
Ivailo Monev
3f1941ce53 remove redundant qreal meta type registration in QTimeLine test case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-09 07:41:51 +03:00
Ivailo Monev
bcf53dc4e1 remove redundant qreal meta type registration in QTimeLine test case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-09 07:40:46 +03:00
Ivailo Monev
240e980b8c remove QTimeLine::CurveShape enum, property setter and getter for it
upstream commit:
072fb7de51

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-09 05:51:34 +03:00
Ivailo Monev
8093ab8f7e someone's typo
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-09 05:22:03 +03:00
Ivailo Monev
1e4adfa860 declare builtin meta types without namespace switching
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-09 03:07:42 +03:00
Ivailo Monev
08d1b940a7 effectively revert 42c06ab368
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-09 01:46:19 +03:00
Ivailo Monev
215a8d7fd3 an incomplete icon theme
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-09 00:45:53 +03:00
Ivailo Monev
60d39b493c what icon theme is installed in AppVeyor enrvironment?
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 23:59:27 +03:00
Ivailo Monev
bc820a172f better system icon theme detection
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 22:03:36 +03:00
Ivailo Monev
8200bf8ae2 mark fatal cases as unlikely
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 21:21:41 +03:00
Ivailo Monev
319136cfd8 remove unused QVariant::Handler members [ci reset]
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 19:46:49 +03:00
Ivailo Monev
7996e356b2 call FcFini() only when build for debugging
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 19:32:10 +03:00
Ivailo Monev
9f270ed7ca QFixed is not exactly POD type
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 19:10:00 +03:00
Ivailo Monev
9986c43750 initialize QRegionSpan members
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 19:09:43 +03:00
Ivailo Monev
899707821a glyph_metrics_t, QGlyphJustification, QScriptItem and QScriptLine are not exactly POD types
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 19:02:23 +03:00
Ivailo Monev
01482d9db8 pre-allocate one QScriptItem object
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 18:55:55 +03:00
Ivailo Monev
870aa20c01 use QVarLengthArray<T> instead of QVector<T> in text engine classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 18:35:44 +03:00
Ivailo Monev
38bd66e510 QScriptItem does not have move-constructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 18:13:42 +03:00
Ivailo Monev
cb98ffe89f QRegExp QDataStream streaming operator optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 17:07:08 +03:00
Ivailo Monev
e5076ae0ca QVariant rewrite round 2
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 17:05:05 +03:00
Ivailo Monev
fbce767002 ensure the automatically picked up system icon theme is not cursors theme
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 04:22:09 +03:00
Ivailo Monev
7bcef3e549 skip the QFileIconProvider::iconType() test case if there is no system icon theme
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 04:12:24 +03:00
Ivailo Monev
acaec80ae8 ensure invalid QVariant objects are not casted
undetected by clang analysis but it is null void pointer cast to integers
and boolean which can cause crash, the only reason the follow code does not
crash:
int main()
{
    QVariant v;
    bool ok = false;
    qDebug() << v.toInt(&ok);
    return 0;
}

is because there are QVariant type checks before the address is accessed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-08 03:48:01 +03:00
Ivailo Monev
362ce82c6b plug fonconfig memory leaks
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-07 23:53:28 +03:00
Ivailo Monev
6073e77342 use folder-remote icon for QStyle::SP_DriveNetIcon
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-07 22:38:36 +03:00
Ivailo Monev
f548a6140a implement methods to get and set plugin paths
for reference:
03e46bb6d4

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-07 22:28:07 +03:00
Ivailo Monev
ca8331f304 QFileIconProvider::iconInfo() test case now requires system icon theme
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-07 20:29:40 +03:00
Ivailo Monev
12706c7efe remove unused style images
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-07 19:04:48 +03:00
Ivailo Monev
7008a45d97 use icons from the system icon theme
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-07 18:51:57 +03:00
Ivailo Monev
88cd5d72b2 QTanslator no longer needs QObject as base class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-07 17:36:54 +03:00
Ivailo Monev
4acfa93e66 do not copy the variant before checking if it can be converted in QVariant::canConvert()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-07 16:11:48 +03:00
Ivailo Monev
74fef30990 remove now redundant compareNumericMetaType<T>() template
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-07 16:07:34 +03:00
Ivailo Monev
c0fa093f41 replace QVariant::cmp() method with its body
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-07 03:58:34 +03:00
Ivailo Monev
61d9154c1a essentially QVariant rewrite
the whole change is optimization around reference counting (QString,
QImage, etc. are already reference counted), beware QVariant::data()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-07 02:53:05 +03:00
Ivailo Monev
18bb25a7d4 remove unused parseNumberTriplet() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-06 18:55:40 +03:00
Ivailo Monev
886ac75e14 assume QML_FLICK_OVERSHOOT, QML_FLICK_SAMPLEBUFFER, QML_FLICK_DISCARDSAMPLES, QML_FLICK_DEFAULTMAXVELOCITY, QML_FLICK_DEFAULTDECELERATION and QML_FLICK_OVERSHOOTFRICTION are not defined
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-06 17:44:44 +03:00
Ivailo Monev
bc96deacdc de-duplicate QML_FLICK_SNAPONETHRESHOLD definition
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-06 17:43:27 +03:00
Ivailo Monev
880433d62d cast the private brush data pointer before deleting it from the QBrush assingment operator
fixes new-delete-type-mismatch

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-06 16:26:26 +03:00
Ivailo Monev
7f828c3b1e optimize QEasingCurve assignment from other QEasingCurve object
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-06 13:20:06 +03:00
Ivailo Monev
3399bf8823 prefix the warning message with the class name in QEasingCurve::setCustomType()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-06 13:05:29 +03:00
Ivailo Monev
c585828b5b rename getEnvName() and getEnvListName() functions to getEnv() and getEnvList()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-06 12:52:05 +03:00
Ivailo Monev
d5d41e9b49 use getEnvListName() function in QStandardPaths::findExecutable()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-06 12:50:25 +03:00
Ivailo Monev
a0bf5727a3 fill XDG dirs map on demand
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-06 12:49:55 +03:00
Ivailo Monev
5970ae0988 optimize query of standard paths that require config read
could be done via lockless global static but then the chances of
QStandardPaths returning values that are not set in the config increase because
the config may change at any time after the global static is constructed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-06 03:09:52 +03:00
Ivailo Monev
c407c4cba9 mark warning cases in declarative and scripttools components as unlikely
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-05 20:41:02 +03:00
Ivailo Monev
4650511e32 remove warning about 4.7 imports
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-05 20:34:07 +03:00
Ivailo Monev
75f1668d88 mark warning cases in dbus, network, script, svg, uitools and xml components as unlikely
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-05 20:21:00 +03:00
Ivailo Monev
0e5fde17da better QDebug streaming operator for QEasingCurve
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-05 18:34:29 +03:00