Ivailo Monev
f2f37377e3
kdecore: reimplement KTimeZone
...
simpler, cleaner and most importantly - thread-safe (more than the
previous implementation anyway).
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-22 03:53:20 +03:00
Ivailo Monev
199278af4a
kdecore: document the two important methods of KDateTime
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-22 00:51:24 +03:00
Ivailo Monev
798a73eb0b
kdecore: de-virtualize KDateTimeFormatter, KDateTimeParser and KDayPeriod
...
the classes are private and the methods are no reimplemented
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-21 10:55:09 +03:00
Ivailo Monev
f452e2e50b
kdecore: reimplement KDateTime via QDateTime
...
KDateTime shall be used only for storing date and time while KLocale
shall be used to display such, not even going to test what KDateTime
does because it is basically a few methods on top of QDateTime now.
and because QDateTime knows not much about calendar systems while
KLocale supports several it makes sense for KDateTime to not be used for
displaying date and time thus the TODOs for KLocale are simply removed
note that KLocale still uses its own parser and formatter which means
that the change affects only KDateTime and its uses, not KLocale
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-21 07:51:13 +03:00
Ivailo Monev
3795893cdf
kdecore: remove code for always true condition
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-21 02:14:32 +03:00
Ivailo Monev
e00c726455
kdecore: remove unused KTimeZoneBackend::type() method
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-21 02:14:17 +03:00
Ivailo Monev
53a5c81a3a
kio: minor KRecentDocument::recentDocuments() optimization
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-21 01:46:20 +03:00
Ivailo Monev
da154d3195
kio: replace KFileItemPrivate::readUDSEntry() with its body
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-21 01:30:56 +03:00
Ivailo Monev
8475feef40
kio: format and indent
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-21 01:26:19 +03:00
Ivailo Monev
1f028422e8
kio: remove unused KIO::StandardFieldTypes::UDS_HIDDEN enum
...
UNIX being UNIX the leading dot meaning a file/directory is hidden is not
going anywhere, the private KFileItem hidden member is always set to
KFileItemPrivate::Auto too
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-21 00:29:10 +03:00
Ivailo Monev
3251c5eb1b
kio: replace KFileItemPrivate::size() and KFileItemPrivate::cmp() with their body
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-21 00:14:18 +03:00
Ivailo Monev
a990de2b93
kio: KFileItemList::urlList() and KFileItemList::targetUrlList() optimization
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-21 00:08:22 +03:00
Ivailo Monev
ea56b1c92f
kio: KFileItem::mimeComment() optimization
...
KFileItem::mimeTypePtr() is lesser version of
KFileItem::determineMimeType() and if KFileItem::determineMimeType() did
not return valid KMimeType::Ptr then neither will KFileItem::mimeTypePtr()
but calling KFileItem::::mimeTypePtr() after KFileItem::determineMimeType()
is redundant
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-20 23:57:46 +03:00
Ivailo Monev
632f5e52de
kio: make the internal KIO::CopyInfo actually private, remove unused KIO::CopyJob signal
...
the signal is actually not used, see the following commit in kde-workspace:
45bbcd5e5e963d029974e09fd66edc454e7e9dc4
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-20 23:23:05 +03:00
Ivailo Monev
903e15327d
kio: remove unused headers inclusions in kfileitem source file
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-20 22:45:14 +03:00
Ivailo Monev
29a6bc934a
kio: convert KFileItem::permissionsString() to proper getter
...
way too much private and mutable KFileItem members, not used a lot so the
performance impact is next to none
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-20 22:08:35 +03:00
Ivailo Monev
a487c9edc6
kio: drop KFileItem metadata related getter and setter
...
first thing first - KFileMetaInfo does not support non-local files and
KFileItem is ment to be wrapper for both local and (most importantly)
remote (including virtual KIO) files. KIO::UDSEntry does not carry metadata
either so having a metadata getter and setter in KFileItem is simply
redundant, both are not tested and used only by plasma folderview applet
(see kde-workspace/plasma/applets/folderview/tooltipwidget.cpp)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-20 21:03:18 +03:00
Ivailo Monev
382fd80484
kdecore: fix KStandardDirs thread-safety issues
...
managed to bust it with some proper threading (see KFilePreviewJob on the
kfilepreview branch)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-19 09:06:47 +03:00
Ivailo Monev
39daa5baf3
kio: check if the KMimeType pointer is null in KFileItem::mimetype()
...
fixes possible crash (in the unusual case when the MIME type cannot be
determinted)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-19 07:38:04 +03:00
Ivailo Monev
757ac43baf
kio: do not attempt to get metadata for non-local file URLs
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-18 03:48:11 +03:00
Ivailo Monev
4e1fc45705
kio: remove unused KFileMetaInfo flags
...
when it comes to KFileMetaInfo its bottleneck is determening what plugin to
use for the given URL/path - determening MIME type, matching globs, etc.
and it still is quite fast to the point where the flags are simply
redundant
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-18 03:36:06 +03:00
Ivailo Monev
3371f4866a
kio: KFileMetaInfo::name() optimization
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-18 03:16:12 +03:00
Ivailo Monev
7e01cd1bee
kio: format and indent
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-17 23:14:02 +03:00
Ivailo Monev
f35801d3ee
kio: initialize KIO::FileCopyJobPrivate members
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-17 22:53:33 +03:00
Ivailo Monev
e94cf597a6
kio: use the QByteArray::append() method in KIO::StoredTransferJobPrivate::slotStoredData()
...
does the same really
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-17 22:08:06 +03:00
Ivailo Monev
31c3da4115
plasma: consistent headers inclusions
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-17 22:06:05 +03:00
Ivailo Monev
7452efccf4
kio: format and indent
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-17 22:05:51 +03:00
Ivailo Monev
2186a064bb
kio: replace KIO::SimpleJobPrivate::simpleJobInit() with its body
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-17 21:48:21 +03:00
Ivailo Monev
c20c6cc64f
kio: remove unused KIO::JobPrivate::emitMounting() and KIO::JobPrivate::emitUnmounting() methods
...
mounting and unmounting is no longer done by kio
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-17 21:44:01 +03:00
Ivailo Monev
f987d060a2
kio: remove unused async data sending feature
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-17 21:37:09 +03:00
Ivailo Monev
bce5621ae2
kio: remove unused and private KIO::TransferJobPrivate members
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-17 21:19:25 +03:00
Ivailo Monev
b5844bda01
kdeui: KColorDialog::KColorDialogPrivate::setHtmlEdit() optimization
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-17 05:45:54 +03:00
Ivailo Monev
a7654dc3db
kdeui: remove redundant _KDE_NET_WM_FRAME_STRUT atom and checks for it
...
see the following commit in kde-workspace:
0417ee37990d43a20d1c1ce05aeb213d2c1866f6
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-16 21:18:18 +03:00
Ivailo Monev
15135b5385
kpty: prefix getsid() in KPty::login()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-16 20:06:36 +03:00
Ivailo Monev
8ead339f6d
kdecore: call QBuffer constructor in KSycocaBufferDevice
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-16 19:55:11 +03:00
Ivailo Monev
63ae1f5ade
kdecore: re-parse MIME data files on ksycoca database change
...
was not done before (was done once lazily), is now
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-16 19:05:24 +03:00
Ivailo Monev
6bd6633da5
kdecore: remove redundant lookup in KMimeTypeRepository::defaultMimeTypePtr()
...
if KMimeTypeRepository::findMimeTypeByName() did not find the default MIME
then another lookup that does the same as
KMimeTypeRepository::findMimeTypeByName() will not find it either
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-16 18:30:51 +03:00
Ivailo Monev
bccf27bfe0
kio: compare the items via KFileItem::cmp() too in KDirListerPrivate::_k_slotUpdateResult()
...
contrary to common sense the KFileItem comparison operator does not compare
the item attributes, only the URL
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-16 08:11:12 +03:00
Ivailo Monev
a99e23a194
Merge branch 'master' of https://scm.osdn.net/gitroot/kde/kdelibs
2023-07-15 02:18:57 +03:00
Ivailo Monev
702d9b67aa
cmake: remove LibMms module
...
both the protocol and the libmms library seem abandoned..
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-15 02:17:07 +03:00
Ivailo Monev
fe91990c20
cmake: check for ddjvuapi quietly from DjVuLibre module
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-15 01:16:31 +03:00
Ivailo Monev
888f1bec7c
generic: drop support for sequenced thumbnails
...
unused
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-15 00:24:33 +03:00
Ivailo Monev
2c647b3eee
kio: initialize the KIO::PreviewJob members from already created config instance
...
no point to delay it and re-open config
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-15 00:07:17 +03:00
Ivailo Monev
16950e124e
kio: remove unused KIO::PreviewJobPrivate member
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-15 00:04:33 +03:00
Ivailo Monev
084a03fb5e
kio: iterate over a copy of the watched URLs list in KDirLister::openUrl()
...
because KDirListerPrivate::unwatchUrl() modifies the list, fixes possible
crash (if the watched URLs list was not empty)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-14 08:09:28 +03:00
Ivailo Monev
8cf2ae7bc2
generic: drop floppy support
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-14 06:30:29 +03:00
Ivailo Monev
82a26a1197
kfile: set the remote protocol category to places
...
because it is part of the places (see KFilePlacesModel)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-14 06:04:02 +03:00
Ivailo Monev
7c2e6741b6
kdeui: remove redundant Q_WS_X11 guard
...
KStartupInfo is not declared only when Q_WS_X11 is defined, altough it
works only on X11
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-13 19:14:02 +03:00
Ivailo Monev
abbf3f3930
kdeui: call KUniqueApplication::newInstance() on the interface when already running
...
so it was not called when "nofork" option was passed? hmm..
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-13 19:10:45 +03:00
Ivailo Monev
e3f4e41c44
kfile: add mtp protocol to KUrlNavigatorProtocolCombo categories, remove reference to non-existing protocols
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-13 18:22:59 +03:00