Ivailo Monev
ee0d50c901
generic: purge most manual tests
...
long overdue, have no use for them
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-03 07:03:28 +03:00
Ivailo Monev
693febf429
kio: remove redundant KDirNotify calls in KAutoMount and KAutoUnmount
...
can't mount directories on network:/, trash:/, etc. - just not a thing.
also org::kde::KDirNotify should not be used for local files and
directories
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-03 05:43:10 +03:00
Ivailo Monev
978cf7f0dd
kfile: add the selected directory to recent directories from KFileWidget
...
note that if class was not empty any URL selected was added to recent dirs
(which could be a file, duh). now directories will be added only for
directory mode and when the class (see KFileWidget about starting
directory) is not empty
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-03 04:06:55 +03:00
Ivailo Monev
4cc96022e8
generic: drop KFile::Tree and KFile::DetailTree modes
...
is interesting how things are all over kio and kfile for this
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-03 03:26:43 +03:00
Ivailo Monev
55458f706c
kfile: purge KDirSelectDialog
...
that way file and directory dialogs will be consistent, not to mention
there were things that KDirSelectDialog was lacking such as resizable
places area.
more changes are needed to account for the directory mode
(KFile::Directory), currently for directory only mode the filter is set
to "All Folders" but it can be changed (the filter widget is not
disabled). also when an attempt to open non-existing directory by name
(via the name input widget) the error says "the file cannot be found"
- it should be "the directory cannot be found" for directory mode
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-03 03:25:54 +03:00
Ivailo Monev
ead63e29f6
kio: move the KDirLister redirection proxy where it belongs
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-02 10:35:34 +03:00
Ivailo Monev
5409d7035e
kdecore: do not append trailing slash to the path if the path is / from KDirWatch::addDir()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-02 09:22:39 +03:00
Ivailo Monev
12745a92d7
kio: remove unused KDirModel and KFileItemDelegate feature
...
other than starting kuiserver it does nothing, the kuiserver program is
already started by other classes (such as job tracker classes) on demand
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-02 07:34:49 +03:00
Ivailo Monev
9aa8b4fd14
kio: re-use code for remote directory slots
...
note to self: signal is emited for the local file too when the trash is
emptied, meaning any currently listed directories which had files moved to
the trash will be updated too
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-02 07:27:29 +03:00
Ivailo Monev
bedf3b590c
kio: fix possible infinite loop on KDirLister::isFinished()
...
in case the listing has been canceled for example
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-02 07:12:20 +03:00
Ivailo Monev
5a2393001a
kio: de-virtualize the public KDirLister methods
...
there are virtual protected methods for filters and error handler, nothing
else should be needed
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-02 00:16:22 +03:00
Ivailo Monev
2c494b1bf3
kio: KDirLister documentation correction
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-02 00:00:47 +03:00
Ivailo Monev
e1a223501d
kio: KDirLister documentation update
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 23:55:11 +03:00
Ivailo Monev
a51d53e0af
kio: call org::kde::KDirNotify::emitLeftDirectory() for every watched remote URL
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 23:54:23 +03:00
Ivailo Monev
3c4b99b7cc
kio: org::kde::KDirNotify::emitEnteredDirectory() for all remote URLs
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 22:54:11 +03:00
Ivailo Monev
194ea5edda
kio: pass the correct URL to org::kde::KDirNotify::emitEnteredDirectory()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 22:10:23 +03:00
Ivailo Monev
e9f07fdea4
kio: magick bits to watch the URL of desktop files from KDirLister
...
this essentially will watch the .desktop file URL which is, say, "trash:/"
and emit changes as if the .desktop file itself was modified (to update the
icon for example). that's what the KIO desktop slave was doing essentially
but now it is implemented into KDirLister itself so anything using that
class will get it!
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 21:49:05 +03:00
Ivailo Monev
db09be602a
kio: set the internal complete variable to true just before emitting KDirLister::complete()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 20:56:39 +03:00
Ivailo Monev
3af55964f6
kio: set the KDirLister pending updates timer to be single-shot
...
KDirLister::stop() will stop it anyway tho
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 20:55:58 +03:00
Ivailo Monev
7edf0b6141
kio: delay automatic KDirLister updates caused by directory watch
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 20:38:00 +03:00
Ivailo Monev
90e5a4a087
kio: unwatch the directory before listing new one in KDirLister
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 20:14:52 +03:00
Ivailo Monev
29628e9f4e
kfile: remove redundant KDirOperatorDetailView destructor
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 20:02:29 +03:00
Ivailo Monev
bbacbaf373
kfile: KDirOperator::Private::checkPreviewInternal() optimization
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 20:02:15 +03:00
Ivailo Monev
7b2e97c1c9
kfile: remove redundant KDirOperatorDetailView::currentChanged() method
...
the QTreeView::currentChanged() method is not virtual
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 19:49:41 +03:00
Ivailo Monev
aafc5e9e02
kio: remove redundant KDirModel::sort() reimplementation
...
QAbstractItemModel::sort() does nothing
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 19:46:30 +03:00
Ivailo Monev
4e0c236efe
kio: KDirListerPrivate::_k_slotFileRenamed() optimization
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 19:46:02 +03:00
Ivailo Monev
70b373514b
kio: stop listing before anything else in KDirLister::openUrl()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 12:18:24 +03:00
Ivailo Monev
8d249d0b7d
kio: implemented but disabled partial updates for local directories
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 11:50:52 +03:00
Ivailo Monev
7e543894d9
plasma: remove forward-declarations of non-existing Plasma::AccessAppletJob class
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 08:52:33 +03:00
Ivailo Monev
68e45cdb69
kio: test KDirLister::items()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 07:24:14 +03:00
Ivailo Monev
3849efb2b0
kio: test KDirLister::openUrl()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 07:14:12 +03:00
Ivailo Monev
ce3c7b0195
kio: include required headers in kiotesthelper header
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 07:13:47 +03:00
Ivailo Monev
cf582314f8
kio: register KFileItemList as metatype
...
used by KDirLister signals for example
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 07:13:31 +03:00
Ivailo Monev
6d73fbab66
kio: fix the KDirModelTest test and copyright KDirLister to me
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 07:01:59 +03:00
Ivailo Monev
087c38ad42
kio: KDirLister hacks for remote directories
...
see kde-workspace/kioslave/trash/ktrash.cpp for example
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 06:37:19 +03:00
Ivailo Monev
fd93fbbecc
kio: reimplement KDirLister
...
has to be done to fix the caching issues, bonus points for being much
simpler and cleaner
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-01 06:18:59 +03:00
Ivailo Monev
82998dfd97
kio: format and indent
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-30 17:59:50 +03:00
Ivailo Monev
e6aeab27f8
kdecore: remove redundant KCompositeJob::slotInfoMessage() proxy slot
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-30 01:54:59 +03:00
Ivailo Monev
2f1255c32b
generic: remove redundant IN_IDE_PARSER definition checks
...
major league, baby! no kdevelop required
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-30 01:26:02 +03:00
Ivailo Monev
5306620781
kdecore: remove unused QProcess header inclusion
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-30 00:53:41 +03:00
Ivailo Monev
367e5a561f
kdecore: replace KMimeType::checkEssentialMimeTypes() with its body
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-30 00:47:41 +03:00
Ivailo Monev
16af83af0d
kdecore: use proper types for KServiceTypePrivate members
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-30 00:42:52 +03:00
Ivailo Monev
cdc25a904b
kdecore: KServiceTypePrivate::m_strComment member no longer has to be mutable
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-30 00:41:29 +03:00
Ivailo Monev
9423183828
kdecore: update KMimeType::is() documentation
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-30 00:36:02 +03:00
Ivailo Monev
6a738b1bbe
kdecore: merge KFolderMimeType into KMimeType
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-30 00:09:28 +03:00
Ivailo Monev
8133f7f73a
kdecore: initialize KSycocaFactory::Private::m_sycocaDict member
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-29 23:42:26 +03:00
Ivailo Monev
fdce619651
kdecore: document KMimeType::name() method
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-29 23:17:01 +03:00
Ivailo Monev
7786e71e32
kdecore: format and indent
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-29 23:04:35 +03:00
Ivailo Monev
f944d36719
kdecore: const-ify KMimeTypePrivate::m_path member
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-29 21:29:39 +03:00
Ivailo Monev
f1cf12c891
kdecore: plug KMimeType memory leak
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-29 21:23:06 +03:00