Commit graph

3245 commits

Author SHA1 Message Date
Ivailo Monev
bb8c1bfb2d kimgio: handle dummy BMP image size in ico plugin
fixes loading of some images such as the favicon of https://www.sftp.net/

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-30 06:23:23 +02:00
Ivailo Monev
90928e8320 generic: store package found definitions in config header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-30 05:41:21 +02:00
Ivailo Monev
8fc029197a kdecore: do not include KDE4_KDEUI_INCLUDES
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-30 05:12:13 +02:00
Ivailo Monev
21630cdbdf generic: update KDE4_KDECORE_INCLUDES variable
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-30 05:08:16 +02:00
Ivailo Monev
f863bb36ef kimgio: return false if the color component count is invalid from jp2 plugin
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-30 01:34:49 +03:00
Ivailo Monev
94934907ec solid: disconnect the device signals before deleting it
fixes possible crash

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-29 23:55:01 +03:00
Ivailo Monev
ae2e43ccc8 kfile: remove unused QFSFileEngine header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-29 19:17:03 +03:00
Ivailo Monev
697834865a kdeui: format and indent kmanagerselection source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-29 07:05:59 +03:00
Ivailo Monev
cb621f540d kdewidgets: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-28 19:59:11 +03:00
Ivailo Monev
304482299e kimgio: deprecated warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-28 05:00:07 +03:00
Ivailo Monev
f605b5f6c4 kimgio: tiff plugin review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-28 01:35:00 +03:00
Ivailo Monev
7a52005d1e kimgio: new TIFF plugin
the only reason I wrote this plugin is because some RAW images (e.g.
image/x-canon-cr2) are essentially TIFF and LibRaw cannot open those

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-28 00:59:34 +03:00
Ivailo Monev
107dd27063 kded: crash fix for the case when QT_FOREACH_COMPAT is not defined
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-27 11:24:55 +03:00
Ivailo Monev
9cac859359 kdecore: const-ify iterator in KCharsets::encodingsByScript()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-27 11:24:11 +03:00
Ivailo Monev
3e4db45b42 kdecore: crash fix for the case when QT_FOREACH_COMPAT is not defined
QT_FOREACH_COMPAT is eventually going away, it is huge performance penalty

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-27 11:08:34 +03:00
Ivailo Monev
4cffecc6af kutils: verify the KArchive progress signal values in its test case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-27 09:49:28 +03:00
Ivailo Monev
c3a42c260b kdeui: remove unused KTextEditSpellInterface class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-27 09:34:11 +03:00
Ivailo Monev
dd8d6eec75 kdecore: move org::kde::KLauncher ownership to the global KToolInvocation instance
note that there is no main thread requirement, KToolInvocation has one
signal (which is thread-safe) and KToolInvocation::klauncher() remains as
thread-safe as global static

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-27 08:20:33 +03:00
Ivailo Monev
b873df8bd2 kdecore: pass the size of QByteArray object to QString constructor in KToolInvocation::startServiceInternal()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-27 07:57:09 +03:00
Ivailo Monev
3f692a32f9 kutils: implement progress signal for KArchive
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-27 03:47:53 +03:00
Ivailo Monev
2a7c6ee1aa kimgio: remove image/jpm MIME type from the list in jp2 plugin
apparently it cannot open it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 19:06:46 +03:00
Ivailo Monev
d84dd15cdf kutils: check the return value of CURLOPT_LOGIN_OPTIONS option setup in KEMail
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 11:38:55 +03:00
Ivailo Monev
28633b995e kimgio: mark warning case in raw plugin as unlikely
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 09:30:46 +03:00
Ivailo Monev
23fd8af700 kimgio: theoretical implementation of oj_skip_callback()
there is no documentation on what it is supposed to do so I will guess

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 09:21:03 +03:00
Ivailo Monev
66b8e20bdb kimgio: remove TODO in jp2 plugin
JPEG 2000 JPIP is data over HTTP, does not have MIME type even

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 09:15:02 +03:00
Ivailo Monev
1f120ce892 solid: keep reference to the QByteArray object in UdevQt::Client::deviceBySysfsPath()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 08:48:05 +03:00
Ivailo Monev
240e0d535e solid: udev backend optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 08:43:23 +03:00
Ivailo Monev
d33233d7ab kimgio: add image/jpx and image/jpm to the jp2 plugin MIME types list
note to self:
same header/magic as the one mentioned in RFC 3745

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 07:57:42 +03:00
Ivailo Monev
e400b6841e kimgio: minor raw plugin review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 07:55:38 +03:00
Ivailo Monev
b8834c9cdd kio: increase the default preview sizes limits
the option to change them is hidden deep into the Dolphin configuration
meaning a thumbnail not being generated in gwenview may require from the
user to launch Dolphin and increase the limit (especially for images in
RAW format) but does he/she know about it?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 07:32:12 +03:00
Ivailo Monev
252c2b96d5 kutils: ensure startup notification events are processed from KEMailDialog::showEvent()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 07:12:34 +03:00
Ivailo Monev
b2597e71e5 kimgio: restore device position conditionally
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 08:42:44 +03:00
Ivailo Monev
4bd5d6b609 kimgio: cast the character to uchar and return EOF on error from RAWDataStream::get_char()
note that LibRaw_buffer_datastream returns -1 if the position is
out-of-bounds but https://www.gnu.org/software/libc/manual/html_node/EOF-and-Errors.html
claims that EOF may not be -1

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 08:33:14 +03:00
Ivailo Monev
37217b7fe7 kimgio: warn if seeking fails in RAWDataStream::seek()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-25 18:53:56 +03:00
Ivailo Monev
a2ae8fe7f4 kutils: warn that attachements are not implemented
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-25 02:32:41 +03:00
Ivailo Monev
59f42738c2 kimgio: const-ify RAWDataStream member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-25 02:30:43 +03:00
Ivailo Monev
5c9b183447 kimgio: use custom datastream class in raw plugin
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-25 03:12:45 +03:00
Ivailo Monev
efea5fade2 kutils: implement SSL option for KEMail
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 20:52:30 +03:00
Ivailo Monev
4af17bbebf kutils: check curl_easy_setopt() return values in KEMail::send()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 19:49:18 +03:00
Ivailo Monev
b403cadd86 plasma: wallpaper cache lookup optimization
QFile::exists() uses temporary QFileInfo object that does the same

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 19:03:45 +03:00
Ivailo Monev
d4ac838463 plasma: return if the X11 property is deleted in Plasma::WindowEffects::highlightWindows()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:39:43 +03:00
Ivailo Monev
b0b9fb8fce plasma: remove redundant computations and checks in Plasma::WindowEffects functions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:37:05 +03:00
Ivailo Monev
35cb26227d plasma: use specialized QImage constructor instead of constructing and loading
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:31:40 +03:00
Ivailo Monev
1b15162b50 plasma: deal with TODO related to moving Plasma::Wallpaper member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:27:49 +03:00
Ivailo Monev
f34d660dbb plasma: automatic MOC-ing warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:26:01 +03:00
Ivailo Monev
55e7b76bd0 kio: fix regression since 704ef230d5
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 17:46:10 +03:00
Ivailo Monev
4e933b8cc8 kdecore: check if KDebug mutex is destroyed before using it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 17:34:08 +03:00
Ivailo Monev
76ffb428ee kio: add timeout timer to the KDirLister test
fixes possible test hang

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 17:20:51 +03:00
Ivailo Monev
c392733865 kutils: compiler warnings fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 16:54:31 +03:00
Ivailo Monev
0ef6ec5e26 kdecore: verify that there are no multiple occurrences of X character in KTemporaryFile test case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 16:43:37 +03:00