Commit graph

4733 commits

Author SHA1 Message Date
Ivailo Monev
b75a45c5d6 solid: set Solid::OpticalDisc::UnknownDiscType to be zero
much like other enums

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-02 04:56:22 +03:00
Ivailo Monev
4051004a5e kio: checkDesktopFile() function optimization
KFileItem::isRegularFile() is a simple mode (member) check while
KFileItem::mostLocalUrl() does some dirty work

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-02 01:57:31 +03:00
Ivailo Monev
5301a82e4c kfile: do not store the custom protocols in KUrlNavigator
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-02 01:48:56 +03:00
Ivailo Monev
dd88037d22 kdeui: resize all but the first KNotificationConfigWidget column to its contents
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-01 18:01:07 +03:00
Ivailo Monev
1969c7c22a kdeui: drop bogus multihead support
tottaly a hack, restoring applications on specific display will not work
either (not as long as it is possible to start session on any display, i.e.
restoring on specific display is unreliable)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-01 16:19:18 +03:00
Ivailo Monev
e482da9067 kded: rework phases logic to take any desktop session into account
much like XDG autostart except for KDED modules, requires adjustments to
modules that are automatically loaded in phase-1

in the future the logic may apply not only to modules during startup but
also when attempting to load a module in general

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 23:01:34 +03:00
Ivailo Monev
387bdaa93f generic: drop support for BrowserApplication config option
browser shall be determinted by the preferred service for "text/html",
"application/xhtml+xml" or any other MIME type for it (that includes
scheme handlers)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 21:22:56 +03:00
Ivailo Monev
7f3ecd0f64 kparts: remove unused stream-related API
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 15:56:16 +03:00
Ivailo Monev
0a4a0aa423 kparts: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 15:39:46 +03:00
Ivailo Monev
41631e5960 kparts: drop status bar extension
other than setting the status bar text no other feature functions
properly and there is a signal to change the part window status bar
text thus the class is redundant

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 05:06:55 +03:00
Ivailo Monev
ab09380d5b kparts: drop browser extension support
requires new KParts::ReadOnlyPart::urlAboutToChange() signal for
filelight, moving the KParts::BrowserExtension::PopupFlag and
KParts::BrowserExtension::ActionGroupMap to KonqPopupMenu (in the
kde-workspace repo, where the flags and typedef should be) and ofcourse
removing the unused bits in programs (kate, okular, etc.)

on a side note the extension, even if wrapped and created, is unused now
(was used by konqueror which is no longer supported)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 05:04:59 +03:00
Ivailo Monev
f43675b01d kparts: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 01:59:18 +03:00
Ivailo Monev
f8f34a1825 plasma: mark Plasma::AbstractRunner::hasRunOptions() as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:53:32 +03:00
Ivailo Monev
f92c0651ba plasma: mark Plasma::ConfigLoader getters as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:49:36 +03:00
Ivailo Monev
8bdcf8d36f plasma: mark Plasma::Containment getters as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:46:12 +03:00
Ivailo Monev
c800e36a5e plasma: mark Plasma::Corona::appletMimeType() as const
could batch such changes but - meh..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:41:57 +03:00
Ivailo Monev
1d07019215 plasma: Plasma::DialogShadowsPrivate::setupPixmaps() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:28:49 +03:00
Ivailo Monev
df591fa7ea plasma: mark Plasma::PackageStructure::entryList() as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:22:21 +03:00
Ivailo Monev
3b22af1d92 plasma: mark Plasma::View::trackContainmentChanges() as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:07:56 +03:00
Ivailo Monev
5ae3cd4ede plasma: remove unused Plasma::ItemTypes::LineEditType enum
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 23:27:52 +03:00
Ivailo Monev
78fa7ed2c6 plasma: mark Plasma::FrameSvg::prefix() as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 23:23:26 +03:00
Ivailo Monev
614724f90e plasma: initialize Plasma::ItemBackgroundPrivate members from its constructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 23:20:29 +03:00
Ivailo Monev
6b339097d2 plasma: mark Plasma::IconWidget::numDisplayLines() as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 23:14:37 +03:00
Ivailo Monev
0296d36fec kdeui: do not store the URLs list in temporary in kCheckMimeData() and KPixmapWidget::dropEvent()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 22:42:37 +03:00
Ivailo Monev
7f628f95f6 kdecore: pass the QByteArray objects size to QString constructors in KCmdLineOptions and KLocalizedString
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 21:23:50 +03:00
Ivailo Monev
a2530529a4 plasma: create key sequence objects from the key enums
create QKeySequence from string involves decoding the string (splitting it
into bits and pieces and matching it to a well known list of strings and
then create integer out of the decoded bits which is sub-optimal

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 20:48:43 +03:00
Ivailo Monev
e418ca826b kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 18:53:21 +03:00
Ivailo Monev
2cee1a15f8 kdeui: replace QLabel with KPixmapWidget in KPasswordDialog
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 16:16:00 +03:00
Ivailo Monev
6ed94914fe generic: get QImage and QPixmap objects width and height via the specialized methods
QImage::size() and QPixmap::size() construct QSize object from the internal
width and height members

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 03:45:25 +03:00
Ivailo Monev
55428d34e1 kdeui: someone's typo
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 01:39:19 +03:00
Ivailo Monev
35541fb02c kdeui: initialize variables in KWindowSystem::setOnDesktop()
see the previous commits

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 01:35:10 +03:00
Ivailo Monev
add566bc21 kdeui: initialize variables in NETWinInfo::kdeGeometry()
in case XGetGeometry() fails and the variables end-up being uninitialized

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 01:29:36 +03:00
Ivailo Monev
f454ad7a5b Merge branch 'master' of ssh://bitbucket.org/smil3y/kdelibs 2023-08-30 00:09:23 +03:00
Ivailo Monev
a09cf5455a kdecore: remove references to khotkeys
note the check if khotkeys is automatically started - it was a KDED module
not started because of XDG autostart desktop file

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 00:08:53 +03:00
Ivailo Monev
fadcacb651 kdeui: const-ify the KPixmapWidget::setAlignment() argument
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 20:52:45 +03:00
Ivailo Monev
23cc474596 kdeui: replace QLabel with KPixmapWidget in KNewPasswordDialog
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 19:20:18 +03:00
Ivailo Monev
099f49db36 generic: replace QLabel with the new KPixmapWidget class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 18:06:09 +03:00
Ivailo Monev
88598523d0 kdeui: new KPixmapWidget
the idea for QImage/QPixmap-optimized widget occurred to me while
writing kimageviewer (see the kde-playground repo), unlike the widget I
wrote for kimageviewer this one supports drag-n-drop tho and is drop-in
replacement for QLabel when showing only a pixmap is required. the
widget also shows a small image while dragging ala ksnapshot

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 08:59:51 +03:00
Ivailo Monev
7cb0785160 kdecore: add note about QDialog::exec() to the alarm() call in KDebugMessageBoxDevice::writeData()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 00:24:31 +03:00
Ivailo Monev
e6ef3d422f kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 21:38:59 +03:00
Ivailo Monev
ac69de425c kdecore: create the global KDirWatch instance on demand
Q_GLOBAL_STATIC() no longer creates instance on demand

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 20:59:11 +03:00
Ivailo Monev
cc6903476e kdecore: new KDirWatch methods to get and set the poll interval
requires the following commit from the Katie repo:
4795a577bff4f9db89c77195df763575a602bcc3

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 20:58:06 +03:00
Ivailo Monev
e7823a0484 generic: require Katie v4.14.0+
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 20:35:10 +03:00
Ivailo Monev
8703b0b0d5 kdeui: plug KNotificationManager memory leak
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 19:48:24 +03:00
Ivailo Monev
d6e335dbc6 kdeui: watch the notification configs for changes and lock KNotificationManager for thread-safety
in the old implementation KNotificationManager was not locked but it is
global static so it is subject to thread-safety issues thus it has to be
mutex-locked

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 19:41:37 +03:00
Ivailo Monev
bdd45bac0e kdeui: filter sound files with unknown extension in KNotificationConfigWidget::setNotification()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 19:08:35 +03:00
Ivailo Monev
cc338a8f3b kdeui: build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 16:09:52 +03:00
Ivailo Monev
9338606754 kdeui: fix possible double-free in KApplicationPrivate::parseCommandLine()
could happen only if "waitforwm" command line argument was passed and there
was no window manager

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 15:11:56 +03:00
Ivailo Monev
6c5b16e503 kdecore: remove unused and redundant KStringHandler::isUtf8() and KStringHandler::from8Bit() methods
use QTextCodec::codecForText() and QTextConverter instead

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 03:32:57 +03:00
Ivailo Monev
7145876ebd generic: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 03:25:39 +03:00