Commit graph

140 commits

Author SHA1 Message Date
Ivailo Monev
aa4a3c8b1e kdecore: const-ify extraSync in KSaveFile::finalize()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-20 00:52:48 +03:00
Ivailo Monev
aa8951e558 kdecore: correct fchown() return value check in KSaveFile::open()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-20 00:18:45 +03:00
Ivailo Monev
90dcd31b77 kdecore: tune busy loops for more throughput
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-16 20:39:36 +03:00
Ivailo Monev
82a503ebb3 kdecore: minor KLockFile optimization
it is cheaper to realloc() the QByteArray data

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-08 17:34:42 +03:00
Ivailo Monev
0812a98d19 kdecore: block only when another process is holding the lock in KLockFile::lock()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-08 14:12:41 +03:00
Ivailo Monev
2e9adc69c4 kdecore: kglobal header inclusion is no longer required in klockfile header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-08 13:57:07 +03:00
Ivailo Monev
fce08e0ff9 kdecore: KLockFile documentation corrections
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-08 06:54:40 +03:00
Ivailo Monev
5d42434579 kdecore: KLockFile branches optimizations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-08 03:41:29 +03:00
Ivailo Monev
cada9f78a4 kdecore: KLockFile rewrite
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-08 03:28:20 +03:00
Ivailo Monev
5a32a5865c kdecore: drop support for locking NFS files on servers v3 or older
note that KLockFile is used only by KConfig (its INI backend), anything
not using KConfig to access files is not affected by the lock method
KLockFile uses

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-08 01:20:50 +03:00
Ivailo Monev
ce5ff1c1c8 kdecore: implement temporary filepath generator
using it means no disk I/O to generate temporary filepaths in some cases

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-07 05:17:49 +03:00
Ivailo Monev
3ab3f3b47f kutils: new karchive library to replace KZip and KTar
it has to solve a few problems like:
1. blocking the current thread while listing, extracting or adding to
   archive
2. lack of support for some archive formats such as 7-zip in the
   previously available classes for dealing with archive
3. progress and error reporting

a KArchiveJob class may have to be implemented to solve the above
issues. the API is just as frustrating to use as KTar and KZip right now
tho and I am not happy with that but the class itself is a 3-rd rewrite
of what was once Python module, plugin for another project and now used
as base in library.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-06 16:53:55 +03:00
Ivailo Monev
e587e6ad28 kdecore: update comment and remove unused variable in KSaveFile::backupFile()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-03 14:34:32 +03:00
Ivailo Monev
5f7912004c kdecore: replace KTempDir::create() with its body
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-30 21:33:18 +03:00
Ivailo Monev
c03977c492 kdecore: move the rmtree() function to the top of ktempdir source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-30 21:32:24 +03:00
Ivailo Monev
0084c9aada kdecore: remove bogus check for HAVE_TEST definition in ktempdir source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-30 21:08:32 +03:00
Ivailo Monev
894a2d52bb kdecore: remove KLocale getters related to text codec
see the comment in KLocalePrivate::initEncoding()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-30 20:00:04 +03:00
Ivailo Monev
06f4ccefdf kdecore: correct return value checks in rmtree() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-28 01:22:51 +03:00
Ivailo Monev
a8aa470a11 kdecore: format ktempdir source and header files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-28 01:20:28 +03:00
Ivailo Monev
7dc5187778 kdecore: replace most of KRandomSequence with new KRandom::randomMax() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-26 12:58:37 +03:00
Ivailo Monev
a692d6026e kdecore: remove unused KAutoSaveFile class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-26 09:54:51 +03:00
Ivailo Monev
96299d83f5 kdecore: remove redundant KRandom::random() call in KTempDir::create()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-26 08:41:45 +03:00
Ivailo Monev
7d5ec84ab1 generic: compiler warnings fixes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-23 17:19:33 +03:00
Ivailo Monev
29a8459798 generic: remove checks for system headers that should be present
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-23 15:42:09 +03:00
Ivailo Monev
009e24b361 kdecore: do not stream dummy services data for compatibility
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-21 15:15:31 +03:00
Ivailo Monev
921b416638 kdecore: replace hardcoded stdout and stderr fd numbers with definitions from system unistd header
for reference:
https://linux.die.net/man/3/stdout

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-21 14:57:34 +03:00
Ivailo Monev
d3cb89b9e2 kdecore: do not deep-copy objects when iterating
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-21 04:09:59 +03:00
Ivailo Monev
2da5a3cdb5 kdecore: use uninitialized buffer in KArchive::addLocalFile()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-04 21:24:56 +03:00
Ivailo Monev
49c9cc97c3 kdecore: define PATH_MAX to _POSIX_PATH_MAX if not defined
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-04 21:23:53 +03:00
Ivailo Monev
424d478f7c generic: remove mac leftovers
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-26 03:26:59 +03:00
Ivailo Monev
3422ca4413 generic: get rid of KGLobal::staticQString()
global statics are static objects and the method is using one

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-02-18 19:49:54 +02:00
Ivailo Monev
4ee02ab2dc kio: remove unused KDataToolInfo, KDataToolAction and KDataTool classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-02-18 16:14:02 +02:00
Ivailo Monev
567dd1a64a kdecore: check if directory is already watched in KDirWatch::addDir()
fixes possible infinite recursion and high CPU usage by kded4 on FreeBSD

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-11-14 04:05:32 +02:00
Ivailo Monev
12c5882412 kdecore: remove obsolete Solaris workaround
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-09-18 20:31:28 +03:00
Ivailo Monev
3b4ea37bc9 kdecore: use Q_OS_SOLARIS definition for Solaris OS checks
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-09-02 18:22:04 +03:00
Ivailo Monev
8b03510799 kdecore: remove redundant return statement in KSaveFile::setFileName()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-08-27 03:58:40 +03:00
Ivailo Monev
b6f77397c5 kdecore: include paths header if present on the system
fixes mount points detection on systems using musl libc

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-08-26 01:44:23 +03:00
Ivailo Monev
8fab57aaa3 kdecore: remove ambiguous debug message based on condition feature [ci reset]
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-08-09 01:14:38 +03:00
Ivailo Monev
7968d99aed kdecore: remove redundant QObject header inclusion in kdebug header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-08-08 22:45:23 +03:00
Ivailo Monev
dd07d6844b kdecore: remove perror() debug stream function [ci reset]
TODO: use qt_error_string() instead of strerror() for thread-safety

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-08-08 21:55:18 +03:00
Ivailo Monev
9bc27f4d04 kdecore: mark KDebugPrivate::level() as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-07-26 01:58:40 +03:00
Ivailo Monev
67a8004abd kdecore: do not change the message type of toolkit message writer
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-07-26 01:58:05 +03:00
Ivailo Monev
e8c515b7ff kdecore: correct critical debug messages log level
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-07-21 13:11:43 +03:00
Ivailo Monev
1185408637 kdecore: use cheaper KDE::stat() instead of QFile::exists() in KDirWatch::setDirty()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-07-07 01:58:06 +03:00
Ivailo Monev
c2520f5903 generic: compiler warning fixes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-07-05 17:36:45 +03:00
Ivailo Monev
08ce90c113 kdecore: use usleep() instead of select() in KLockFile::lock()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-06-23 15:11:21 +03:00
Ivailo Monev
04b95f0de7 kdecore: indent and format
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-06-22 19:09:23 +03:00
Ivailo Monev
5221a763dd kdecore: check if file exists before attempting to add it back to the watched files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-06-20 14:22:31 +03:00
Ivailo Monev
95954aa997 kdecore: add warning to KSaveFile documentation [ci skip]
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-06-18 01:45:07 +03:00
Ivailo Monev
a0ff14b7ae kdecore: correct return type of KProcess methods returning PID
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-06-14 13:10:37 +03:00