Katana_mirror/kdelibs
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kdelibs.git synced 2025-02-24 10:52:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kdecore: remove redundant KRandom::random() call in KTempDir::create()

Browse source 
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2022-09-26 08:41:45 +03:00
parent 695ade0038
commit 96299d83f5
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
kdecore/io/ktempdir.cpp
View file

@ -37,7 +37,6 @@
#include <QtCore/QDir>
#include "kglobal.h"
#include "krandom.h"
#include "kcomponentdata.h"
#include "kstandarddirs.h"
#include <kdebug.h>
@ -67,8 +66,6 @@ KTempDir::KTempDir(const QString &directoryPrefix, int mode) : d(new Private)
bool KTempDir::create(const QString &directoryPrefix, int mode)
{
(void) KRandom::random();
QByteArray nme = QFile::encodeName(directoryPrefix) + "XXXXXX";
char *realName;
if((realName=mkdtemp(nme.data())) == 0)
@ -76,7 +73,7 @@ bool KTempDir::create(const QString &directoryPrefix, int mode)
// Recreate it for the warning, mkdtemps emptied it
nme = QFile::encodeName(directoryPrefix) + "XXXXXX";
kWarning(180) << "KTempDir: Error trying to create " << nme.data()
<< ": " << ::strerror(errno) << endl;
<< ": " << ::strerror(errno) << endl;
d->error = errno;
d->tmpName.clear();
return false;
@ -85,8 +82,7 @@ bool KTempDir::create(const QString &directoryPrefix, int mode)
// got a return value != 0
QByteArray realNameStr(realName);
d->tmpName = QFile::decodeName(realNameStr)+QLatin1Char('/');
kDebug(180) << "KTempDir: Temporary directory created :" << d->tmpName
<< endl;
kDebug(180) << "KTempDir: Temporary directory created :" << d->tmpName << endl;
mode_t umsk = KGlobal::umask();
if(chmod(nme, mode&(~umsk)) < 0) {