Commit graph

3342 commits

Author SHA1 Message Date
Ivailo Monev
a846ee0719 kdeui: update NET::timestampCompare() and NET::timestampDiff() documentation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 04:07:10 +02:00
Ivailo Monev
a4a374b1f2 kdeui: correct NET::timestampCompare() return type
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 04:05:39 +02:00
Ivailo Monev
ce11071465 kdeui: tune KSelectionOwner check time
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 03:48:33 +02:00
Ivailo Monev
f2d1398ac7 kdeui: use DefaultScreen() to get the screen in KWindowSystem::minimizeWindow()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 03:34:47 +02:00
Ivailo Monev
a265d51b10 kdeui: KWindowSystem::connectNotify() optimization
the QLatin1String constructs result in QString comparison

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 03:09:57 +02:00
Ivailo Monev
8358e51463 kdeui: remove redundant QFontInfo header inclusion in kglobalsettings source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 20:57:58 +02:00
Ivailo Monev
d82f02c8e9 kdeui: do not create QFontDatabase object on each KFontFamilyDelegate paint event
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 19:00:27 +02:00
Ivailo Monev
85dcff3799 kdeui: use QMutableListIterator<T>() in KFontChooser::Private::_k_family_chosen_slot()
the QStringList object is modified while iterated on

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 18:56:51 +02:00
Ivailo Monev
118be95512 kdeui: pass the screen root window to NETWinInfo constructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 16:49:00 +02:00
Ivailo Monev
cf78624887 kdeui: add new KSelectionOwner::currentOwnerWindow() method to query the current selection owner
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 07:29:15 +02:00
Ivailo Monev
8ea7b7bfbc kdeui: do not automatically release the selection when it is lost
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 07:21:45 +02:00
Ivailo Monev
97d6e7cd5f kdeui: send SIGKILL and SIGTERM from KSelectionOwner::claim(), fallback to XKillClient()
because xcompmgr does not watch its selection properly, killing is safe bet

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 06:53:23 +02:00
Ivailo Monev
40ad0ba5ac kdeui: pass the current owner to kWaitForOwner() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 03:02:41 +02:00
Ivailo Monev
6b0375f64f kdeui: wait for owner after killing it in KSelectionOwner::claim()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 04:35:24 +02:00
Ivailo Monev
e8e1d7c908 kdeui: enable KSelectionOwner debug and warning messages
with the QDebug rewrite they no longer cause KWin crashes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 01:57:27 +02:00
Ivailo Monev
2e9329f1a1 kdeui: make use of KGlobalSettings::isMultiHead() in KApplication::saveState()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-14 23:59:22 +02:00
Ivailo Monev
8e5dd5ea50 generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-14 15:50:30 +02:00
Ivailo Monev
8611f36591 kio: correct reference to kDebug()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 00:59:14 +02:00
Ivailo Monev
3339338121 generic: prepare for Katie changes
note that kDebug(), kWarning(), etc. automatically add end of line

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 00:46:32 +02:00
Ivailo Monev
9b41127ecb generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 00:40:18 +02:00
Ivailo Monev
a5ad00dcf8 kdeui: pass the display to KXErrorHandler from KSelectionOwner
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-12 21:39:59 +02:00
Ivailo Monev
8d8db4e3c6 kdeui: use unique connection to X11 display from KSelectionOwner
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-12 15:19:03 +02:00
Ivailo Monev
1fe8252c95 kdeui: remove redundant KCategorizedView reimplementations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-12 14:50:04 +02:00
Ivailo Monev
0af76ed8a1 kdeui: set the selection window mask to NoEventMask
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-12 13:56:53 +02:00
Ivailo Monev
65e719b17b kdeui: comment out some KSelectionOwner debug messages
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-12 00:50:14 +02:00
Ivailo Monev
c4b1252ff5 kdeui: remove unused KSplashScreen member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-11 00:09:58 +02:00
Ivailo Monev
533d588db5 kdeui: remove redundant QPixmap header inclusion in ksplashscreen source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-11 00:08:58 +02:00
Ivailo Monev
f4cd0621cf kdeui: format and indent ksplashscreen source and header files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-11 00:08:21 +02:00
Ivailo Monev
1039216fd8 kdecore: delete the KDETranslator instance from removeKDETranslator() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-10 14:53:35 +02:00
Ivailo Monev
0b9281b360 kdecore: install and remove KDETranslator via constructor/deconstructor functions
it has to be done only once (because it calls global static to translate),
does not have thread requirement (QCoreApplication locks when installing
or removing translator) and it checks if KGlobal has locale via
KGlobal::hasLocale() to ensure it is not attempting to call
KGlobal::locale() after KGlobal destruction

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-10 06:51:36 +02:00
Ivailo Monev
3e973ba64b kdeui: KPixmap assignment operator optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-10 00:40:02 +02:00
Ivailo Monev
effe9ef889 kdeui: use the new QPixmap::toX11Pixmap() method in KPixmap
altought KPixmap is used mostly for pixmaps with depth equal to 32 not
being able to convert pixmaps with other depth may be a surprise so use
QPixmap::fromX11Pixmap() in KPixmap::toImage() just in case

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 20:02:39 +02:00
Ivailo Monev
b63686e9d0 generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 04:43:56 +02:00
Ivailo Monev
49c47bf850 kdeui: add comments about values passed to X11 functions in kpixmap source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 01:52:33 +02:00
Ivailo Monev
28ae883aeb kdeui: KPixmap from QPixmap constructor optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 01:40:39 +02:00
Ivailo Monev
b9169a25a5 kdeui: KPixmap::toImage() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 01:10:33 +02:00
Ivailo Monev
a4c80f09d2 kdeui: log KPixmap and KSelectionOwner debug/warning messages to the kdeui (kdelibs) debug area
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 02:28:14 +02:00
Ivailo Monev
a5734faf0f kdeui: new KPixmap class
very much written for use case, not to make sense. while porting to it I
already noticed there are leaks for X11 pixmaps and may have to write
glue code to keep track of the pixmaps and release them before
application quits, that will be a huge performance penalty tho so may
have to be ifdef'ed for debug builds only

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 02:08:27 +02:00
Ivailo Monev
43cf97b00d kdeui: unexport KdeUiProxyStyle
not used outside kdeui library

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-08 19:30:37 +02:00
Ivailo Monev
38cc86db41 plasma: export DialogShadows class
there are 3 copies of the sources for that class because it is not
exported (one here, one in kde-workspace and one in kde-extraapps) with
one class that is very similar to it - PanelShadows (in kde-workspace
repo, part of plasmagenericshell library)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-07 18:05:11 +02:00
Ivailo Monev
6b7cd4e1e4 kdeui: remove redundant selection clearing in KSelectionOwner::release()
if both the destroy and selection clearing are delivered (in that order) to
selection poller, the poller selection may be cleared

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 11:27:11 +02:00
Ivailo Monev
e07fc01227 kdecore: return the value of KGlobal::hasLocale() from KDETranslator::isEmpty() and check it from KDETranslator::translate()
fixes possible crash due to accessing the private KLocale data after
destruction

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 10:10:46 +02:00
Ivailo Monev
7baf0c9d61 kdeui: catch X11 errors during selection owner window creation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 08:14:33 +02:00
Ivailo Monev
081477c628 kdeui: do not attempt to kill timer with 0 as ID in KSelectionOwner::release()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 08:05:15 +02:00
Ivailo Monev
cdc18e2e52 kdeui: remove unused QTimer header inclusion in kselectionowner source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 06:12:58 +02:00
Ivailo Monev
a6367dede7 kdeui: brief KSelectionOwner documentation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-06 06:12:37 +02:00
Ivailo Monev
491dc6383a kdeui: simplify selection claiming
using XSetSelectionOwner() to do it works like a charm

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 20:11:20 +02:00
Ivailo Monev
7f3719e3c0 kdeui: make KSelectionOwner::claim() and KSelectionOwner::release() public slots
now they can be connected to signals such as QCoreApplication::aboutToQuit()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 17:17:05 +02:00
Ivailo Monev
a6165ed19b kdeui: simplify selection window creation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 16:58:35 +02:00
Ivailo Monev
d88d74f0c9 plasma: remove unused header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 12:56:51 +02:00