Ivailo Monev
98f1b0b90a
plasma: fix shortcuts
...
who tought using the same shortcut for multiple actions is going to work?
the single character shortcuts are very likely to conflict with other
shortcuts aswell
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 11:47:09 +02:00
Ivailo Monev
f9b87a7adf
kio: update comment in PreviewJobPrivate::getOrCreateThumbnail()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 06:13:29 +02:00
Ivailo Monev
e3f470feab
kio: typo
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 06:12:13 +02:00
Ivailo Monev
9e3f2b3eb2
kio: log PreviewJob messages to the kio (KIOJob) debug area
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 06:10:02 +02:00
Ivailo Monev
9e5c94b905
kio: check if any of the preferred services is in the list of enabled plugins
...
the reason for checking the preffered offers first should be obvious - it
is questionable which match should be done first. should it be the glob or
the exact match? chicken and egg thing
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 02:25:06 +02:00
Ivailo Monev
bc10416911
kio: try to find thumbnailer plugin via KMimeTypeTrader::query() first
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 02:13:58 +02:00
Ivailo Monev
2e6f3fba02
kio: PreviewJobPrivate::startPreview() rewrite
...
mostly to make the MIME types check consistent by using KMimeType::is()
for the comparison (as done by KPreviewPropsPlugin::supports() for example)
and to filter the ThumbCreator service type (to avoid invalid KMimeType
checks)
fixed KFileMetaInfo regression for plugins that use globs aswell
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 01:25:33 +02:00
Ivailo Monev
27de045733
kio: drop unused remote thumbnailers feature
...
none of the plugins support it and it slows down the thumbnail
preview generation (or fetching of existing thumbnail)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 23:25:40 +02:00
Ivailo Monev
de3384ee46
kio: format and indent previewjob source file
...
side note: the MIME matching code in PreviewJobPrivate::startPreview() is
spaghetti
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 22:41:13 +02:00
Ivailo Monev
86082941ab
kded: load service modules in defined order
...
previously autoloaded modules would be loaded in arbitrary order regardless
of what phase they are ment for from Kded::initModules() but phase two
should be done by ksmserver
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 20:51:10 +02:00
Ivailo Monev
b6d30b98fb
kded: update examples in HOWTO
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 20:10:39 +02:00
Ivailo Monev
bab2e1b6e4
kded: log the kde_running variable value
...
if it is false then modules that are not ment for full session are not
automatically loaded on init so it shall serve as a hint when debugging
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 20:01:24 +02:00
Ivailo Monev
e20d610997
kutils: load kpasswdstore module in phase 1
...
see the hack in kdirshare module
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 19:01:10 +02:00
Ivailo Monev
d37a7c4c6e
kdeui: ensure the favicon has size suitable for overlay
...
with commit de8c7f6af1d79c6b3cd3e8b2a21a56a020163b73 (in kde-workspace) I
changed the behaviour of favicon KDED module to not down-scale the favicons
to 16x16 and that ofcourse means large favicons (e.g. 256x256, yes some
websites have favicon with such size) may be overlayed on top of 32x32 icon
which does not look OK.
with this change the icon overlay will match the visual ratio of any
other icon overlay, unfortunetly that means scaling the favicon (i.e. for
large icons such 256x256, favicon with size 16x16 may be up-scaled to 32x32
) but it will still look better than it used to
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 04:44:04 +02:00
Ivailo Monev
0cafb27096
kdeui: do not detach the QImage object in KStatusNotifierItemPrivate::imageToStruct()
...
it cannot be detached even if not copied (as done when it is not in
QImage::Format_ARGB32 format) because image is constant reference but if it
is converted it will be actually detached, also QByteArray takes ownership
of the data
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-24 20:23:56 +02:00
Ivailo Monev
aaef91f3d4
kdecore: prepare for Katie changes
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-24 00:10:47 +02:00
Ivailo Monev
e50350ac20
plasma: remove redundant QString construct in correctPathCase() function
...
path is a QString constant reference
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-23 22:02:32 +02:00
Ivailo Monev
050116df49
kdecore: remove the redundant Sonnet::QSpellEnchantClient::reliability() method
...
sonnet used to have plugins, now there is only one client and it is builtin
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-23 03:22:22 +02:00
Ivailo Monev
01129bd9a8
kdecore: use proper type for the ignored words list
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-23 03:10:28 +02:00
Ivailo Monev
25380847aa
kdecore: Sonnet::Loader::createSpeller() optimization
...
meanwhile looking for dictionary memory leaks..
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-23 02:43:09 +02:00
Ivailo Monev
cdba3b2f2a
kdecore: remove redundant breaks in Sonnet::Speller::testAttribute()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-23 02:35:55 +02:00
Ivailo Monev
87d9092ab3
kdecore: Sonnet::Speller::availableDictionaries() optimization
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-23 02:33:11 +02:00
Ivailo Monev
2ee616b91a
kdecore: do not deep-copy the QString in Sonnet::Loader constructor
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-23 02:32:16 +02:00
Ivailo Monev
8d59335206
kdecore: PCI IDs database update
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 23:45:37 +02:00
Ivailo Monev
169eb9fed6
Merge branch 'master' of https://scm.osdn.net/gitroot/kde/kdelibs
2022-11-22 23:15:46 +02:00
Ivailo Monev
7d102a665e
kdeui: remove FIXME
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 23:45:40 +02:00
Ivailo Monev
b7e58ab6e8
kdeui: replace tab with space in KPassivePopup::setPopupStyle()
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 23:15:33 +02:00
Ivailo Monev
0ddd9e7046
kdeui: rewrite KGlobalSettings graphics effects level getter
...
why does a method named reloadStyleSettings reload graphics effects level
settings and not application style settings?
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 04:44:24 +02:00
Ivailo Monev
8cc2e71c91
kdeui: enable tear-off handles depending on the graphic effects level
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 23:39:15 +02:00
Ivailo Monev
1d760e4f09
kdeui: remove reference to non-existing KPopupTitle class
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 23:35:59 +02:00
Ivailo Monev
521d3cd59b
kdeui: remove unused KFadeWidgetEffect class
...
for example on how to do it (somewhat) properly see KMessageWidget
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 20:05:45 +02:00
Ivailo Monev
a37bd35627
kdeui: render KMessageWidget snapshot into QImage
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 18:44:19 +02:00
Ivailo Monev
d6fc2d834b
kdeui: remove redundant reimplementations
...
the purge of binary compatibility bits is always on
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 16:05:38 +02:00
Ivailo Monev
a4ec0f5724
kutils: implement login via OAuth access token
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 07:56:02 +02:00
Ivailo Monev
f79e175d56
kdeui: format and indent khelpmenu source file
...
those breaks after return look very out of place
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 04:37:27 +02:00
Ivailo Monev
5c8d1d2e6b
kdeui: remove redundant reimplementations
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 04:11:11 +02:00
Ivailo Monev
3b6f69ac67
kdeui: remove redundant KMessageWidget::showEvent() reimplementation
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 02:17:22 +02:00
Ivailo Monev
c43d9e8df7
kdeui: prepare for Katie changes
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-19 05:02:18 +02:00
Ivailo Monev
7555229053
kdeui: print error message if reading hex QColor from config results in invalid color
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-19 00:56:26 +02:00
Ivailo Monev
5ca124cb4e
kimgio: webp plugin review
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-18 14:49:13 +02:00
Ivailo Monev
772e88b926
kimgio: rename variable for consistency
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-18 14:43:07 +02:00
Ivailo Monev
24e00f8ca5
kdeui: remove unused QFontDatabase header inclusion in kfontdialog source file
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 15:20:05 +02:00
Ivailo Monev
6424bc5ab8
kdeui: correct QFontDatabase::standardSizes() usage in KFontSizeAction
...
since it is a static method there is no need to create QFontDatabase object
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 15:18:57 +02:00
Ivailo Monev
792a8a442c
kdeui: remove redundant KTabBar reimplementations
...
binary compatibility bits..
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 02:44:18 +02:00
Ivailo Monev
d67610909c
kio: remove documentation for non-existing methods
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 03:48:28 +02:00
Ivailo Monev
27b5f27d2e
kdeui: check if Xfixes is available before using xfixesEventBase
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 00:45:38 +02:00
Ivailo Monev
78ff2c38ef
kdeui: initialize KWindowSystemPrivate::xfixesEventBase
...
now the compiler will not be able to detect uninitialized usage, it did not
warn for it either tho
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 00:44:43 +02:00
Ivailo Monev
d76b5a1e64
kdeui: install KWindowSystemPrivate event filter after Xfixes check
...
otherwise xfixesEventBase may be used uninitialized (it still can be but
only if Xfixes is not available, to be fixed in the follow-up commit)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 00:37:11 +02:00
Ivailo Monev
38635d4406
kio: implement IconAlpha config option for previews
...
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 23:35:39 +02:00
Ivailo Monev
b5c5b5c85a
kio: remove preview overlay icon alpha override
...
setting it to zero essentially disables it, an option for it will be
implemented instead
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 23:34:32 +02:00