Commit graph

5091 commits

Author SHA1 Message Date
Ivailo Monev
8c2136445e plasma: remove unused Plasma::RunnerContext::Type enum
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:35:46 +03:00
Ivailo Monev
df9bffd10c plasma: reset runners context before waiting
so that runners know that it is time for them to stop because the context
is no longer valid

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:28:17 +03:00
Ivailo Monev
bd3425b187 plasma: Plasma::RunnerManager documentation update
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:23:23 +03:00
Ivailo Monev
8791f0571b plasma: do not emit Plasma::RunnerContext::matchesChanged() from Plasma::RunnerContext::reset()
any preperation for matching anew should be done prior to starting a query

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:14:48 +03:00
Ivailo Monev
6514cb22a6 plasma: remove unused private member
performance gain for the runners, there should be no duplicates and even
if there was the only thing that was done about it is to print a debug
message when build for debugging

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:06:26 +03:00
Ivailo Monev
595991ff55 plasma: simplify runners setup and correct signals emission
Plasma::RunnerManager::matchesChanged() is now emitted when new matches
arive, Plasma::RunnerManager::queryFinished() when matching is done (all
match jobs finished)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 18:18:42 +03:00
Ivailo Monev
f452997709 plasma: remove unused and redundant Plasma::RunnerContext methods
nothing but the manager is supposed to remove matches and there is a
Plasma::RunnerContext::reset() method

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 17:32:27 +03:00
Ivailo Monev
ac5d407fd5 plasma: remove unused Plasma::RunnerContext methods arguments
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 17:09:11 +03:00
Ivailo Monev
97cfe669fc plasma: do not magically adjust the speed of runners
I've optimized the runners enough to not need such bits

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 07:53:05 +03:00
Ivailo Monev
afb548b2ed plasma: unlock Plasma::QueryMatch
assuming that match (Plasma::QueryMatch) objects are modified by one thread
in the runner itself only or operated on a copy of one matching does not
need a mutex

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 07:43:34 +03:00
Ivailo Monev
5f23665baa kdecore: use regular integer for the active threads counter in KThreadPool
with KThreadPool being mutex-locked it should not be subject to
race-condition

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 07:06:00 +03:00
Ivailo Monev
632dd982df plasma: remove redundant KThreadPool::setMaxThreadCount() call
KThreadPool uses the same value by default

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 06:40:49 +03:00
Ivailo Monev
ecd57181ea kdecore: delete the threads from KThreadPool
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 06:37:12 +03:00
Ivailo Monev
a871678ec4 plasma: rework runners classes to not pass around the context
unused in most cases, shared data and dangerous to pass around

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 05:15:02 +03:00
Ivailo Monev
2f485d5376 generic: replace QThreadPool and QRunnable with custom class
on a side note it does not solve any thread-safety issues, such are out
of the scope of the class

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 03:05:03 +03:00
Ivailo Monev
747c37269b plasma: remove unused Plasma::RunnerContext MIME type info
runners can determine it anyway, generic type detection is done already

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 01:02:11 +03:00
Ivailo Monev
b2a66f5a72 plasma: const-ify Plasma::RunnerContext arguments
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 00:16:31 +03:00
Ivailo Monev
7683b1d29e plasma: drop redundant Plasma::QueryMatch type feature
it could be used to sort ala relevance but what would the relevance feature
would be for then?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 00:06:05 +03:00
Ivailo Monev
c4c494d705 plasma: do not copy the query match in Plasma::RunnerContext::addMatch()
its relevance remains unchanged

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 23:01:28 +03:00
Ivailo Monev
e7fcb90738 plasma: actually use the priority
the runners priority property was not used for anything, it is now

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 21:35:38 +03:00
Ivailo Monev
4152c2b044 plasma: de-virtualize Plasma::Animation::setDuration() and make it public
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 21:10:35 +03:00
Ivailo Monev
54d5ec4782 plasma: initialize all members of private class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 20:05:47 +03:00
Ivailo Monev
22e93f449e plasma: properly initialize internal class members
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 19:57:40 +03:00
Ivailo Monev
935b228484 plasma: simplify animations classes
the proxy class Plasma::EasingAnimation is simply redundant, just one
more virtual function call which slows the animations

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 19:44:26 +03:00
Ivailo Monev
eb37060455 kdecore: remove unused KMimeGlobsFileParser member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 16:04:21 +03:00
Ivailo Monev
49fea6b1c2 kdecore: globs parsing optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 05:16:30 +03:00
Ivailo Monev
e6fdfa4d8b kdecore: remove bogus KMimeType constructor argument
the comment is set when the xml file is parsed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 05:11:11 +03:00
Ivailo Monev
b9c83af23a kdecore: drop support for the deprecated globs file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 05:03:19 +03:00
Ivailo Monev
3bbaffe82c kdecore: adjust tests to recent changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 04:53:13 +03:00
Ivailo Monev
c303467164 kutils: drop unused classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 03:52:20 +03:00
Ivailo Monev
c1296191d2 kdecore: PCI IDs database update
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 03:24:24 +03:00
Ivailo Monev
76fa8e28b8 plasma: remove checks for non-existing properties in Plasma::ScrollWidget
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 01:47:22 +03:00
Ivailo Monev
a179fd4603 plasma: drop unused runners matching feature
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 00:49:17 +03:00
Ivailo Monev
3f4425e9bb plasma: remove redundant Plasma::Animator::Animation::LastAnimation enum
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 23:31:47 +03:00
Ivailo Monev
8163991f03 plasma: rework runners to not rely on configuration
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 23:23:58 +03:00
Ivailo Monev
1f11147bd4 plasma: drop redundant Plasma::PluginLoader class
not finished either

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 22:33:18 +03:00
Ivailo Monev
95340211ee plasma: drop now unused runner options feature
not to be confused with runners configuration

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 21:40:44 +03:00
Ivailo Monev
5597939dbf plasma: remove unused header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 21:40:17 +03:00
Ivailo Monev
71e27caf2e kdeui: place the close button of KMessageWidget conditionally again
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 20:15:45 +03:00
Ivailo Monev
324518962f kdeui: drop redundant KMessageWidget slots
animating KMessageWidget could not be done properly, not with fade and
not with size animation. it was bad idea from the start

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 19:58:27 +03:00
Ivailo Monev
f0b2eac1f1 kdeui: use custom close button properties in KMessageWidget
and because there is no meat from the old implementation copyright goes to
me

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 18:44:16 +03:00
Ivailo Monev
d36ed141e9 kdeui: KMessageWidget painting optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 16:31:35 +03:00
Ivailo Monev
6daac470e8 kdeui: drop unused KColorValueSelector, KGradientSelector, KSelector and KXYSelector classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 15:43:51 +03:00
Ivailo Monev
a2e4da709f kdeui: remove unused private member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 14:39:40 +03:00
Ivailo Monev
7df1c4b6bb kdeui: fix possible use of uninitialized variables in KHueSaturationSelector
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 14:19:33 +03:00
Ivailo Monev
d47d67b645 kdeui: drop unused KRuler class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 05:44:42 +03:00
Ivailo Monev
f4c2f5c84e generic: drop stylesheet support
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 04:31:21 +03:00
Ivailo Monev
ce983caed6 kdeui: KMessageWidget tweak
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 03:36:12 +03:00
Ivailo Monev
1c84eaf43b kdeui: rework KMessageWidget
using the selection color for information messages when the text is
selectable was questionable atleast, overriding QFrame action setters,
using QFrame as base class when none of its features were used..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 03:24:12 +03:00
Ivailo Monev
4857f6cd17 kdeui: rework KAboutKdeDialog to expand the text as much as possible
also to parent widgets properly

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-15 22:55:46 +03:00