Commit graph

4765 commits

Author SHA1 Message Date
Ivailo Monev
7ed5ec71eb kdeui: add the program icon name to the crash data
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-08 18:32:37 +03:00
Ivailo Monev
aa0cc77a6a solid: keep reference to the QByteArray object in Solid::Backends::UDev::NetworkInterface::isWireless()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-08 07:50:24 +03:00
Ivailo Monev
0fc1865606 solid: remove redundant Solid::Backends::UDev::UDevDevice::devicePath() method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-08 07:31:29 +03:00
Ivailo Monev
2da2e7ddb6 solid: remove unused Solid::Backends::UDev::UDevDevice::device() method
return the same as Solid::Backends::UDev::UDevDevice::devicePath() too

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-08 07:29:18 +03:00
Ivailo Monev
d519e61cb5 solid: UdevQt::Client::monitorReadyRead() optimization
because the string returned by udev_device_get_action() is valid for as
long as the device is storing it in QByteArray is redundant

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-08 07:12:22 +03:00
Ivailo Monev
ccfd17a401 solid: remove unused UdevQt::Client signals
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-08 06:45:34 +03:00
Ivailo Monev
e6aef8e5d5 solid: parent the QSocketNotifier to UdevQt::Client
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-08 06:42:01 +03:00
Ivailo Monev
8d3250d896 kdecore: log debug message before and after the call in KAuthorization::execute()
otherwise it is bombardment of messages if the KAuthorization area is enabled

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-08 06:24:09 +03:00
Ivailo Monev
8cb49b86db kdeui: replace entities in rules from scoop-rules.py script
"< >" is a placeholder I am assuming, question is for what?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-08 04:45:38 +03:00
Ivailo Monev
3e5ec11092 kdecore: use KLockFile instead of service check in KAuthorization
the service check is racy, KLockFile is as not (assuming the combination of
O_EXCL and O_CREAT is not racy which is not KLockFile's responsibility)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-08 03:14:17 +03:00
Ivailo Monev
60a5b15a39 kdecore: reduce the KAuthorization helper delayed stop time to 100ms
the sooner the better

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-08 00:08:21 +03:00
Ivailo Monev
1467f3cae0 solid: do not block while waiting for org.kde.SolidUiServer replies
so that, for example, the plasma devicenotifier applet does not block
plasma-desktop events when mounting/unmounting

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-07 21:55:19 +03:00
Ivailo Monev
8ac9b27855 generic: don't sleep while waiting for D-Bus replies
waiting for D-Bus replies to finish is enough business

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-07 21:44:47 +03:00
Ivailo Monev
49637b249d solid: unmount optical drives conditionally
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-07 21:40:51 +03:00
Ivailo Monev
b77a8b70fd solid: unmount the optical drive before ejecting it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-07 20:43:21 +03:00
Ivailo Monev
4d6cc60bc6 solid: return QByteArray object from UdevQt::Device::driver()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-07 08:38:16 +03:00
Ivailo Monev
35241fbc27 solid: return QByteArray object from UdevQt::Device::subsystem()
it is handled as latin1 anyway

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-07 08:30:09 +03:00
Ivailo Monev
d69e5328dd solid: const-ify Solid::Backends::UDev::UDevDevice::udevDevice() method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-07 08:19:52 +03:00
Ivailo Monev
134fd23a6c solid: do not deep-copy the device object for Solid::Backends::UDev::UDevDevice constructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-07 08:16:38 +03:00
Ivailo Monev
189599adee kdeui: sort KKeyboardLayout table entries by description
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-05 22:55:21 +03:00
Ivailo Monev
94a7028fdb kdeui: KKeyboardLayout review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-05 18:54:44 +03:00
Ivailo Monev
ce1dcbb552 kdeui: new KKeyboardLayout class
KKeyboardLayout along with Solid::Input are to be used not only in a
reimplementation of the keyboard plasma applet but also potentially
for a software input panel (QEvent::RequestSoftwareInputPanel and
QEvent::CloseSoftwareInputPanel handler)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-05 18:15:25 +03:00
Ivailo Monev
aeba52714a solid: new Solid::Input class for mouse, keyboard and joystick devices
includes camel-case header for Solid::Video as it was noticed to be
missing while working on the handling the new class in kde-workspace

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-03 20:21:52 +03:00
Ivailo Monev
086e08f00a kutils: start counting from 1 in KPowerManagerInhibitImpl::Inhibit()
because 0 should be invalid cookie, much like the inhibition cookie of the
org.freedesktop.ScreenSaver interface

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-03 16:56:56 +03:00
Ivailo Monev
9195193191 kutils: log debug messages when there is no valid inhibition interface
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-03 16:33:03 +03:00
Ivailo Monev
a39e7777ea kutils: show notification after switching power management profile
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-03 04:00:12 +03:00
Ivailo Monev
057f775782 solid: use "battery-charging"-prefixed icons for fully charged batteries
battery can be fully charged but because it is plugged in not discharging

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-03 03:40:47 +03:00
Ivailo Monev
d254c051ed kdecore: do not insert the solid_qt catalog by default
that means to get the translations linking to solid library or calling
KGlobal::locale()->insertCatalog("solid_qt") is required

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-03 02:20:43 +03:00
Ivailo Monev
d03b3a3f47 kdeui: do not create startup ID from KToolInvocation
KToolInvocation does not check if the application/service that is to be
started actually supports startup notification, it is done by KLauncher and
KRun tho (as it should be)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-03 01:46:51 +03:00
Ivailo Monev
a637b54384 solid: workaround for bogus udev "change" event
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-03 01:33:51 +03:00
Ivailo Monev
2d1d7daf82 kio: drop fake startup notification support
silent_arg was used to fake startup notification for non-compliant
applications, that shall not be the case anymore - when applications do not
claim startup notification support or it is simply disabled for specific
use case (as is done by ark for its service actions) then there shall be no
startup notification, silent or otherwise

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-03 00:46:58 +03:00
Ivailo Monev
6f822a30bb solid: implicitly convert the D-Bus reply to the value type in Solid::PowerManagement::beginSuppressingSleep() and Solid::PowerManagement::stopSuppressingSleep()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-03 00:16:00 +03:00
Ivailo Monev
b75a45c5d6 solid: set Solid::OpticalDisc::UnknownDiscType to be zero
much like other enums

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-02 04:56:22 +03:00
Ivailo Monev
4051004a5e kio: checkDesktopFile() function optimization
KFileItem::isRegularFile() is a simple mode (member) check while
KFileItem::mostLocalUrl() does some dirty work

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-02 01:57:31 +03:00
Ivailo Monev
5301a82e4c kfile: do not store the custom protocols in KUrlNavigator
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-02 01:48:56 +03:00
Ivailo Monev
dd88037d22 kdeui: resize all but the first KNotificationConfigWidget column to its contents
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-01 18:01:07 +03:00
Ivailo Monev
1969c7c22a kdeui: drop bogus multihead support
tottaly a hack, restoring applications on specific display will not work
either (not as long as it is possible to start session on any display, i.e.
restoring on specific display is unreliable)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-09-01 16:19:18 +03:00
Ivailo Monev
e482da9067 kded: rework phases logic to take any desktop session into account
much like XDG autostart except for KDED modules, requires adjustments to
modules that are automatically loaded in phase-1

in the future the logic may apply not only to modules during startup but
also when attempting to load a module in general

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 23:01:34 +03:00
Ivailo Monev
387bdaa93f generic: drop support for BrowserApplication config option
browser shall be determinted by the preferred service for "text/html",
"application/xhtml+xml" or any other MIME type for it (that includes
scheme handlers)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 21:22:56 +03:00
Ivailo Monev
7f3ecd0f64 kparts: remove unused stream-related API
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 15:56:16 +03:00
Ivailo Monev
0a4a0aa423 kparts: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 15:39:46 +03:00
Ivailo Monev
41631e5960 kparts: drop status bar extension
other than setting the status bar text no other feature functions
properly and there is a signal to change the part window status bar
text thus the class is redundant

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 05:06:55 +03:00
Ivailo Monev
ab09380d5b kparts: drop browser extension support
requires new KParts::ReadOnlyPart::urlAboutToChange() signal for
filelight, moving the KParts::BrowserExtension::PopupFlag and
KParts::BrowserExtension::ActionGroupMap to KonqPopupMenu (in the
kde-workspace repo, where the flags and typedef should be) and ofcourse
removing the unused bits in programs (kate, okular, etc.)

on a side note the extension, even if wrapped and created, is unused now
(was used by konqueror which is no longer supported)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 05:04:59 +03:00
Ivailo Monev
f43675b01d kparts: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 01:59:18 +03:00
Ivailo Monev
f8f34a1825 plasma: mark Plasma::AbstractRunner::hasRunOptions() as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:53:32 +03:00
Ivailo Monev
f92c0651ba plasma: mark Plasma::ConfigLoader getters as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:49:36 +03:00
Ivailo Monev
8bdcf8d36f plasma: mark Plasma::Containment getters as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:46:12 +03:00
Ivailo Monev
c800e36a5e plasma: mark Plasma::Corona::appletMimeType() as const
could batch such changes but - meh..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:41:57 +03:00
Ivailo Monev
1d07019215 plasma: Plasma::DialogShadowsPrivate::setupPixmaps() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:28:49 +03:00
Ivailo Monev
df591fa7ea plasma: mark Plasma::PackageStructure::entryList() as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 00:22:21 +03:00