Commit graph

1012 commits

Author SHA1 Message Date
Ivailo Monev
728dc0838e kdecore: remove unused headers inclusions in kurl source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 23:20:20 +03:00
Ivailo Monev
13fdc7b7cd kdecore: do not prettify the URL in KUrl::pathOrUrl()
here is how to make browsers barf - check the tooltip and where the browser
thinks the URL points to:
https://ibb.co/cyhwppK

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 23:13:38 +03:00
Ivailo Monev
ef02376c35 kdecore: add KUrl query and fragment test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 21:25:20 +03:00
Ivailo Monev
67d6fa8588 generic: adjust expected tests data
QUrl::StripTrailingSlash removes all trailing slashes and KUrl does not
convert to percentage encoding - local file URLs remain the same when
passed around.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 20:57:21 +03:00
Ivailo Monev
0a5fadde75 kdecore: do not change the scheme from KUrl::cleanPath()
the fact that many KUrl methods change it (by calling KUrl::setPath()) is
just bonkers but that's how it was implemented - to convert to file scheme
from setters

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 20:44:03 +03:00
Ivailo Monev
78c109df85 kdecore: more compatible KUrl
abusing the QUrl path for local files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 20:10:09 +03:00
Ivailo Monev
8f348b4c5b kdecore: remove FIXME for KUrl
so far so good:
https://ibb.co/TYN4z3x

now on to the quircks..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 03:00:21 +03:00
Ivailo Monev
ea02aa2c1a kdecore: fix regression since 7b8ff71eba
oops

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 00:53:35 +03:00
Ivailo Monev
341e16d4c6 kdecore: update comment in KUrl::prettyUrl()
konqueror is no more

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 23:58:08 +03:00
Ivailo Monev
5e4732f809 kdecore: KUrl::List from QList<QUrl> optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 23:55:19 +03:00
Ivailo Monev
c81c3bd71d kdecore use the new QUrl::AddTrailingSlash enum
requires the following commit from Katie repo:
3369835da10412451d082713433321a72f25e0df

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 23:08:09 +03:00
Ivailo Monev
7b8ff71eba kdecore: KUrl rewrite to output encoded strings
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 22:33:18 +03:00
Ivailo Monev
b4861f86d5 kdecore: rename variable in uriListData()
bad variable naming - clashes with the function name and inconsistent

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 18:22:41 +03:00
Ivailo Monev
840f3a3b68 kdecore: assume strings passed to KUrl constructors are percentage-encoded
for compat, test case for it is KUrlMimeTest::testURLList()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 18:14:39 +03:00
Ivailo Monev
30cd526513 kdecore: set the scheme to file when it KUrl is constructor from string and it is empty
the test case for it is "local file 3" case of KUrl::cleanPath() test and
the KUrlNavigator test

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 17:53:20 +03:00
Ivailo Monev
ed4ae48705 kdecore: KUrl test-anew
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 14:44:33 +03:00
Ivailo Monev
9f05a33ee6 generic: build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 14:08:10 +03:00
Ivailo Monev
34b75e4f7f kdecore: different take on KUrl::upUrl()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 13:08:49 +03:00
Ivailo Monev
e2a0be91ae kdecore: KTemporaryFile::filePath() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 13:00:14 +03:00
Ivailo Monev
fab969cf3e kdecore: remove most of the KUrl compat methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 12:26:07 +03:00
Ivailo Monev
10eb45205c kdecore: move static KUrl functions to the top
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 11:47:07 +03:00
Ivailo Monev
1e99d802a7 kdecore: KUrl::List to QList<QUrl> conversion optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 11:46:34 +03:00
Ivailo Monev
3cdc7da129 kdecore: simplify KUrl by using QDir::cleanPath() and QUrl::resolved()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 11:30:35 +03:00
Ivailo Monev
c44c545b1a kdecore: add FIXME for KUrl::isRelativeUrl()
I do not know where the logic behind that was

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 08:15:33 +03:00
Ivailo Monev
9e301c4a49 kdecore: disable KUrl test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 04:09:56 +03:00
Ivailo Monev
639d8def3b generic: adjust to QUrl changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 15:23:29 +03:00
Ivailo Monev
a424284337 kdecore: remove unused and redundant KUrl methods
plus some disabled bits

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 13:42:25 +03:00
Ivailo Monev
8bce018375 kdecore: add debug area for ksnapshot
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 01:36:03 +03:00
Ivailo Monev
e123736f1a kdecore: add debug area for ark
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-20 10:00:33 +03:00
Ivailo Monev
3aaef7077e kdecore: add debug area for gwenview
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-20 04:00:18 +03:00
Ivailo Monev
9e021af628 kdecore: initialize KMacroMapExpander and KWordMacroExpander variables
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 07:38:52 +03:00
Ivailo Monev
d2b312f5a1 kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 07:20:37 +03:00
Ivailo Monev
4a47d9f369 kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 07:14:51 +03:00
Ivailo Monev
059c365fee kdecore: replace component with class headers inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 07:02:09 +03:00
Ivailo Monev
687fcc041c kdecore: use foreach() for iterations in KUser and KUserGroup
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 06:55:43 +03:00
Ivailo Monev
825de1bb05 kdecore: use getpwnam_r(), getpwuid_r(), getgrnam_r() and getgrgid_r() in KUser and KUserGroup for thread-safety
TODO from:
704ef230d5

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 06:49:31 +03:00
Ivailo Monev
e5f56675d2 generic: call QCoreApplication::applicationName() as static method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 01:19:01 +03:00
Ivailo Monev
8ea7f6080b kdecore: remove redundant Q_WS_X11 and Q_WS_QWS checks
Q_WS_X11 is essentially always set by KatieConfig.cmake

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-18 06:20:07 +03:00
Ivailo Monev
53c8804c1a kdecore: remove unused build variables
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-18 06:18:08 +03:00
Ivailo Monev
dc208c52fd generic: update references to shared data directory
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-18 00:20:22 +03:00
Ivailo Monev
ed79c859b2 generic: merge KDELibs4ToolsTargets and KDELibs4LibraryTargets
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-17 23:57:38 +03:00
Ivailo Monev
5613e5483c generic: remove redundant build varibles
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-17 20:25:52 +03:00
Ivailo Monev
36c910c653 generic: move stuff from KDE4Internal module to KDELibs4Config
large-scale changes to the build system, nothing a user sees tho - it is
all under the hood

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-17 19:01:40 +03:00
Ivailo Monev
f965a1edb8 kdecore: testing build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-16 20:31:44 +03:00
Ivailo Monev
7e60364ce0 kdecore: initialize variables in KProcess::startDetached() methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-15 07:26:18 +03:00
Ivailo Monev
afa983f02f kdecore: remove unused buffer in KLockFilePrivate::tryLock()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-15 07:25:41 +03:00
Ivailo Monev
add0b2cad3 kdecore: drop KProcess channel forward feature
was used only by klipper, also a program writing something ment for
stderr to stdout (and vice versa) is doing something wrong already

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 23:44:38 +03:00
Ivailo Monev
2f6dae867e kdecore: mark the bottom of KProcess::setOutputChannelMode() as unreachable
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 23:27:53 +03:00
Ivailo Monev
fdd0df9586 kdecore: remove unused header inclusion in kprocess source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 23:26:43 +03:00
Ivailo Monev
e1a01725c2 kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-14 23:26:00 +03:00