Commit graph

4079 commits

Author SHA1 Message Date
Ivailo Monev
728dc0838e kdecore: remove unused headers inclusions in kurl source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 23:20:20 +03:00
Ivailo Monev
13fdc7b7cd kdecore: do not prettify the URL in KUrl::pathOrUrl()
here is how to make browsers barf - check the tooltip and where the browser
thinks the URL points to:
https://ibb.co/cyhwppK

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 23:13:38 +03:00
Ivailo Monev
ef02376c35 kdecore: add KUrl query and fragment test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 21:25:20 +03:00
Ivailo Monev
67d6fa8588 generic: adjust expected tests data
QUrl::StripTrailingSlash removes all trailing slashes and KUrl does not
convert to percentage encoding - local file URLs remain the same when
passed around.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 20:57:21 +03:00
Ivailo Monev
0a5fadde75 kdecore: do not change the scheme from KUrl::cleanPath()
the fact that many KUrl methods change it (by calling KUrl::setPath()) is
just bonkers but that's how it was implemented - to convert to file scheme
from setters

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 20:44:03 +03:00
Ivailo Monev
78c109df85 kdecore: more compatible KUrl
abusing the QUrl path for local files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 20:10:09 +03:00
Ivailo Monev
8f348b4c5b kdecore: remove FIXME for KUrl
so far so good:
https://ibb.co/TYN4z3x

now on to the quircks..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 03:00:21 +03:00
Ivailo Monev
ea02aa2c1a kdecore: fix regression since 7b8ff71eba
oops

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-24 00:53:35 +03:00
Ivailo Monev
341e16d4c6 kdecore: update comment in KUrl::prettyUrl()
konqueror is no more

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 23:58:08 +03:00
Ivailo Monev
5e4732f809 kdecore: KUrl::List from QList<QUrl> optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 23:55:19 +03:00
Ivailo Monev
c81c3bd71d kdecore use the new QUrl::AddTrailingSlash enum
requires the following commit from Katie repo:
3369835da10412451d082713433321a72f25e0df

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 23:08:09 +03:00
Ivailo Monev
7b8ff71eba kdecore: KUrl rewrite to output encoded strings
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 22:33:18 +03:00
Ivailo Monev
b4861f86d5 kdecore: rename variable in uriListData()
bad variable naming - clashes with the function name and inconsistent

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 18:22:41 +03:00
Ivailo Monev
840f3a3b68 kdecore: assume strings passed to KUrl constructors are percentage-encoded
for compat, test case for it is KUrlMimeTest::testURLList()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 18:14:39 +03:00
Ivailo Monev
30cd526513 kdecore: set the scheme to file when it KUrl is constructor from string and it is empty
the test case for it is "local file 3" case of KUrl::cleanPath() test and
the KUrlNavigator test

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 17:53:20 +03:00
Ivailo Monev
ed4ae48705 kdecore: KUrl test-anew
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 14:44:33 +03:00
Ivailo Monev
9f05a33ee6 generic: build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 14:08:10 +03:00
Ivailo Monev
34b75e4f7f kdecore: different take on KUrl::upUrl()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 13:08:49 +03:00
Ivailo Monev
e2a0be91ae kdecore: KTemporaryFile::filePath() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 13:00:14 +03:00
Ivailo Monev
fab969cf3e kdecore: remove most of the KUrl compat methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 12:26:07 +03:00
Ivailo Monev
dcd20243ff kio: compiler warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 12:19:00 +03:00
Ivailo Monev
10eb45205c kdecore: move static KUrl functions to the top
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 11:47:07 +03:00
Ivailo Monev
1e99d802a7 kdecore: KUrl::List to QList<QUrl> conversion optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 11:46:34 +03:00
Ivailo Monev
3cdc7da129 kdecore: simplify KUrl by using QDir::cleanPath() and QUrl::resolved()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 11:30:35 +03:00
Ivailo Monev
c44c545b1a kdecore: add FIXME for KUrl::isRelativeUrl()
I do not know where the logic behind that was

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 08:15:33 +03:00
Ivailo Monev
0064e68e0d kio: convert KUrlCompletionTest to proper test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 07:26:31 +03:00
Ivailo Monev
39a5945581 generic: include KDE4Defaults before creating kde4_exec.sh script
so that CMAKE_LIBRARY_OUTPUT_DIRECTORY and CMAKE_RUNTIME_OUTPUT_DIRECTORY
are set

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 06:57:48 +03:00
Ivailo Monev
9e301c4a49 kdecore: disable KUrl test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-23 04:09:56 +03:00
Ivailo Monev
f780773a9e kutils: set the OK button text and icon of KEMailDialog to match what it does
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 16:40:50 +03:00
Ivailo Monev
0db3a7291f kfile: adjust query check in KFileWidget::getStartUrl()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 15:32:21 +03:00
Ivailo Monev
639d8def3b generic: adjust to QUrl changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 15:23:29 +03:00
Ivailo Monev
a424284337 kdecore: remove unused and redundant KUrl methods
plus some disabled bits

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 13:42:25 +03:00
Ivailo Monev
54e2bcbfb3 kio: do not set KDE_FORK_SLAVES environment variable
non-operational, KIO slaves are forked processes (for now)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 03:29:41 +03:00
Ivailo Monev
ccd463e634 kio: adjust to desktop KIO slave removal
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 03:13:24 +03:00
Ivailo Monev
c40fd044cd kio: remove unused X-KDE-Init-Library property definition
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 02:55:57 +03:00
Ivailo Monev
f54740e469 kio: remove now unused ForwardingSlaveBase class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-22 02:11:31 +03:00
Ivailo Monev
cf6ac06d91 kioslave: return on put() error instead of exiting the slave
if the slave is not a forked process that would exit the program executing
the put job

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 21:54:38 +03:00
Ivailo Monev
aee73d3abb kioslave: fix removal of .part files on file put
_dest is never set to something

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 21:46:20 +03:00
Ivailo Monev
ba1d5268ee kioslave: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 21:24:38 +03:00
Ivailo Monev
387022831a kioslave: remove redundant FileProtocol::createUDSEntry() argument
true is always passed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 21:12:55 +03:00
Ivailo Monev
9fe6a221cc kio: include config-acl header in file_unix source file
for the HAVE_POSIX_ACL definition

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 20:50:59 +03:00
Ivailo Monev
2db8c10c1c kio: minor KACLListViewItem::calcEffectiveRights() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 20:39:18 +03:00
Ivailo Monev
9c4bc997c4 kioslave: replace FileProtocol::isExtendedACL() method with its body
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 20:27:19 +03:00
Ivailo Monev
c2ba59db1e kioslave: remove unused QProcess header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 20:06:31 +03:00
Ivailo Monev
bb8ac83d00 kioslave: mark FileProtocol reimplementations as final
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 20:05:23 +03:00
Ivailo Monev
25bc102ae0 kpty: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 02:39:54 +03:00
Ivailo Monev
8bce018375 kdecore: add debug area for ksnapshot
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-21 01:36:03 +03:00
Ivailo Monev
b3ed6f356a kio: new KHTTP::address() method
to be used by kdirshare

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-20 21:00:15 +03:00
Ivailo Monev
e123736f1a kdecore: add debug area for ark
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-20 10:00:33 +03:00
Ivailo Monev
fc61802622 kpty: assume openpty() is available
available on all supported platforms, including musl libc:
https://git.musl-libc.org/cgit/musl/tree/include/pty.h

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-20 05:41:24 +03:00