Commit graph

5112 commits

Author SHA1 Message Date
Ivailo Monev
713c9394d7 kdecore: drop message box feature of KDebug
tho it can be fixed (by not using queued up message boxes) I am not into
supporting such feature

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 19:40:13 +03:00
Ivailo Monev
093ad1d84d kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 19:17:23 +03:00
Ivailo Monev
9d2994fad0 kdecore: start as many threads as possible from the queue of KThreadPool
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 17:32:44 +03:00
Ivailo Monev
f53d175e6b kio: handle non-local URLs in KRecentDocument and reject URLs with empty filename
this is mostly for KIO jobs that, for example, get remote URLs

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 16:28:28 +03:00
Ivailo Monev
3be77d2b5f kio: remove unused header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 16:00:49 +03:00
Ivailo Monev
4b7f20f57b kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 16:00:36 +03:00
Ivailo Monev
302a470d3b kded: drop unused window registration feature
no point in passing around windows to kded4 or its modules, job UI delegate
windows are different thing tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 15:45:36 +03:00
Ivailo Monev
fc408ce6b3 kdecore: drop command formatting
used only in one place in rich message

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 04:19:39 +03:00
Ivailo Monev
714d831b1f kdecore: drop message formatting
used only in one place in rich message

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 04:10:39 +03:00
Ivailo Monev
fce4c2d3c7 kdecore: drop email formatting
now unused

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 04:07:51 +03:00
Ivailo Monev
a31c876d6c kdecore: drop resource formatting
only one use of it, in the case it was used for what the message is trying
to tell is the least concern (the system would be missing basic MIME data)
which means someone messed up at some level (shared-mime-info is required)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 03:56:04 +03:00
Ivailo Monev
c47f1633d8 kdeui: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 00:01:06 +03:00
Ivailo Monev
e75bf1747a kdecore: const-ify KThreadPool::setMaxThreadCount() argument
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-19 22:59:09 +03:00
Ivailo Monev
941a85507b kdecore: reject invalid threads count from KThreadPool::setMaxThreadCount()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-19 22:57:35 +03:00
Ivailo Monev
174f6a30e0 plasma: assume QPixmap paint engines support composition
the backbone of QPixmap is QImage

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-19 20:31:07 +03:00
Ivailo Monev
2ad07c5a86 plasma: remove redundant widget properties
once used in qml bindings and such, now redundant

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-19 20:24:03 +03:00
Ivailo Monev
8765730377 plasma: plug memory leak
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-19 20:05:17 +03:00
Ivailo Monev
489bb13a8b plasma: bring back Plasma::RunnerManager::reloadConfiguration() method
does totally different thing tho - the old method was reloading the
configuration of Plasma::RunnerManager while this one reloads the
configuration of the loaded runners. it is a convenience method still that
should not be used as runners are matching for obvious reasons

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-19 07:28:38 +03:00
Ivailo Monev
d4ab9eae6c kio: KRecentDocument optimization
the bug report was related to the resources system that Katie does not
support

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-19 04:35:28 +03:00
Ivailo Monev
4600904f5b kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-19 04:34:16 +03:00
Ivailo Monev
d3ca6d35c5 plasma: do not load runners when the allowed runners change
unless there are runners loaded that may have to be unloaded for example,
that way the initial loading of runners will be delayed until the first
query

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-19 02:51:16 +03:00
Ivailo Monev
8c2136445e plasma: remove unused Plasma::RunnerContext::Type enum
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:35:46 +03:00
Ivailo Monev
df9bffd10c plasma: reset runners context before waiting
so that runners know that it is time for them to stop because the context
is no longer valid

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:28:17 +03:00
Ivailo Monev
bd3425b187 plasma: Plasma::RunnerManager documentation update
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:23:23 +03:00
Ivailo Monev
8791f0571b plasma: do not emit Plasma::RunnerContext::matchesChanged() from Plasma::RunnerContext::reset()
any preperation for matching anew should be done prior to starting a query

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:14:48 +03:00
Ivailo Monev
6514cb22a6 plasma: remove unused private member
performance gain for the runners, there should be no duplicates and even
if there was the only thing that was done about it is to print a debug
message when build for debugging

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:06:26 +03:00
Ivailo Monev
595991ff55 plasma: simplify runners setup and correct signals emission
Plasma::RunnerManager::matchesChanged() is now emitted when new matches
arive, Plasma::RunnerManager::queryFinished() when matching is done (all
match jobs finished)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 18:18:42 +03:00
Ivailo Monev
f452997709 plasma: remove unused and redundant Plasma::RunnerContext methods
nothing but the manager is supposed to remove matches and there is a
Plasma::RunnerContext::reset() method

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 17:32:27 +03:00
Ivailo Monev
ac5d407fd5 plasma: remove unused Plasma::RunnerContext methods arguments
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 17:09:11 +03:00
Ivailo Monev
97cfe669fc plasma: do not magically adjust the speed of runners
I've optimized the runners enough to not need such bits

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 07:53:05 +03:00
Ivailo Monev
afb548b2ed plasma: unlock Plasma::QueryMatch
assuming that match (Plasma::QueryMatch) objects are modified by one thread
in the runner itself only or operated on a copy of one matching does not
need a mutex

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 07:43:34 +03:00
Ivailo Monev
5f23665baa kdecore: use regular integer for the active threads counter in KThreadPool
with KThreadPool being mutex-locked it should not be subject to
race-condition

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 07:06:00 +03:00
Ivailo Monev
632dd982df plasma: remove redundant KThreadPool::setMaxThreadCount() call
KThreadPool uses the same value by default

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 06:40:49 +03:00
Ivailo Monev
ecd57181ea kdecore: delete the threads from KThreadPool
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 06:37:12 +03:00
Ivailo Monev
a871678ec4 plasma: rework runners classes to not pass around the context
unused in most cases, shared data and dangerous to pass around

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 05:15:02 +03:00
Ivailo Monev
2f485d5376 generic: replace QThreadPool and QRunnable with custom class
on a side note it does not solve any thread-safety issues, such are out
of the scope of the class

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 03:05:03 +03:00
Ivailo Monev
747c37269b plasma: remove unused Plasma::RunnerContext MIME type info
runners can determine it anyway, generic type detection is done already

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 01:02:11 +03:00
Ivailo Monev
b2a66f5a72 plasma: const-ify Plasma::RunnerContext arguments
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 00:16:31 +03:00
Ivailo Monev
7683b1d29e plasma: drop redundant Plasma::QueryMatch type feature
it could be used to sort ala relevance but what would the relevance feature
would be for then?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 00:06:05 +03:00
Ivailo Monev
c4c494d705 plasma: do not copy the query match in Plasma::RunnerContext::addMatch()
its relevance remains unchanged

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 23:01:28 +03:00
Ivailo Monev
e7fcb90738 plasma: actually use the priority
the runners priority property was not used for anything, it is now

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 21:35:38 +03:00
Ivailo Monev
4152c2b044 plasma: de-virtualize Plasma::Animation::setDuration() and make it public
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 21:10:35 +03:00
Ivailo Monev
54d5ec4782 plasma: initialize all members of private class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 20:05:47 +03:00
Ivailo Monev
22e93f449e plasma: properly initialize internal class members
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 19:57:40 +03:00
Ivailo Monev
935b228484 plasma: simplify animations classes
the proxy class Plasma::EasingAnimation is simply redundant, just one
more virtual function call which slows the animations

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 19:44:26 +03:00
Ivailo Monev
eb37060455 kdecore: remove unused KMimeGlobsFileParser member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 16:04:21 +03:00
Ivailo Monev
49fea6b1c2 kdecore: globs parsing optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 05:16:30 +03:00
Ivailo Monev
e6fdfa4d8b kdecore: remove bogus KMimeType constructor argument
the comment is set when the xml file is parsed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 05:11:11 +03:00
Ivailo Monev
b9c83af23a kdecore: drop support for the deprecated globs file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 05:03:19 +03:00
Ivailo Monev
3bbaffe82c kdecore: adjust tests to recent changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 04:53:13 +03:00