the test is for the worse case scenario, i.e. what if /etc/passwd is
missing? in that case the system is borked and should be fixed, that's
not a problem Katana will (or should) solve nor workaround tho
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
such items should not be in the queue for preview even, even items for
remote URLs have something vendor-specific or application/octet-stream as
MIME type. fixes KMimeTypeTrader runtime warning
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
marking as extension because it was not implemented before and the FDO
spec is dead (i.e. not a spec anymore), may or may not work with other
power managers implementing the interface (org.freedesktop.PowerManagement)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
it is very tricky to do it correctly, especially with KMainWindow and the
like doing their thing with menu/status bars
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
some of them were wrapped in i18n() macro with the idea to use some of them
in errorString() getter to report MPV initialization failure for example
but I do not think I will implement that (not that there is error(QString)
signal for reporting MPV failure after its initialization)
the debug messages are also quite spammy (because of time-pos property
changing constantly while playing for example), i.e. don't enable them
unless you have good reason for that because multiple media classes
instances can quickly fill your ~/.xsession-errors with lots of messages
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
there used to be "vo" option doing the same I believe, anyway it should
speed up initializations by not checks for other contexts (it is to be
rendered into X11 window after all)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
this feature is mostly for Dolphin which fits it into a small area and
there really is not enough space for the position slider
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
the soft MIME matching via KMimeType::is() is way too.. soft. it can match
application/x-dvi as plain/text (and use ps thumbnailer) which is not ideal
(should use only textthumbnail thumbnailer for plain/text and ps
thumbnailer for application/x-dvi)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
so that the uic tool does not generate code that uses variables with
the name of the private KMediaWidget class (KMediaWidgetPrivate)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
who tought using the same shortcut for multiple actions is going to work?
the single character shortcuts are very likely to conflict with other
shortcuts aswell
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
the reason for checking the preffered offers first should be obvious - it
is questionable which match should be done first. should it be the glob or
the exact match? chicken and egg thing
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
mostly to make the MIME types check consistent by using KMimeType::is()
for the comparison (as done by KPreviewPropsPlugin::supports() for example)
and to filter the ThumbCreator service type (to avoid invalid KMimeType
checks)
fixed KFileMetaInfo regression for plugins that use globs aswell
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
none of the plugins support it and it slows down the thumbnail
preview generation (or fetching of existing thumbnail)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
previously autoloaded modules would be loaded in arbitrary order regardless
of what phase they are ment for from Kded::initModules() but phase two
should be done by ksmserver
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
if it is false then modules that are not ment for full session are not
automatically loaded on init so it shall serve as a hint when debugging
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
