despite the gettimeofday() check for an example, the function is used
unconditionally thus checks for errno header are removed aswell rather then
making them required from configuration checks and error-ing out if not
found.
other cases such as trunc() are used in kexiv2 unconditionally, not in
kdecore.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
since QProcess::execute() is static it is possible to call it with object
but it does not do what one expects (failure in API design). it creates a
new process but any other methods calls have no effect on that.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
it was causing overlinkg due to incorrect dependency additions added by the
module because resolv library is used privately. in fact, it uses zlib and
udev too but only privately and none of their include directories are
needed to use libpci.
since the rewrite makes use of pkg-config as primary lookup method any
future changes to that behaviour will be handled correctly without
overlinking.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
since pkg-config method is used as primary this change should fix forward
compatibility issues related to it being versioned in unusual way. while
at it, added 1.7 to list of names
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
no custom C/C++ flags are set globally during build, the exceptions is
KDE4_ENABLE_EXCEPTIONS which build systems use where needed only
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
since find_package_handle_standard_args() is used and no status messages
are printed by the modules there is no reason to set <MODULE>_FIND_QUIETLY
variable (which should be prefixed with the actual module name, not upper
case)
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
this ensures package will be considered as not found in case the
dependencies of the package are found but not the actual package that the
module is looking for
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
neither the Plasma runner nor the applet actually used the QALCULATE_CFLAGS
variable meaning that if Qalculate was installed in non-standard prefix
the build was likely to fail, this fixes that problem by replacing it with
QALCULATE_INCLUDE_DIR which will be used in the build system for the applet
and runner.
also fixes a CMake deprecation warning about using obsolete UsePkgConfig
module.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
netsupp was provided for KDE3 compatibility and the header is not even
installed. the only place where getnameinfo() is used is in KIO kpac DHCP helper
but it does not include the netsupp header.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
logging found and otherwise packages will no longer be done thus
macro_display_feature_log() is removed. the reason for not doing is because
it simply does not cover all package lookups, only those logged via
macro_log_feature(). if I was to fix that, I would probably resort to
CMakeCache.txt parsing trickery since it includes indirect package lookups
aswell as header, struct, member, etc. checks however that would be
fragile and require common pattern in the checks
macro_log_feature() incorrectly quoted DESCRIPTION and PURPOSE in the
CMake output but that is fixed now. it will be replaced with actual
set_package_properties() macro calls in the future.
in any case, it is addition disk I/O so the configuration/build time will
be reduced with this change.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
for possible version checks in build systems which expect the variable
prefix to match that of the other variables
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
using pkg-config search as primary method with fallback to path lookup,
this may result in overlinking however if libraries require additional
include paths (as is the case with PulseAudio) with this change that will
not be a problem.
it will also reduce the lookups done during configuration/build since path
lookups will not be done, unless pkg-config lookup does not set the
required variables.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
TODO from https://github.com/fluxer/katana/issues/7. I've decided to
keep KDE4 and Katie libraries as PUBLIC, all other libraries as PRIVATE
for that and not use INTERFACE at all since that will not require a lot
of changes to all other sub-projects (kde-baseapps, kde-workspace and
kde-extraapps) build systems.
MusicBrainz5 CMake module was also rewritten as the actual library that
should be linked to is libmusicbrainz5cc, libmusicbrainz5 is the C
version of it.
common checks for X11 extensions where move to main config header,
eventually to be moved to separate config-x11 header.
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
