Commit graph

1170 commits

Author SHA1 Message Date
Ivailo Monev
4d6fb007e7 generic: fix most of the overlinking issues
TODO from https://github.com/fluxer/katana/issues/7. I've decided to
keep KDE4 and Katie libraries as PUBLIC, all other libraries as PRIVATE
for that and not use INTERFACE at all since that will not require a lot
of changes to all other sub-projects (kde-baseapps, kde-workspace and
kde-extraapps) build systems.

MusicBrainz5 CMake module was also rewritten as the actual library that
should be linked to is libmusicbrainz5cc, libmusicbrainz5 is the C
version of it.

common checks for X11 extensions where move to main config header,
eventually to be moved to separate config-x11 header.

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-09 21:58:11 +00:00
Ivailo Monev
9dcca4fe37 kdecore: update bundled gettext header
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-09 02:27:50 +00:00
Ivailo Monev
478ca250a2 generic: replace installation paths with KDE4_ prefixed
this is TODO from issue #9. CPack and CTest configs will not be
supported. most of the changes done to other repisitories is automated
via:

find -type f -exec sed -i -e 's|${INSTALL_DIR}|${KDE4_INSTALL_DIR}|g' \
    -e 's|${EXEC_INSTALL_PREFIX}|${KDE4_EXEC_INSTALL_PREFIX}|g' \
    -e 's|${SHARE_INSTALL_PREFIX}|${KDE4_SHARE_INSTALL_PREFIX}|g' \
    -e 's|${BIN_INSTALL_DIR}|${KDE4_BIN_INSTALL_DIR}|g' \
    -e 's|${SBIN_INSTALL_DIR}|${KDE4_SBIN_INSTALL_DIR}|g' \
    -e 's|${LIB_INSTALL_DIR}|${KDE4_LIB_INSTALL_DIR}|g' \
    -e 's|${LIBEXEC_INSTALL_DIR}|${KDE4_LIBEXEC_INSTALL_DIR}|g' \
    -e 's|${INCLUDE_INSTALL_DIR}|${KDE4_INCLUDE_INSTALL_DIR}|g' \
    -e 's|${PLUGIN_INSTALL_DIR}|${KDE4_PLUGIN_INSTALL_DIR}|g' \
    -e 's|${IMPORTS_INSTALL_DIR}|${KDE4_IMPORTS_INSTALL_DIR}|g' \
    -e 's|${CONFIG_INSTALL_DIR}|${KDE4_CONFIG_INSTALL_DIR}|g' \
    -e 's|${DATA_INSTALL_DIR}|${KDE4_DATA_INSTALL_DIR}|g' \
    -e 's|${ICON_INSTALL_DIR}|${KDE4_ICON_INSTALL_DIR}|g' \
    -e 's|${KCFG_INSTALL_DIR}|${KDE4_KCFG_INSTALL_DIR}|g' \
    -e 's|${LOCALE_INSTALL_DIR}|${KDE4_LOCALE_INSTALL_DIR}|g' \
    -e 's|${MIME_INSTALL_DIR}|${KDE4_MIME_INSTALL_DIR}|g' \
    -e 's|${SERVICES_INSTALL_DIR}|${KDE4_SERVICES_INSTALL_DIR}|g' \
    -e 's|${SERVICETYPES_INSTALL_DIR}|${KDE4_SERVICETYPES_INSTALL_DIR}|g' \
    -e 's|${SOUND_INSTALL_DIR}|${KDE4_SOUND_INSTALL_DIR}|g' \
    -e 's|${TEMPLATES_INSTALL_DIR}|${KDE4_TEMPLATES_INSTALL_DIR}|g' \
    -e 's|${WALLPAPER_INSTALL_DIR}|${KDE4_WALLPAPER_INSTALL_DIR}|g' \
    -e 's|${AUTOSTART_INSTALL_DIR}|${KDE4_AUTOSTART_INSTALL_DIR}|g' \
    -e 's|${XDG_APPS_INSTALL_DIR}|${KDE4_XDG_APPS_INSTALL_DIR}|g' \
    -e 's|${XDG_DIRECTORY_INSTALL_DIR}|${KDE4_XDG_DIRECTORY_INSTALL_DIR}|g' \
    -e 's|${XDG_MIME_INSTALL_DIR}|${KDE4_XDG_MIME_INSTALL_DIR}|g' \
    -e 's|${SYSCONF_INSTALL_DIR}|${KDE4_SYSCONF_INSTALL_DIR}|g' \
    -e 's|${MAN_INSTALL_DIR}|${KDE4_MAN_INSTALL_DIR}|g' \
    -e 's|${INFO_INSTALL_DIR}|${KDE4_INFO_INSTALL_DIR}|g' \
    -e 's|${DBUS_INTERFACES_INSTALL_DIR}|${KDE4_DBUS_INTERFACES_INSTALL_DIR}|g' \
    -e 's|${DBUS_SERVICES_INSTALL_DIR}|${KDE4_DBUS_SERVICES_INSTALL_DIR}|g' \
    -e 's|${DBUS_SYSTEM_SERVICES_INSTALL_DIR}|${KDE4_DBUS_SYSTEM_SERVICES_INSTALL_DIR}|g' \
    -e 's|${KAUTH_HELPER_PLUGIN_DIR}|${KDE4_KAUTH_HELPER_PLUGIN_DIR}|g' \
    -e 's|${KAUTH_BACKEND_PLUGIN_DIR}|${KDE4_KAUTH_BACKEND_PLUGIN_DIR}|g' {} +

note that if you execute this command you may corrupt the git repository
files so move the .git directory out of the way. you can also verify
that there are no other reference to the compatibility installation
paths via:

git grep \
    -e INSTALL_DIR \
    -e EXEC_INSTALL_PREFIX \
    -e SHARE_INSTALL_PREFIX \
    -e BIN_INSTALL_DIR \
    -e SBIN_INSTALL_DIR \
    -e LIB_INSTALL_DIR \
    -e LIBEXEC_INSTALL_DIR \
    -e INCLUDE_INSTALL_DIR \
    -e PLUGIN_INSTALL_DIR \
    -e IMPORTS_INSTALL_DIR \
    -e CONFIG_INSTALL_DIR \
    -e DATA_INSTALL_DIR \
    -e ICON_INSTALL_DIR \
    -e KCFG_INSTALL_DIR \
    -e LOCALE_INSTALL_DIR \
    -e MIME_INSTALL_DIR \
    -e SERVICES_INSTALL_DIR \
    -e SERVICETYPES_INSTALL_DIR \
    -e SOUND_INSTALL_DIR \
    -e TEMPLATES_INSTALL_DIR \
    -e WALLPAPER_INSTALL_DIR \
    -e AUTOSTART_INSTALL_DIR \
    -e XDG_APPS_INSTALL_DIR \
    -e XDG_DIRECTORY_INSTALL_DIR \
    -e XDG_MIME_INSTALL_DIR \
    -e SYSCONF_INSTALL_DIR \
    -e MAN_INSTALL_DIR \
    -e INFO_INSTALL_DIR \
    -e DBUS_INTERFACES_INSTALL_DIR \
    -e DBUS_SERVICES_INSTALL_DIR \
    -e DBUS_SYSTEM_SERVICES_INSTALL_DIR \
    -e KAUTH_HELPER_PLUGIN_DIR \
    -e KAUTH_BACKEND_PLUGIN_DIR | grep -v KDE4_

this change should make default installation Filesystem Hierarchy
Standard (FHS) compliant and packaging easier since library suffix (e.g.
64 for x86_64 hosts) will not have to be specified explicitly, it may
solve possible conflicts with installation path variables from other
projects which use custom installation paths aswell

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-08 20:46:43 +00:00
Ivailo Monev
80959a284b cmake: rewrite Alsa module
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-08 18:05:50 +00:00
Ivailo Monev
2c5c39f81b generic: remove unused KDE4_KPTY_BUILT_WITH_UTEMPTER from KDE4Config CMake file
Kate no longer used kwrited to write files

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-08 17:15:18 +00:00
Ivailo Monev
d5184d50b1 cmake: rewrite GMP, MPFR, MPV and Sqlite modules
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-08 17:13:19 +00:00
Ivailo Monev
6199ce1520 cmake: remove unused DBus and MySQL modules
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-08 15:38:24 +00:00
Ivailo Monev
a83285f6b5 cmake: remove unused modules
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-08 05:15:41 +02:00
Ivailo Monev
8d3ea2c1bc generic: purge Qt support with fire
this includes QtWebKit support removal since it is not going to be
maintained, fancy headers removal, CMake modules rewrite/removal
and removing conditionals from the build system. Pre-processor
definitions checks are still in place on purpose

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-07 13:00:55 +00:00
Ivailo Monev
1e73152682 solid: ignore bind/unbind udev actions
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-06 22:59:22 +00:00
Ivailo Monev
ee349923a3 generic: bump version to 4.19.0
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-06 17:42:19 +00:00
Ivailo Monev
bfd1b6edd4 cmake: fix detection of recent NetworkManager versions detection
libnm-util and libnm-glib have been merged into libnm since NetworkManager v1.0

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-05 17:26:43 +00:00
Ivailo Monev
7491c27479 cmake: remove unused MusicBrainz CMake module
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-05 15:41:46 +00:00
Ivailo Monev
82bc2feec0 cmake: indent and improve GSSAPI CMake module
on Debian krb5-config is .mit suffixed, also since recent KRB5 versions
cflags prefix include directories with -isystem instead of -I

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-05 15:32:31 +00:00
Ivailo Monev
cd8cf2c017 cmake: remove redundant Poppler module
duplicate, same as PopplerQt4

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-04 23:38:43 +00:00
Ivailo Monev
1fc11ee202 kdeui: indent KApplication::saveState()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-04 18:37:22 +00:00
Ivailo Monev
27e27502cc kio: partially revert 2382284cb2
some services expect server to be up, such as favicon KDED service, this
fixes hang when those services are requested

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-03 19:13:19 +00:00
Ivailo Monev
15c1305965 kdecore: remove redundant util check and kmemtest
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-03 18:54:37 +00:00
Ivailo Monev
4eff237966 kioslave: remove unused and private KCookieServer::newInstance()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-03 01:43:58 +00:00
Ivailo Monev
3bb24edfd3 plasma: correct directory existence check in PlasmoidPackageTest::createAndInstallPackage()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-03 01:33:28 +00:00
Ivailo Monev
1d85d63589 kio: replace QFile::exists() with QDir::exists() and QFileInfo::exists() where applicable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-03 01:05:44 +00:00
Ivailo Monev
38c049bb36 kdecore: use QDir::exists() to check for directory existence from tests
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 22:38:07 +00:00
Ivailo Monev
246fa5b377 kdecore: remove kde4- prefix from services lookup in KServiceTest
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 18:31:03 +00:00
Ivailo Monev
3ae8b33409 generic: regenerate parsers
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 17:22:10 +00:00
Ivailo Monev
7b84f8d11b kcddb: update expected data of AsyncCDDBLookupTest::testLookup() test case
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 15:58:36 +00:00
Ivailo Monev
aa453fc0d2 kdeui: remove unused flags in QTEST_KDEMAIN_WITH_COMPONENTNAME_KAPP() macro
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 14:44:51 +00:00
Ivailo Monev
a443414554 kdecore: fix regression since 9310423cca
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 14:43:45 +00:00
Ivailo Monev
2382284cb2 kio: establish server for address only if host is empty
fixes HeaderObjectTest test which uses tcp protocol without address

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 13:55:57 +00:00
Ivailo Monev
d1623a08e0 kio: adjust expected data of KDirModelTest::testDeleteDirectory() test case
the signal is emited 3 times, one for each directory from the URL, because
KDirWatch is recursive now

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 12:57:31 +00:00
Ivailo Monev
c82efdb5d9 kdecore: adjust expected data of KLocaleTest::languages() test case
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 02:26:52 +00:00
Ivailo Monev
229e736f74 generic: adjust to KStandardDirs changes
the lookup, even with wildcard, is no longer recursive

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 02:22:48 +00:00
Ivailo Monev
0da430a5b7 kcddb: update expected data of AsyncCDDBLookupTest::testLookup() test case
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 01:53:02 +00:00
Ivailo Monev
597a84c0ef kdecore: rework KCharsetsTest test
the static initializer was removed since Katie does not require it

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 01:48:40 +00:00
Ivailo Monev
459f9d1b7a kdecore: fix process output capturing in KDebugTest::testNoMainComponentData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 01:25:17 +00:00
Ivailo Monev
ce1a80fac2 kio: initialize SocketConnectionBackend::tcpServer member to 0
fixes assert in SocketConnectionBackend::listenForRemote()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 00:12:32 +00:00
Ivailo Monev
48b41aadb9 kfile: fix race condition in KDirOperatorTest::testBug187066() test
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-01 23:10:36 +00:00
Ivailo Monev
63cf8d43d5 generic: fix bootstrap build with testing enabled
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-01 22:53:13 +00:00
Ivailo Monev
7d469fdd5b kio: include required stat header in kioslavetest source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-01 21:14:31 +00:00
Ivailo Monev
dfb95e9e13 kio: do not create widgets for empty metadata values
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-30 13:52:47 +00:00
Ivailo Monev
4357dbf7a4 kio: plug KFileMetaDataWidget memory leak 2020-01-30 13:51:17 +00:00
Ivailo Monev
9ee607bc7c kio: call slotDataChangeFinished() after metadata has been read
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-30 13:39:07 +00:00
Ivailo Monev
6e0f9c880a kio: fix race condition in KFileMetaDataConfigurationWidget::Private::loadMetaData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-30 12:47:35 +00:00
Ivailo Monev
b49dc4c836 kio: fix Strigi build-time checks
the module for Strigi was removed in 5cf0eafa90
since it provides CMake config file so the check should be for camel-case
not upper-case variable name

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-30 11:54:07 +00:00
Ivailo Monev
49744946c6 kdecore: fix build against Qt4
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-29 13:04:53 +00:00
Ivailo Monev
eb1c4f4e6c cmake: detect Katie specific DBusMenuQt library
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-29 13:04:13 +00:00
Ivailo Monev
c43ceef904 plasma: reuse QFileInfo object in PackageStructure::setPath()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-25 00:59:51 +00:00
Ivailo Monev
6512385459 kutils: fix WId type handling in KMediaPlayer constructor for 64-bit host
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-25 00:59:00 +00:00
Ivailo Monev
dfb620ff0b plasma: fix regression since fff3f3fbf3
the path being file is not invalid case

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-22 14:42:42 +00:00
Ivailo Monev
f8a084be6c kdeui: plug KXmlGuiWindow memory leak
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 15:05:17 +00:00
Ivailo Monev
b24622f35d kdeui: use QDir::exists() to check for icon directory existence
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 04:01:04 +00:00