Commit graph

4535 commits

Author SHA1 Message Date
Ivailo Monev
3fc6433561 generic: make it possible to build from the source directory
after lots of build system changes (including this commit) it is
finally possible

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-14 20:35:59 +03:00
Ivailo Monev
da2cb4b848 plasma: do not check if the current "requires configuration" state matches from Plasma::Applet::setConfigurationRequired()
because the message overlay is used for both (error) messages and to show
configuration button (with optional message) and the overlay may have to
be recreated to override the one previously setup by
Plasma::Applet::showMessage() (e.g. when an applet is created, message is
shown and then a configuration overlay but with the internal "requries
configuration" state not changing)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-14 16:17:47 +03:00
Ivailo Monev
c3a344c4af plasma: check the display outside the loop in Plasma::DialogShadowsPrivate::freeX11Pixmaps()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-14 14:49:53 +03:00
Ivailo Monev
245a161cc8 kdeui: de-duplicate code in KIconEngine::pixmap()
QColor(0,0,0,0) is the same as QColor(Qt::transparent)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-12 23:19:29 +03:00
Ivailo Monev
86f370b395 kdeui: reimplement QIconEngine::iconName() from KIconEngine
this makes KIcon serializable by name (e.g. by KDBusMenuExporter) in
most cases, that however means lookup on the other end (if the icon pixmap
is not serialized it is essentially the same as calling QIcon::fromTheme()
on the other end of the serialization)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-12 23:15:40 +03:00
Ivailo Monev
f197e144ca kdeui: drop support for setting custom pixmap for KRatingPainter
KRatingPainter and KRatingWidget are currently not used but holding a
reference to a pixmap that can already be (and is) obtained from the icon
(constructing QIcon from pixmap is a thing) is just redundant

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-12 14:57:01 +03:00
Ivailo Monev
12b8b0b3ae kdeui: remove unused KAssistantDialog class
use QWizard instead

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-12 13:53:21 +03:00
Ivailo Monev
b3b190e6ae kdeui: raise and activate KMessageBox and queued KDialog windows
this is mostly for status notifier dialogs, if the dialogs are not raised
and activated they will block (because QDialog::exec() is called) and
manual activation has to be done (via alt+tab)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-12 02:02:58 +03:00
Ivailo Monev
37f9ea4dba kdeui: do not swap the order of the image bits in KStatusNotifierItemPrivate::imageToStruct()
does nothing but slow down the image serialization on little endian really,
the image data is not ment to be saved and passed around to other host

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-12 01:34:42 +03:00
Ivailo Monev
cc38aa13b0 kdeui: remove non-operational bits
Katie has the option to set printer properties and options anyway, as
for why the bits are non-operational - it is because of the version
check which is lower than the current Katie version

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 21:10:02 +03:00
Ivailo Monev
c0f69bf109 kdewidgets: remove unused picture
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 20:38:47 +03:00
Ivailo Monev
9945c07d7f kdeui: remove reference to non-existing KPasswordEdit class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 20:37:36 +03:00
Ivailo Monev
6d9beb3591 generic: remove useless AUTHORS files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 20:12:17 +03:00
Ivailo Monev
3b4c47d967 kdecore: remove bogus test code
checking for directory existing via QFile::exists() is bogus, also Katana
does not install files in such directory

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 18:40:38 +03:00
Ivailo Monev
553608ca41 kutils: someone's typo
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 18:25:19 +03:00
Ivailo Monev
3ad6579891 kdecore: findLibraryInternal() function optimization
by checking if the unmodified (by makeLibName()) name is absolute first and
by not checking for relative library (if the name is not absolute path
QFileInfo::path() would return "." resulting in a relative lookup for
the library by KStandardDirs::findResource() in "lib" resource) the most
common cases are only looked for by KPluginLoader (either absolute path,
relative module or library but not relative to the current directory)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 18:02:33 +03:00
Ivailo Monev
fe00f4058f kdecore: remove TODO related to KPluginLoader
the property shall not be removed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 17:27:32 +03:00
Ivailo Monev
59b1d3da2d kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 17:14:38 +03:00
Ivailo Monev
4d01af27ee kdecore: remove unused KPluginFactoryPrivate member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 17:06:17 +03:00
Ivailo Monev
300da74a3f kdeui: drop support for restoring more than one KMainWindow-dervice classes
unused feature

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 12:12:59 +03:00
Ivailo Monev
7dee8c8183 kdecore: remove TODOs for KAboutData enums
unless KAboutLicense is merged into KAboutData that cannot happen because
KAboutData has getters that use the enums

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 11:52:31 +03:00
Ivailo Monev
d41b63de00 kdeui: initialize KUniqueApplication::Private member in the constructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 11:49:05 +03:00
Ivailo Monev
c0379cc431 kdeui: remove unused KGlobalSettings methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 11:46:24 +03:00
Ivailo Monev
c6c05c10b4 kdecore: use KStandardDirs::locate() to check for the existence of catalogs
the catalog file must exist, not just the directory

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-11 09:30:35 +03:00
Ivailo Monev
ca00fba4ed kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-10 21:03:14 +03:00
Ivailo Monev
ab05f3c60d kdecore: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-10 20:47:11 +03:00
Ivailo Monev
d181c8678c kdecore: do not deep-copy the QString objects in KAboutData::translators()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-10 20:10:09 +03:00
Ivailo Monev
d55f6589fb kdecore: remove custom license support leftovers
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-10 20:08:54 +03:00
Ivailo Monev
fa51ecdfaf kdecore: remove unused KAboutData methods and redundant constructor arguments
the homepage and the bugs email address shall always be defined in
kglobalsettings header for official Katana applications, libraries, etc.
the option to override them is still a thing

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-10 17:41:54 +03:00
Ivailo Monev
bd063c8b56 generic: remove dead and irrelevant links references
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-10 14:26:19 +03:00
Ivailo Monev
31553f8958 mimetypes: add KWin window rules MIME type
to be used by kwin rules KCM

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-10 10:28:23 +03:00
Ivailo Monev
9472a51e80 generic: version bump
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-09 23:13:36 +03:00
Ivailo Monev
6a07ac897c kutils: typos
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-09 16:17:27 +03:00
Ivailo Monev
0f0dcc7b33 kio: drop redundant and disabled by default kionetrc/.netrc support
no interface to enable it and with KPasswdStore in place it is simply
redundant (other than the auto-login macros maybe)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-09 15:46:45 +03:00
Ivailo Monev
2880bc1677 kio: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-09 15:35:05 +03:00
Ivailo Monev
b7b609278b plasma: static analyzer warning fix
because the AppletHandle pointer is connected before assigning the handle
member the AppletPrivate::handleDisappeared() slot may be called with null
null handle pointer resulting in a call of member on a null pointer

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-09 15:15:42 +03:00
Ivailo Monev
b596272f8a kutils: static analyzer warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-09 14:50:34 +03:00
Ivailo Monev
be9d8967f7 kdeui: remove redundant KGlobalSettings::desktopGeometry() methods
QDesktopWidget is Xinerama aware and it can be disabled because I
implemented option for that, see the following commit in the Katie repo:
b7e4bae65f0cae7f3029b98980f638c077ecfc22

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-09 03:58:14 +03:00
Ivailo Monev
a2101eec56 kdeui: remove invalid KIconLoader resource directory
considered - nothing installs icons in such directory

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-09 03:08:36 +03:00
Ivailo Monev
5432c47994 kdecore: KMimeTypeRepository::parseMagicFile() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-09 02:18:59 +03:00
Ivailo Monev
b2a4509b14 kdecore: mimeDataBaseVersion() function optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-09 01:52:22 +03:00
Ivailo Monev
5fb7d39eb2 kdecore: disable KLOCALE_DUMP_UNTRANSLATED by default
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-08 23:42:52 +03:00
Ivailo Monev
4e4ab415ca kfile: keep reference to the QByteArray object in KFilePlacesItem::setBookmark()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-08 23:41:53 +03:00
Ivailo Monev
4472e87d19 kdecore: add compile-time definition to dump catalogs when translations is not found
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-08 23:41:24 +03:00
Ivailo Monev
bb0c031b69 kio: remove checks for .ui3 and .ui4 files in Messages.sh script
obsolete UI files..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-08 23:24:04 +03:00
Ivailo Monev
2280f55199 kio: localize the date and time obtained from kfilemetadata_exiv2 plugin
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-08 21:59:25 +03:00
Ivailo Monev
5c61e288e5 kdeui: remove unused kiamgeframe source and header files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-08 18:32:25 +03:00
Ivailo Monev
65bedeae01 kdeui: return a single format type from KImageIO::typeForMime() and add mode argument for it
because it returns only one (definitive) format type using QStringList as
return type makes no sense, also a mode argument is very much required to
return correct result - not all image format plugins support writing

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-08 17:57:18 +03:00
Ivailo Monev
0c2a65b0e9 kdeui: focus the first KNewPasswordDialog password widget on initialization
much like KPasswordDialog which does a lot of focus tricks depending on
its flags and which widgets are to be shown

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-08 16:11:09 +03:00
Ivailo Monev
33138d4a49 kdecore: effectively revert 6ae96c3c1d
due to Katie changes (see 7c840afcb12096778ecb1539f7baba3e02ba6f85 in the
Katie repo) reading lines is much faster

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-07 17:12:37 +03:00