Commit graph

1151 commits

Author SHA1 Message Date
Ivailo Monev
3bb24edfd3 plasma: correct directory existence check in PlasmoidPackageTest::createAndInstallPackage()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-03 01:33:28 +00:00
Ivailo Monev
1d85d63589 kio: replace QFile::exists() with QDir::exists() and QFileInfo::exists() where applicable
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-03 01:05:44 +00:00
Ivailo Monev
38c049bb36 kdecore: use QDir::exists() to check for directory existence from tests
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 22:38:07 +00:00
Ivailo Monev
246fa5b377 kdecore: remove kde4- prefix from services lookup in KServiceTest
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 18:31:03 +00:00
Ivailo Monev
3ae8b33409 generic: regenerate parsers
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 17:22:10 +00:00
Ivailo Monev
7b84f8d11b kcddb: update expected data of AsyncCDDBLookupTest::testLookup() test case
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 15:58:36 +00:00
Ivailo Monev
aa453fc0d2 kdeui: remove unused flags in QTEST_KDEMAIN_WITH_COMPONENTNAME_KAPP() macro
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 14:44:51 +00:00
Ivailo Monev
a443414554 kdecore: fix regression since 9310423cca
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 14:43:45 +00:00
Ivailo Monev
2382284cb2 kio: establish server for address only if host is empty
fixes HeaderObjectTest test which uses tcp protocol without address

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 13:55:57 +00:00
Ivailo Monev
d1623a08e0 kio: adjust expected data of KDirModelTest::testDeleteDirectory() test case
the signal is emited 3 times, one for each directory from the URL, because
KDirWatch is recursive now

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 12:57:31 +00:00
Ivailo Monev
c82efdb5d9 kdecore: adjust expected data of KLocaleTest::languages() test case
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 02:26:52 +00:00
Ivailo Monev
229e736f74 generic: adjust to KStandardDirs changes
the lookup, even with wildcard, is no longer recursive

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 02:22:48 +00:00
Ivailo Monev
0da430a5b7 kcddb: update expected data of AsyncCDDBLookupTest::testLookup() test case
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 01:53:02 +00:00
Ivailo Monev
597a84c0ef kdecore: rework KCharsetsTest test
the static initializer was removed since Katie does not require it

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 01:48:40 +00:00
Ivailo Monev
459f9d1b7a kdecore: fix process output capturing in KDebugTest::testNoMainComponentData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 01:25:17 +00:00
Ivailo Monev
ce1a80fac2 kio: initialize SocketConnectionBackend::tcpServer member to 0
fixes assert in SocketConnectionBackend::listenForRemote()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-02 00:12:32 +00:00
Ivailo Monev
48b41aadb9 kfile: fix race condition in KDirOperatorTest::testBug187066() test
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-01 23:10:36 +00:00
Ivailo Monev
63cf8d43d5 generic: fix bootstrap build with testing enabled
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-01 22:53:13 +00:00
Ivailo Monev
7d469fdd5b kio: include required stat header in kioslavetest source file
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-02-01 21:14:31 +00:00
Ivailo Monev
dfb95e9e13 kio: do not create widgets for empty metadata values
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-30 13:52:47 +00:00
Ivailo Monev
4357dbf7a4 kio: plug KFileMetaDataWidget memory leak 2020-01-30 13:51:17 +00:00
Ivailo Monev
9ee607bc7c kio: call slotDataChangeFinished() after metadata has been read
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-30 13:39:07 +00:00
Ivailo Monev
6e0f9c880a kio: fix race condition in KFileMetaDataConfigurationWidget::Private::loadMetaData()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-30 12:47:35 +00:00
Ivailo Monev
b49dc4c836 kio: fix Strigi build-time checks
the module for Strigi was removed in 5cf0eafa90
since it provides CMake config file so the check should be for camel-case
not upper-case variable name

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-30 11:54:07 +00:00
Ivailo Monev
49744946c6 kdecore: fix build against Qt4
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-29 13:04:53 +00:00
Ivailo Monev
eb1c4f4e6c cmake: detect Katie specific DBusMenuQt library
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-29 13:04:13 +00:00
Ivailo Monev
c43ceef904 plasma: reuse QFileInfo object in PackageStructure::setPath()
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-25 00:59:51 +00:00
Ivailo Monev
6512385459 kutils: fix WId type handling in KMediaPlayer constructor for 64-bit host
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-25 00:59:00 +00:00
Ivailo Monev
dfb620ff0b plasma: fix regression since fff3f3fbf3
the path being file is not invalid case

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-22 14:42:42 +00:00
Ivailo Monev
f8a084be6c kdeui: plug KXmlGuiWindow memory leak
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 15:05:17 +00:00
Ivailo Monev
b24622f35d kdeui: use QDir::exists() to check for icon directory existence
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 04:01:04 +00:00
Ivailo Monev
052fcecc13 solid: plug a memory leak
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 04:00:31 +00:00
Ivailo Monev
b7a307d949 kdecore: use QFileInfo and QDir to check for existence instead of QFile where applicable
the paths checked in KMountPoint::Private::finalizePossibleMountPoint()
should be symlink to directory, not a file. the check in
KTempDir::removeDir() should obviously be for directory

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-13 02:54:32 +00:00
Ivailo Monev
8f0ce23410 kdecore: drop redundant QFileInfo cache
not only does it leak memory but private QFileInfo data is shared and the
object data will have to be refreshed to obtain correct information

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-12 16:29:33 +00:00
Ivailo Monev
fff3f3fbf3 plasma: use QDir::exists() to check for directory existence
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-09 03:38:03 +00:00
Ivailo Monev
7c787fcae3 kdecore: check if filename argument of KSettings is absolute rather than existing
this ensures that if filename is to be created the fallback lookup is not
used and in case filename is existing directory instead of actual file, as
QFile::exists() may return true for directories, it does not end up as
relative path passed to QSetting which leads to QSettings object being
created with relative name rather than the fallback

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-09 00:10:22 +00:00
Ivailo Monev
2fa84d58be kdecore: remove redundant private KSettings pointer and add object argument
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-06 23:32:14 +00:00
Ivailo Monev
a6ed9873d8 kdewidgets: effectively revert 689b24bae9 and d431c9572f
due to comma signs in some values QSettings from Qt4 implicitly converts
them to QStringList, after that the list cannot be converted to QString
because Qt4 cannot handle the conversion when the list contains more than
one element thus for compatibility the change has to be reverted

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 19:35:21 +00:00
Ivailo Monev
c85da6fadd solid: remove virtual specifier from Solid::Backends::UDev::Button::pressed() signal
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-04 16:33:28 +00:00
Ivailo Monev
f2e0ae8099 kdecore: move sys/stat header inclusion from karchive header to source files
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 18:19:14 +00:00
Ivailo Monev
ea7976dbb8 kio: move sys/stat header inclusion from global header to source files
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-03 17:46:56 +00:00
Ivailo Monev
d431c9572f kdewidgets: skip Global values from the loop
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-02 13:50:38 +00:00
Ivailo Monev
a1345d67d6 generic: require filename and mode to be passed to KSettings constructor
otherwise the constructor can be shadowed by the default QSettings
constructor which does not take any arguments at all

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-01 12:46:10 +00:00
Ivailo Monev
1ed81cdbae Merge branch 'master' of https://github.com/fluxer/kdelibs 2020-01-01 12:20:25 +00:00
Ivailo Monev
689b24bae9 kdewidgets: replace KConfig with KSettings
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-01 12:19:53 +00:00
Ivailo Monev
62fd359884 kdecore: remove explicit specifier from KSettings constructor
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 23:08:09 +00:00
Ivailo Monev
e849b17ba8 kdecore: remove explicit specifier from KSettings constructor
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-25 22:27:26 +00:00
Ivailo Monev
7d0c2d0cb1 generic: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-23 16:36:22 +00:00
Ivailo Monev
eda7c9685f generic: remove unused KCharSelect class
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-20 00:28:21 +00:00
Ivailo Monev
5d6db58b4d generic: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-12-17 01:08:55 +00:00