Commit graph

5316 commits

Author SHA1 Message Date
Ivailo Monev
1a29d6bb3b kio: check if the URL is directory before checking permissions in KRun::isExecutableFile()
as the KRun::isExecutableFile() method name implies - it is only for
checking files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-12 04:26:15 +03:00
Ivailo Monev
f444caa565 kdecore: adjust KMimeType test case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-12 04:11:04 +03:00
Ivailo Monev
a2c8e312d8 kinit: remove temporary files when executable too
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-12 03:33:14 +03:00
Ivailo Monev
b90f90905b kio: move most of the KRun bits to KLauncher
two things doing the same thing - one has to go away. also KRun does not
fork and the launched service/application lifetime was bound to the
process launching it, that is not the case with klauncher - it is bound
to the session (in the usual case)

a few things on the TODO list but mostly for services/applications
lacking features

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-12 03:21:17 +03:00
Ivailo Monev
ceaddee1dd kutils: check if the avahi client pointer is null before using it in KDNSSD
should fix crashes due to internal avahi asserts in some cases (e.g. when
the daemon is not running)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 23:05:13 +03:00
Ivailo Monev
476b1a291d solid: correct device name checks in Solid::Backends::Devinfo::Input::inputType()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 23:01:02 +03:00
Ivailo Monev
c95d7918e6 kdecore: adjust kdnssd debug area defaults
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 22:50:34 +03:00
Ivailo Monev
774427b03a solid: build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 22:47:15 +03:00
Ivailo Monev
72f316b08d solid: implement Solid::Input interface for devinfo backend
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 22:35:08 +03:00
Ivailo Monev
5c66432bfe Revert "solid: check if the object is null before qobject_cast<T>()-ing it in return_SOLID_CALL() macro"
see the following commit in the Katie repo:
d87d2a4e09388bd07560a807be848d4dbc995807
2024-05-10 09:56:46 +03:00
Ivailo Monev
5e8ef901ce solid: check if the object is null before qobject_cast<T>()-ing it in return_SOLID_CALL() macro
fixes possible crashes, notably on FreeBSD the backend of which does not
implement all interfaces

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 09:15:24 +03:00
Ivailo Monev
b46e8b1170 solid: remove unused SOLID_CALL() macro
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 09:14:09 +03:00
Ivailo Monev
5338c9f8e0 plasma: do not log the time in debug messages
slows down startup actually, KDebug has option for (KDE_DEBUG_TIMESTAMP
environment variable)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 07:39:46 +03:00
Ivailo Monev
7bea4731e7 plasma: do not add the default applet actions twice to the action collections
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 07:22:03 +03:00
Ivailo Monev
a8080b7dde kdeui: setup the session config instance for saving
comes with a warning, session management is tricky but it works like a
charm now

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 06:23:55 +03:00
Ivailo Monev
753b39282c kdeui: remove KMainWindow compat bits
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 03:58:43 +03:00
Ivailo Monev
e6666ee203 kio: remove now unused KCModuleInit service type
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 03:36:35 +03:00
Ivailo Monev
d79faf5d2e kdeui: do not ask top-level widgets for close twice
it could happen because after session management is done klauncher sends
SIGTERM to the programs (the session manager does not close the
applications)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-10 03:26:40 +03:00
Ivailo Monev
957f5be670 generic: remove session management support leftovers
the X11 bits anyway. bye, bye broken session management

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-09 08:47:21 +03:00
Ivailo Monev
0e0db0b815 kdeui: move session management to KApplicaiton
every comment about X11 and session management in general claims it was
broken, not going to claim otherwise. everything that does not use
KApplication shall not be involved into session management now and gets
the middle finger (SIGTERM or SIGKILL) after 5 sec by klauncher when the
session is done

also session management has to be explicitly enabled by applications
now, disabled by default

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-09 08:29:51 +03:00
Ivailo Monev
8ce0f2ec3f kinit: delete finished processes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-07 23:32:03 +03:00
Ivailo Monev
c181a8e25c kdeui: do not log the action pointer when unsafe
generally because KGlobalAccel uses raw pointers it is unsafe to use the
KAction pointers for anything but comparison when removing/unregistering
from the KGlobalAccel destructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-07 02:30:48 +03:00
Ivailo Monev
4677b62c24 plasma: remove reference to declarative library
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-07 00:41:48 +03:00
Ivailo Monev
b3c1452d4e kutils: attempt to re-open the password store after the timeout
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 07:34:44 +03:00
Ivailo Monev
3716b1ffe5 kutils: allow storing and retreiving of temporary passwords via KPasswdStore
the implementation supports it and KIO now uses that feature

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 07:22:39 +03:00
Ivailo Monev
972b231e4a kioslave: try authorizing from cache first in curl slave
so that it does not look like a brute-force attack to servers (multiple
jobs are started for thumbnails and such), less round-trips too

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 05:43:17 +03:00
Ivailo Monev
dfc39666d2 kio: remove unused member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 04:48:20 +03:00
Ivailo Monev
9375b3ce72 Revert "kdecore: unexport KJobPrivate"
This reverts commit d797c27b77.
2024-05-05 04:44:29 +03:00
Ivailo Monev
d797c27b77 kdecore: unexport KJobPrivate
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 04:04:41 +03:00
Ivailo Monev
b8d4dc0dc4 generic: call static KStandardDirs methods as such
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 02:04:03 +03:00
Ivailo Monev
8b9fc25d48 kdecore: kFolderIconName() function optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 01:45:44 +03:00
Ivailo Monev
678417ea8d kdecore: require all KMimeTypeRepository::findMimeTypeByName() arguments
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 01:34:52 +03:00
Ivailo Monev
d6a21de5f9 kdecore: add comment about exceptions in KMimeTypeRepository::findFromContent()
I've checked, a few require twice as much

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 01:02:51 +03:00
Ivailo Monev
bac4abfd7a kdecore: MIME glob matching optimization
passes tests

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 00:41:13 +03:00
Ivailo Monev
7a5af39420 includes: remove header for now gone class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-04 23:23:14 +03:00
Ivailo Monev
5bb3125631 kdecore: consistent debug messages
some logging to the generic debug area, some to the services debug area and
some to the kbuildsycoca debug area..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-04 21:43:41 +03:00
Ivailo Monev
1ff6f4d2ee kdecore: MIME glob matching optimization
by doing it with a single iteration over the globs a lot less processing
has to be done

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-05 00:11:11 +03:00
Ivailo Monev
d338e13b8d kdecore: update favicon link and add shared-mime-info spec one
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-04 22:41:06 +03:00
Ivailo Monev
22c025def4 kio: reduce the job queue timeout
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-04 22:35:16 +03:00
Ivailo Monev
9796436b43 kdecore: KMimeType documentation review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-04 22:22:07 +03:00
Ivailo Monev
d45c3a867b kio: remove unused variable
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-04 21:59:13 +03:00
Ivailo Monev
559411bd09 generic: optimize MIME type detection
KRun already had such optimization in place for example, that makes the
file slave kinda special tho as it will determine MIME type only from mode
but the goal is to not even spin a job and a slave for local files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-04 21:26:18 +03:00
Ivailo Monev
817b7a4aab kdecore: rework KMimeType
more accurate probing then before, notably by probing the file content
from the file slave (only the name was checked before because the
filepath was not a full path in some cases and the file could not be
open)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-04 20:14:53 +03:00
Ivailo Monev
ee4c56ad5e kioslave: use the full path to determine the MIME type in file slave
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-04 04:14:15 +03:00
Ivailo Monev
f34328e051 kioslave: update comment in file slave
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-04 04:08:44 +03:00
Ivailo Monev
6820e4e63c kioslave: different take on MIME type determination in curl slave
because FTP and SFTP are special about it so is the MIME type
determination

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-04 04:03:02 +03:00
Ivailo Monev
d1fd7fdab6 kioslave: curl slave optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-03 23:14:51 +03:00
Ivailo Monev
c763b1266a kioslave: remove bits used during curl slave rework
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-03 22:32:01 +03:00
Ivailo Monev
954e45641e kio: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-03 20:35:43 +03:00
Ivailo Monev
103bc5a7d9 kutils: check the read result in KArchivePrivate::writeFile()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-03 20:35:27 +03:00