Commit graph

2766 commits

Author SHA1 Message Date
Ivailo Monev
e158808da9 kdesudo: set LANG and LC_ALL for the process
translations and command-line programs output parsing do not get along

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 01:00:22 +03:00
Ivailo Monev
bf041a724f kdesudo: fix execution failure detection and notification
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 00:53:53 +03:00
Ivailo Monev
5bca600df3 kdesudo: remove unused stdlib header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:42:26 +03:00
Ivailo Monev
8ef70f7c75 kdesudo: remove unused variable in main()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:40:26 +03:00
Ivailo Monev
ac0c225fe8 kdesudo: increase the wait times in KDESu::KDESuPrivate::KCookie constructor to 3secs
100ms is not a whole lot with kernel scheduling, if the process is ready
to read in less than 3secs the waiting will stop anyway

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:39:54 +03:00
Ivailo Monev
63c440a6d3 kdesudo: terminate the process from KdeSudo destructor
the process is not detached thus it will happen one way or other but doing
it from the KdeSudo destructor with 3sec wait time for the process to
terminate will silence the QProcess runtime warning (possibly, unless the
process does not quit on SIGTERM or within 3 seconds)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:30:32 +03:00
Ivailo Monev
cea6fb2142 kdesudo: keep reference to the QByteArray object in KdeSudo::parseOutput()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:21:33 +03:00
Ivailo Monev
71f69968ff kdesudo: plug memory leak
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:19:31 +03:00
Ivailo Monev
2d3f88e1cf kdesudo: remove unused KdeSudo::slotUser1() slot
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:16:59 +03:00
Ivailo Monev
648b95d4d2 kdesudo: remove unused KdeSudo members and methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:14:02 +03:00
Ivailo Monev
5800089d10 kcontrol: queue the randr KCM tray actions
so that events can be processed and the modal dialog about accepting the
changes does not block the event queue

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 18:11:31 +03:00
Ivailo Monev
ee0a299d73 libs: iterate over a copy of the startups list in TaskManager::killStartup()
because removing item from the list via QList<T>::removeAll() modifies the
list

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 15:27:16 +03:00
Ivailo Monev
5606f97af8 plasma: minor SystemTray::DBusSystemTrayProtocol::initRegisteredServices() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 04:35:31 +03:00
Ivailo Monev
57201e863c kglobalaccel: correct check for invalid key sequences in keysFromString() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 23:15:27 +03:00
Ivailo Monev
7d79ee3af0 kwin: intercept the mouse and interrupt the startupfeedback effect on mouse release
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 22:53:28 +03:00
Ivailo Monev
c2f70506a8 kglobalaccel: do not deep-copy the KdeDGlobalAccel::GlobalShortcut::setKeys() argument
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 20:35:43 +03:00
Ivailo Monev
dc02d88fe4 kglobalaccel: keysFromString() and stringFromKeys() functions optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 20:15:32 +03:00
Ivailo Monev
e176878135 kglobalaccel: KdeDGlobalAccel::Component::getShortcutByName() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 20:14:27 +03:00
Ivailo Monev
3c2cd23848 khotkeys: replace tab with spaces
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 06:07:04 +03:00
Ivailo Monev
e6445e89f7 kglobalaccel: log messages to special area
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 05:09:43 +03:00
Ivailo Monev
dc2e1859df kmediaplayer: use standard actions where possible
for icons consistency, translations, etc.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 00:53:33 +03:00
Ivailo Monev
fe7f483647 generic: replace globs with MIME types in KFileDialog method calls
see the previous commit

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 00:40:03 +03:00
Ivailo Monev
c7173b98af kwin: use MIME type instead of glob for the window rules
requires the following commit from kdelibs:
31553f8958bb3aa36957ae5d2ebe0b315cad27d8

the MIME type is translated while globs passed to
KFileDialog::getSaveFileName() (and the related getters) have to be
translated in each application

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 00:24:09 +03:00
Ivailo Monev
99357e8a44 soliduiserver: check if the device is removable before unmounting it
as a precaution for device invalidation after unmount

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 00:15:05 +03:00
Ivailo Monev
cb97fd9984 soliduiserver: notify about mount and unmount errors as well as safe to remove devices
much like prior to f47177f876 except that
the notification is not done on solid signals but from the KDED module
responsible for mounting and unmounting

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 00:05:25 +03:00
Ivailo Monev
cca70e0412 kwin: KWin::Workspace::clientShortcutUpdated() optimization
KActionCollection::action() method takes QString as argument thus the
conversion to latin1 and then to char array would generate code path such
that QString would have to be constructed again..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 23:24:15 +03:00
Ivailo Monev
5ce06c488b plasma: X11EmbedContainer::setBackgroundPixmap() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 21:29:11 +03:00
Ivailo Monev
65dd8a3dfa klipper: adjust to KNotification changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 21:26:51 +03:00
Ivailo Monev
1fb3e430d4 kcontrol: add *.ogg and *.oga to the access KCM pattern
no idea what "artsd" is but figuring out in what format standard sounds are
is easy - just look into /usr/share/sounds. also, the sound files shipped
by Katana are in OGG format

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 06:50:12 +03:00
Ivailo Monev
c516068d74 knotify: change the combo box index on KCM load
changing the combo box index changes the notification config widget

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-25 21:49:51 +03:00
Ivailo Monev
a011628b2a knotify: implement save and load for the KCM
now to implemented KNotificationConfigWidget..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-25 19:40:19 +03:00
Ivailo Monev
48c9f4c366 kfreespace: correct application name in KCM
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-25 19:38:45 +03:00
Ivailo Monev
bb7d56f999 knotify: fill the event sources combo box
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-25 19:03:43 +03:00
Ivailo Monev
c36ca89159 knotify: stub KCM
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-25 08:48:04 +03:00
Ivailo Monev
47b083fbf2 ktouchpadenabler: use standard notification event IDs
it should probably use custom config and event IDs tho

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-25 08:47:09 +03:00
Ivailo Monev
f47177f876 generic: adjust to KNotification changes
some notification files, such as the style KCM one, were not even used

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-25 08:07:58 +03:00
Ivailo Monev
5530bc18f3 kglobalaccel: remove unused variable
no idea what those bits were supposed to do

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-24 17:52:39 +03:00
Ivailo Monev
f52abcc81d libs: remove unused KPassivePopup header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-24 17:19:55 +03:00
Ivailo Monev
ca9117d909 generic: add X-KDE-HasTrayOption to .desktop files
for applications that do not create main window (e.g. create dialog window
instead) the tray feature is not enabled

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-24 16:57:14 +03:00
Ivailo Monev
39b8ffd1a6 kfind: adjust to KGlobalSettings changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-24 01:50:20 +03:00
Ivailo Monev
3f85de5864 ksystraycmd: drop it and use the new tray argument of KApplication
see the following commit in kdelibs repo:
4b632fcae67da3b95e69e954fa2e581a42f4c53c

currently enabled only for a few applications until more tests are done

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-24 01:45:34 +03:00
Ivailo Monev
69f7efcce1 plasma: adjust batterymonitor applet to solid changes
there were solid enum changes and then some in this repo, see the
following commit in the kdelibs repo:
2e1544537da02c8e89bc08c59fd3d6e1d146ef8c

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-23 21:12:39 +03:00
Ivailo Monev
4584fab20b libs: remove non-operational TaskManager::GroupManager::TaskSortingStrategy::ActivitySorting enum
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-22 23:57:15 +03:00
Ivailo Monev
0104dd678a plasma: default to manual sorting in tasks applet
see:
bd84219d6a

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-22 23:51:30 +03:00
Ivailo Monev
39e320492d qguiplatformplugin_kde: apply the cursor theme
for when not even X11 Xfixes extension can do it (as was done by
KGlobalSettings, however the difference being no check is done if it is
full Katana session - it is simply assumed it is the case when the platform
plugin is loaded)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-22 07:20:38 +03:00
Ivailo Monev
10e08246ca kcontrol: keep reference to the QByteArray object in ThemePage::applyTheme()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-22 05:57:52 +03:00
Ivailo Monev
186a7702e8 generic: adjust to KGlobalSettings changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-22 04:29:13 +03:00
Ivailo Monev
7e561880f1 qguiplatformplugin_kde: KQGuiPlatformPlugin::platformHint() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-22 09:32:16 +03:00
Ivailo Monev
7a6f5d0a25 kmediaplayer: specify filter for the open dialog
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-22 09:15:15 +03:00
Ivailo Monev
0a6ae17f1b qguiplatformplugin_kde: update comment about qt2KdeFilter() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-22 08:44:55 +03:00