Commit graph

1563 commits

Author SHA1 Message Date
Ivailo Monev
90d2fb260f startkde: adjust to kdelibs changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-25 08:22:05 +03:00
Ivailo Monev
919ca17315 startkde: update comments
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-25 05:49:06 +03:00
Ivailo Monev
6f241bb936 startkde: remove check for now always empty dl variable
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-25 05:17:34 +03:00
Ivailo Monev
abab76a84a generic: adjust to special resources directories changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-25 04:29:13 +03:00
Ivailo Monev
42a7abad6d startkde: export variables early and check PATH later
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-25 03:23:46 +03:00
Ivailo Monev
ba2d271ed3 startkde: remove check for DESKTOP_LOCKED
was set by KDM

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-25 03:16:24 +03:00
Ivailo Monev
fc19281f94 generic: set X-DBUS-ServiceName key for kglobalaccel and kuiserver in the desktop files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 16:09:22 +03:00
Ivailo Monev
9e174e4544 kgreeter: implement option to change the cursor theme
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 15:20:56 +03:00
Ivailo Monev
abe93a9325 kcontrol: remove unused system service file for org.kde.fontinst
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 14:28:39 +03:00
Ivailo Monev
780dc422b1 libs: do not elevate privileges to send signals to processes
the privilege elevation should ask for the password of the user that owns
the process to begin with not the other way around - `sudo` is asking me if
I know my password to kill `kwin` process of Bob? Yes, I do!

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 13:00:41 +03:00
Ivailo Monev
c7429922cf libs: comment correction
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 12:44:33 +03:00
Ivailo Monev
56bab94dbf kwin: do not use ksysguard helper for killing processes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 12:39:19 +03:00
Ivailo Monev
d9ed85fec5 plasma: do not use ksysguard helper for killing processes and pop an error when the runner action fails
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 12:38:08 +03:00
Ivailo Monev
38621bba32 knotify: use KApplication instead of KUniqueApplication
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 11:33:42 +03:00
Ivailo Monev
d18be9c04f kuiserver: use KApplication instead of KUniqueApplication
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 11:04:00 +03:00
Ivailo Monev
8059a78c57 kglobalaccel: create KApplication instance before D-Bus connection
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 10:58:58 +03:00
Ivailo Monev
b4629ae603 libs: manually delete favicons module jobs
fixes possible crash in case the job is automatically deleted and
KJob::errorString() is called to get the error

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 10:22:48 +03:00
Ivailo Monev
038d9286b0 libs: workaround for QSignalSpy in favicon test
TODO: reimplement QSignalSpy to use connections or just write a new class

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 09:39:49 +03:00
Ivailo Monev
3bcc2da57b libs: convert FavIconsModule::isIconOld() to static function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 09:32:44 +03:00
Ivailo Monev
ec06deac86 libs: declare download info struct as primitive and rename it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 09:19:23 +03:00
Ivailo Monev
c2f38b1a3b libs: connect to all favicons module signals in its test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 08:39:43 +03:00
Ivailo Monev
aa43bf3820 libs: test favicons module with IP addresses
requires:
38079e572c

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 08:06:19 +03:00
Ivailo Monev
5fd013b48d kglobalaccel: use KApplication instead of KUniqueApplication
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 06:37:13 +03:00
Ivailo Monev
a506292cd5 ksmserver: format and indent kcheckrunning source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-24 06:31:32 +03:00
Ivailo Monev
f6c5c370c8 kglobalaccel: install D-Bus service file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 21:39:32 +03:00
Ivailo Monev
02d8a78de8 libs: remove redundant favicons memory cache
the cache is supposed to speed-up non-host icon lookups but it does so only
for the life-time of the module, it becomes cache miss as soon as the
module is unloaded since the cache is not restored by the module from the
FavIconsModule constructor

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 09:04:20 +03:00
Ivailo Monev
11c62954d8 libs: favicons KDED module test re-write
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 06:54:52 +03:00
Ivailo Monev
6009accdc6 libs: do not store the favicons cache directory
KStandardDirs::saveLocation() will re-create it if it is deleted

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 05:25:14 +03:00
Ivailo Monev
e806e8a4c7 libs: warn when the image reader claims the data is readable but returns null image from favicon KDED module
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:35:12 +03:00
Ivailo Monev
055a8ca5f1 libs: warn when the image reader cannot read the favicon data
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:32:23 +03:00
Ivailo Monev
a55034d4f2 libs: fix possible favicons KDED module race-conditions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 04:04:45 +03:00
Ivailo Monev
f437e42045 libs: kill the job immediately if the favicon is too big and remove it from the downloads queue
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 03:58:22 +03:00
Ivailo Monev
dd4dfe1848 kwin: do not test canonical name if getaddrinfo() fails
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 02:46:55 +03:00
Ivailo Monev
96ecc857aa kwin: use QHostInfo::localHostName() to get the local host name
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 02:42:46 +03:00
Ivailo Monev
9b9a39951c kwin: fix crash in case of getaddrinfo() failure in client machine test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 02:21:39 +03:00
Ivailo Monev
56f58144c7 kioslave: skip trash slave tests that are not to be run as root
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 02:15:17 +03:00
Ivailo Monev
9790faa5d7 libs: double the wait time for favicon signals
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:35:46 +03:00
Ivailo Monev
3ed404a6be libs: convert FavIconsModulePrivate::makeIconName() to static function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:16:42 +03:00
Ivailo Monev
83a8cd1cf1 libs: de-virtualize FavIconsModulePrivate destructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 01:14:45 +03:00
Ivailo Monev
5f6c75eee2 libs: attach the signal spy after D-Bus initialization stuff happens in favicon test
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 00:09:32 +03:00
Ivailo Monev
8acb29cd9f libs: remove unused system ctime header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-23 00:08:32 +03:00
Ivailo Monev
6153a04df0 libs: if the favicon modification time is not valid consider it as old
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 23:43:16 +03:00
Ivailo Monev
4afd6b308f libs: mark ksysguard processes test case as flaky
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 22:46:20 +03:00
Ivailo Monev
c5c1ecc7fc libs: skip only the tests relying on permissions when they are unexpected
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 22:38:08 +03:00
Ivailo Monev
8b0d5382fb kate: increase completion started/aborted verification timeout to 3sec in tests
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 22:16:09 +03:00
Ivailo Monev
b43cc7be54 kate: completion tests do not require ksycoca
tests do not install or remove services

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 22:10:01 +03:00
Ivailo Monev
731cdb39d5 libs: skip some tests when the permissions do not match the expectations
this is the case when the tests are run as root

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 20:46:47 +03:00
Ivailo Monev
3053762d87 plasma: replace number with enum in systemtray applet
for reference:
https://github.com/fluxer/qt/blob/4.8/src/corelib/global/qnamespace.h#L542

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 10:18:11 +03:00
Ivailo Monev
d75c15bd56 kde-menu: do not use KToolInvocation/KLauncher to execute kbuildsycoca4
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 10:01:01 +03:00
Ivailo Monev
61965cf96f libs: quit event loops if signals are not emitted after 10sec in favicons test case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-05-22 08:28:43 +03:00