Commit graph

2787 commits

Author SHA1 Message Date
Ivailo Monev
76a3183199 kiconfinder: remove unused kapplication header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 18:00:22 +03:00
Ivailo Monev
7a2e7e8b73 kiconfinder: keep references to QByteArray objects
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 17:58:34 +03:00
Ivailo Monev
eee1429e54 kiconfinder: optimizations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 17:57:21 +03:00
Ivailo Monev
3705256bc4 kiconfinder: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 17:54:50 +03:00
Ivailo Monev
a79c074652 libs: remove unused deprecated KonqPopupMenuPlugin class
KonqPopupMenu/Plugin is independant implementation - .desktop files with
actions and a service type to query for

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 17:21:51 +03:00
Ivailo Monev
78b2c3d80d libs: remove deprecated KonqCopyToMenu constructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 16:44:19 +03:00
Ivailo Monev
3795d6d515 libs: remove unused directory_bookmarkbar.desktop file
KBookmarkManager and related classes do not use .desktop files

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 16:24:19 +03:00
Ivailo Monev
a38e492f38 libs: KonqPopupMenu documentation review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 16:14:45 +03:00
Ivailo Monev
0dc8347c49 generic: adjust to kparts changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 04:10:49 +03:00
Ivailo Monev
d53f503cad plasma: remove non-operational kickoff applet bits
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 03:02:55 +03:00
Ivailo Monev
f65e97a948 generic: do not create temporary QString objects for conversion to integer
QByteArray::toLong() does the same as QString::toLong() except faster

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-31 03:01:36 +03:00
Ivailo Monev
db6643a680 generic: remove redundant logout effect hack
ksmserver no longer uses custom effect for logout, for reference:
36d3e65630

bonus points for less X11 round-trips on logout

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 20:12:17 +03:00
Ivailo Monev
e230b4cbc7 plasma: remove bogus opaque shutdowndialog image
whoever made that image from the source (see
plasma/desktoptheme/oxygen/dialogs/shutdowndialog.source.svgz
and plasma/desktoptheme/oxygen/dialogs/shutdowndialog.svgz) did not
remove everything but the moon and the moon picture object covers
the text in the shutdown dialog

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 19:58:28 +03:00
Ivailo Monev
d2181fd762 kcontrol: update key schemes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 17:42:17 +03:00
Ivailo Monev
66f6104da4 generic: replace QLabel with the new KPixmapWidget class
or how to optimize painting of pixmaps and icons

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 05:10:09 +03:00
Ivailo Monev
23479d802a keditfiletype: remove bits for always false condition
the iconLabel member is always null

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 04:29:08 +03:00
Ivailo Monev
0d32557a65 plasma: QImageItem and QPixmapItem size getters optimizations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 04:07:24 +03:00
Ivailo Monev
07c018707e plasma: CalendarApplet::paintIcon() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-30 04:05:21 +03:00
Ivailo Monev
5949b572bc khotkeys: drop it
the only use case is to launch ksnapshot which can be done by
plasma-desktop, some of the actions code is borked (notably window
matching, global and menu actions were working) and I have no
intention to fix it. even if fixed when a window (and thus possibly
application) key is grabbed there is a chance the window (application)
may want to grab the grabbed key and fail (i.e. grab conflict) so it
shall be left to the application to set what keys shall be global
(grabbed) hence the bits to start ksnapshot are moved to plasma-desktop

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 23:04:14 +03:00
Ivailo Monev
cf558d649b soliduiserver: use Solid::errorString() for the mount/unmount error notification text
translated and more specifiec than the generic "Mount or unmount error"
text in soliduiserver.notifyrc

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 04:19:19 +03:00
Ivailo Monev
0121acd1ab klipper: set global shortctut for the "Open Klipper at Mouse Position" action
if it is not full Katana session neither plasma-desktop nor its systemtray
applet will setup the shortcut so its better done by klipper itself

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 03:53:02 +03:00
Ivailo Monev
e158808da9 kdesudo: set LANG and LC_ALL for the process
translations and command-line programs output parsing do not get along

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 01:00:22 +03:00
Ivailo Monev
bf041a724f kdesudo: fix execution failure detection and notification
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 00:53:53 +03:00
Ivailo Monev
5bca600df3 kdesudo: remove unused stdlib header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:42:26 +03:00
Ivailo Monev
8ef70f7c75 kdesudo: remove unused variable in main()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:40:26 +03:00
Ivailo Monev
ac0c225fe8 kdesudo: increase the wait times in KDESu::KDESuPrivate::KCookie constructor to 3secs
100ms is not a whole lot with kernel scheduling, if the process is ready
to read in less than 3secs the waiting will stop anyway

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:39:54 +03:00
Ivailo Monev
63c440a6d3 kdesudo: terminate the process from KdeSudo destructor
the process is not detached thus it will happen one way or other but doing
it from the KdeSudo destructor with 3sec wait time for the process to
terminate will silence the QProcess runtime warning (possibly, unless the
process does not quit on SIGTERM or within 3 seconds)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:30:32 +03:00
Ivailo Monev
cea6fb2142 kdesudo: keep reference to the QByteArray object in KdeSudo::parseOutput()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:21:33 +03:00
Ivailo Monev
71f69968ff kdesudo: plug memory leak
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:19:31 +03:00
Ivailo Monev
2d3f88e1cf kdesudo: remove unused KdeSudo::slotUser1() slot
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:16:59 +03:00
Ivailo Monev
648b95d4d2 kdesudo: remove unused KdeSudo members and methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 23:14:02 +03:00
Ivailo Monev
5800089d10 kcontrol: queue the randr KCM tray actions
so that events can be processed and the modal dialog about accepting the
changes does not block the event queue

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 18:11:31 +03:00
Ivailo Monev
ee0a299d73 libs: iterate over a copy of the startups list in TaskManager::killStartup()
because removing item from the list via QList<T>::removeAll() modifies the
list

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 15:27:16 +03:00
Ivailo Monev
5606f97af8 plasma: minor SystemTray::DBusSystemTrayProtocol::initRegisteredServices() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 04:35:31 +03:00
Ivailo Monev
57201e863c kglobalaccel: correct check for invalid key sequences in keysFromString() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 23:15:27 +03:00
Ivailo Monev
7d79ee3af0 kwin: intercept the mouse and interrupt the startupfeedback effect on mouse release
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 22:53:28 +03:00
Ivailo Monev
c2f70506a8 kglobalaccel: do not deep-copy the KdeDGlobalAccel::GlobalShortcut::setKeys() argument
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 20:35:43 +03:00
Ivailo Monev
dc02d88fe4 kglobalaccel: keysFromString() and stringFromKeys() functions optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 20:15:32 +03:00
Ivailo Monev
e176878135 kglobalaccel: KdeDGlobalAccel::Component::getShortcutByName() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 20:14:27 +03:00
Ivailo Monev
3c2cd23848 khotkeys: replace tab with spaces
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 06:07:04 +03:00
Ivailo Monev
e6445e89f7 kglobalaccel: log messages to special area
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 05:09:43 +03:00
Ivailo Monev
dc2e1859df kmediaplayer: use standard actions where possible
for icons consistency, translations, etc.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 00:53:33 +03:00
Ivailo Monev
fe7f483647 generic: replace globs with MIME types in KFileDialog method calls
see the previous commit

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 00:40:03 +03:00
Ivailo Monev
c7173b98af kwin: use MIME type instead of glob for the window rules
requires the following commit from kdelibs:
31553f8958bb3aa36957ae5d2ebe0b315cad27d8

the MIME type is translated while globs passed to
KFileDialog::getSaveFileName() (and the related getters) have to be
translated in each application

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 00:24:09 +03:00
Ivailo Monev
99357e8a44 soliduiserver: check if the device is removable before unmounting it
as a precaution for device invalidation after unmount

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 00:15:05 +03:00
Ivailo Monev
cb97fd9984 soliduiserver: notify about mount and unmount errors as well as safe to remove devices
much like prior to f47177f876 except that
the notification is not done on solid signals but from the KDED module
responsible for mounting and unmounting

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 00:05:25 +03:00
Ivailo Monev
cca70e0412 kwin: KWin::Workspace::clientShortcutUpdated() optimization
KActionCollection::action() method takes QString as argument thus the
conversion to latin1 and then to char array would generate code path such
that QString would have to be constructed again..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 23:24:15 +03:00
Ivailo Monev
5ce06c488b plasma: X11EmbedContainer::setBackgroundPixmap() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 21:29:11 +03:00
Ivailo Monev
65dd8a3dfa klipper: adjust to KNotification changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 21:26:51 +03:00
Ivailo Monev
1fb3e430d4 kcontrol: add *.ogg and *.oga to the access KCM pattern
no idea what "artsd" is but figuring out in what format standard sounds are
is easy - just look into /usr/share/sounds. also, the sound files shipped
by Katana are in OGG format

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-26 06:50:12 +03:00