what is wrong with the old applet implementation? it uses two
dataengines which by itself is a huge performance penalty. the current
applet implementation is minimal - shows only the system CPU load and
that is about it but I intend to expand upon that
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
QCoreApplication::quit() stops event loops, it does not call ::exit() and
as the application (konsole application) instance is constructed there is
no even loop to quit (someone derped there, see the TODO too)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
for proxy settings there can be KCM that sets klauncher variables for
proxy preferences, has yet to be decided tho
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
screen inhibition based on monitor name and lid button presence sounds like
someone wanted X11 DPMS (which is automatic nowdays) on his laptop to me
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
m_showConfirmDialog is always false, no idea why
KWinCompositingConfig::showConfirmDialog() was virtual
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
KDialog::marginHint() is kinda deprecated right now, the margin depends on
the style hints anyway which KDialog::marginHint() is a shortcut for
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
under some conditions it can happen that error occurs but it happens before
the directory loading completion signal is emitted and it is as if the
message is not shown, a typical case was when connecting to remote host
fails
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
it may be a temporary file job and the destination in that case is a URL
pointing to file in /tmp (or other directory for such files)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
the changes date back to 2015, see the following commit in kdelibs repo:
21ad0df4885be0723a6cc3e513939f9834f53183
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
things get complicated when one method (KCMNotification::load()) is used
for more than one thing (load and reset)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
because no size at all is set, otherwise it should be set to
Plasma::AspectRatioMode::KeepAspectRatio and the size set to something like
128x128
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
credits to Benjamin Grant for making me do it, fallback is still 1 GB and
the configuration interface remains the same but the default should fit
more cases now
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
there never was a way to enable it (not via gui anyway) meaning the bits
are doing nothing (other than slow down kwin that is)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
