Katana_mirror/kde-workspace
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kde-workspace.git synced 2025-02-23 18:32:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

knotify: fix KCM reset

Browse source 
things get complicated when one method (KCMNotification::load()) is used
for more than one thing (load and reset)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2024-03-15 00:15:50 +02:00
parent 7797c5d302
commit 94fc697139
2 changed files with 20 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
knotify/kcm/knotificationconfig.cpp
View file

@ -38,7 +38,8 @@ KCMNotification::KCMNotification(QWidget *parent, const QVariantList &args)
m_layout(nullptr),
m_notificationslabel(nullptr),
m_notificationsbox(nullptr),
m_notificationswidget(nullptr)
m_notificationswidget(nullptr),
m_firstload(true)
{
Q_UNUSED(args);
@ -87,12 +88,23 @@ KCMNotification::KCMNotification(QWidget *parent, const QVariantList &args)
void KCMNotification::load()
{
const int kdeindex = m_notificationsbox->findData(s_kdenotification);
if (kdeindex >= 0) {
m_notificationsbox->setCurrentIndex(kdeindex);
} else {
kWarning() << "could not find the index of" << s_kdenotification;
if (m_firstload) {
m_firstload = false;
const int kdeindex = m_notificationsbox->findData(s_kdenotification);
if (kdeindex >= 0) {
m_notificationsbox->setCurrentIndex(kdeindex);
} else {
kWarning() << "could not find the index of" << s_kdenotification;
}
m_notificationswidget->setNotification(s_kdenotification);
emit changed(false);
return;
}
const QString notification = m_notificationsbox->itemData(m_notificationsbox->currentIndex()).toString();
m_notificationswidget->setNotification(notification);
emit changed(false);
}
@ -106,6 +118,7 @@ void KCMNotification::slotSourceIndexChanged(int index)
{
const QString notification = m_notificationsbox->itemData(index).toString();
m_notificationswidget->setNotification(notification);
emit changed(false);
}
void KCMNotification::slotNotificationChanged(bool state)

1
knotify/kcm/knotificationconfig.h
View file

@ -50,6 +50,7 @@ private:
QLabel* m_notificationslabel;
KComboBox* m_notificationsbox;
KNotificationConfigWidget* m_notificationswidget;
bool m_firstload;
};
#endif // KNOTIFICATIONCONFIG_H