Commit graph

1969 commits

Author SHA1 Message Date
Ivailo Monev
2795dc5695 kmediaplayer: save the current menu and status bar state after calling KXmlGuiWindow::showEvent()
KXmlGuiWindow::showEvent() may trigger things such as restoring the window
state

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 03:10:00 +02:00
Ivailo Monev
4b164a6724 dolphin: hide the image preview before showing the video player
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-28 22:37:39 +02:00
Ivailo Monev
c868c10f65 dolphin: parent InformationPanelContent widget to itself
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-28 22:09:32 +02:00
Ivailo Monev
21bda2c7cd dolphin: set the maximum size of the video preview widget even if it is not visible
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-28 21:01:56 +02:00
Ivailo Monev
b1cb5c6075 dolphin: do not set the video player maximum size to the current size of the image preview
their minimum and maximum sizes are set to match now but their hints differ
on purpose

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 06:36:07 +02:00
Ivailo Monev
388b70e51c dolphin: set the minimum height of the KMediaWidget
to match that of the image preview widget

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 06:19:00 +02:00
Ivailo Monev
6a2ef9c5b2 kmediaplayr: reuse variable
KActionCollection takes ownership of the actions and the variable is just
a temporary to ease setup

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 05:11:36 +02:00
Ivailo Monev
63384fbfdc kmediaplayer: typo
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 05:05:58 +02:00
Ivailo Monev
62439ad012 kmediaplayer: mark KMediaWindow reimplementations as final
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 05:04:31 +02:00
Ivailo Monev
473d67a46c kmediaplayer: prefix slots with "slot"
KMediaWindow inherits KXmlGuiWindow which inherits KMainWindow, which
inherits QMainWindow, which has a menuBar() getter that should not be
confused with the KMediaWindow class slot. same goes for
KMediaWindow::menubar() (now named KMediaWindow::slotMenubar()) and
QMainWindow::menuBar()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 05:03:01 +02:00
Ivailo Monev
f944f6e000 kmediaplayer: set the part object name
used by debug message in kdelibs/kparts/part.cpp

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 23:28:02 +02:00
Ivailo Monev
57be009258 kmediaplayer: use QPointer<T> to store the KMediaWidget pointer
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 20:44:13 +02:00
Ivailo Monev
d874397ed4 krunner: remove unused constant in KRunnerDialog::updateMask()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 06:49:13 +02:00
Ivailo Monev
f00e4c99b3 ksmserver: process events until kded second phase is done
now that phase 2 is properly done (see
86082941ab933b36fb7df267f3abd2625757f4ba in kdelibs repo) it could
block for a few seconds

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 05:13:00 +02:00
Ivailo Monev
12491d988d kioslave: add image/vnd.djvu+multipage to the djvuthumbnail MIME types
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 00:23:52 +02:00
Ivailo Monev
16862f5e52 kioslave: const-ify variable in ThumbnailProtocol::pluginForMimeType()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 00:19:33 +02:00
Ivailo Monev
1de418911e kdirshare: write share entry into the kdirsharerc config from KDirShareModule::share()
should the worst happen and kded4 crash the share settings will be saved
regardless (unless it crashes because of KDirShareModule::share())

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 21:05:34 +02:00
Ivailo Monev
77453ce6e9 kdirshare: use KRandom::randomMax() for less round-trips
feels like a new KRandom::randomRange() method is needed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 19:11:03 +02:00
Ivailo Monev
a408a397a5 kdirshare: update comment related to kpasswdstore service
kpasswdstore service is now loaded in phase 1 and kdirshare in phase 2 (the
default)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 19:06:29 +02:00
Ivailo Monev
887f7c3079 libs: remove bogus extern reference
there is no such thing as Kapp, is not used either

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 01:02:30 +02:00
Ivailo Monev
795cb31a59 generic: remove redundant HAVE_XRENDER configuration definition
if Xrender is not found a fatal message will be issued by the top-level
CMakeLists file because it is required by KWin compositor for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 00:46:00 +02:00
Ivailo Monev
9e697dfade kate: log the file (Kate::TextLoader) codec name
m_textCodec is used only to probe, if BOM is detected m_textCodec may be
null. fixes possible crash

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-24 03:12:29 +02:00
Ivailo Monev
0e5782b8e3 kate: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-24 03:01:18 +02:00
Ivailo Monev
6b6921c8cc kstyles: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-24 00:40:22 +02:00
Ivailo Monev
4885185b98 kate: add QGuiPlatformPlugin class to cpp syntax data
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 23:06:23 +02:00
Ivailo Monev
243f64bdfd kcontrol: read font settings directly from the kdeglobals config
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 20:12:44 +02:00
Ivailo Monev
56b3159f80 kcontrol: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 19:55:04 +02:00
Ivailo Monev
45778efb45 kcontrol: enable animatetoolbox when effects are enabled
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 15:46:06 +02:00
Ivailo Monev
9ed7286504 kcontrol: partial fix for KGlobalSettings race
the style KCM for example emits changes via
KGlobalSettings::self()->emitChange() however it does not wait for the
KGlobalSettings::settingsChanged() signal (which means settings are
reloaded) before running krdb, font and palette settings are likely subject
to this race-condition but for now that will do

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 05:18:50 +02:00
Ivailo Monev
35151a7d91 generic: adjust to KGlobalSettings changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 05:05:45 +02:00
Ivailo Monev
617366c72d kcontrol: remove unused applyQtColors() and applyQtSettings() arguments
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 02:29:27 +02:00
Ivailo Monev
71e0885005 kcontrol: run krdb after emiting KGlobalSettings changes from style KCM
krdb itself uses KGlobalSettings to get the palette, font and other
settings

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 02:28:15 +02:00
Ivailo Monev
26a25dae5f kcontrol: flush the QSettings changes before notifying applications about the changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 02:16:34 +02:00
Ivailo Monev
2266ab6cba kcontrol: enable Katie effects based on Katana graphics effect level
note that the only way to set EffectsEnabled, EffectFadeMenu,
EffectFadeTooltip and EffectAnimateCombo was manually (by editing the
~/.katana/share/config/kdeglobals config file) because there is no GUI for
those config options but there is for the graphics effects level

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 23:51:37 +02:00
Ivailo Monev
020b15b996 startkde: update D-Bus session environment with all variable set by the script
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 21:03:20 +02:00
Ivailo Monev
f4f118f40b startkde: unset kcheckrunning_result after it is no longer required
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 20:59:20 +02:00
Ivailo Monev
c5dc736536 kate: always use the KMessageWidget animation feature
note that the KMessageWidget animation is a fade effect so
KateFadeEffect was doing what KMessageWidget already has the feature
for, grow/shrink effect is not a thing

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 18:59:38 +02:00
Ivailo Monev
29fe3a31df ksmserver: start the shutdown feedback from KSMShutdownDlg constructor and stop it on reject
ksmserver stops it when the dialog is rejected but the test did not for
example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-20 01:54:00 +02:00
Ivailo Monev
1de2f3e322 ksmserver: make KSMShutdownFeedback::stop() do the same thing as KSMShutdownFeedback::logoutCanceled()
for some reason KSMShutdownFeedback::stop() was not doing anything when the
KWin effect was taking care of the logout effect but KWin also does not
apply the effect to windows other than the one created by ksmserver

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-20 01:32:39 +02:00
Ivailo Monev
62439fb0f9 ksmserver: fix build of tests
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-20 01:16:35 +02:00
Ivailo Monev
e598aa68b9 kwin: remove obsolete decoration slots
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-18 02:32:40 +02:00
Ivailo Monev
4f5703e83b kwin: correct switch cases indentation in oxygenclient header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-18 02:26:10 +02:00
Ivailo Monev
da3cb7452c kmail: use the URL path as CC fallback
the complete URL includes query items

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 02:23:53 +02:00
Ivailo Monev
b01b2a2d42 kioslave: sync preview defaults
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 23:54:02 +02:00
Ivailo Monev
a49d6aaff1 dolphin: implement option for preview icon alpha
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 23:53:34 +02:00
Ivailo Monev
36d3e65630 ksmserver: drop custom logout effect
the effect is very much bound to the window manager (KWin) because if
applications require attention (such as confirmation to cancel any
pending changes) their window or any dialog they pop may have to be
raised, will have to be focused and not be grayed out

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 01:37:02 +02:00
Ivailo Monev
1ed14fe2f7 ksysguard: remove redundant QFontInfo header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 20:59:33 +02:00
Ivailo Monev
740c532dbb kwin: release selection after all components are deleted
effects for example may have their own selection (the startupfeedback
effect used to claim _KDE_STARTUP_FEEDBACK for example) so if other
window manager wants to claim selection/atom owned by KWin effect effects
have to be deinitialized before disowning the window manager selection

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 07:20:38 +02:00
Ivailo Monev
d3da8b90b8 generic: remove redundant QT_CLEAN_NAMESPACE definitions
Katie's namespace is always clean, if there is a namespace issue perhaps
it is not cause of it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 02:07:21 +02:00
Ivailo Monev
4a34d42786 ksmserver: kill window manager before cleanup
the window manager itself may want to do something session management
related (KWin does) and as such ksmserver has to be in operational state
before the window manager is killed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-15 01:54:19 +02:00