note that the image was not loaded from the updated url variable, it was
orient6.jpg that was transformed
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
note that this race that was observed by the author of the test will happen
outside the test - if files are created while the KDirLister is listing
(because an automatic update was issued for example) some files may not be
listed
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
directores such as "lost+found" may not be readable, if the main directory
is not readable an error will be shown still (as it should be).
requires 268eac6790195fe72afeb8525f930e289276eaf9 from kdelibs
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
not sure if I want to keep it tho, I can already see it choke on symlinks
because they are not tracked
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
I found more intelligent way - image format plugins now have mimeTypes()
method to query the supported MIME types (which is wrapped by
KImageIO::mimeTypes()), so if a plugin is not installed for the MIME types
that were previously hardcoded gwenview will no longer suggest to open such
when opening files via the dialog for example
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
the plugin for it accepts only "jpg" as format now and gwenview no longer
has hacks that assume "jpeg", fixes saving of jpg/jpeg images
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
threading it does not help when an image requires gigabytes of memory to
store to begin with (such as when the image is resized to 30000x20000,
it requires a bit less than 2GB of memory and that's because its ARGB),
the document jobs were not thread-safe either
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
shows exactly the same information as the text bellow the image in the
model, see the FIXME in the removed code
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
KUrl has QVariant operator meaning it should be QVariant from QVariant
(i.e. copy constructor) but the testModel() function (see the history model
test) explicitly converts it to KUrl while the StartMainPage class was
converting it to QUrl (via QVariant::toUrl()).
qVariantFromValue<T>() has type before QVariant specialization
side note, try compiling the following (with proper Makefile):
#include <qurl.h>
#include <qvariant.h>
#include <qdebug.h>
#include <kurl.h>
int main (int argc, char** argv)
{
QVariant v(QUrl());
qDebug() << v.type() << v.userType();
QVariant v2(KUrl());
qDebug() << v2.type() << v2.userType();
return 0;
}
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
