Katana_mirror/kde-extraapps
1
0
Fork 0
mirror of https://bitbucket.org/smil3y/kde-extraapps.git synced 2025-02-23 18:32:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

gwenview: remove obsolete format hack

Browse source 
the plugin for it accepts only "jpg" as format now and gwenview no longer
has hacks that assume "jpeg", fixes saving of jpg/jpeg images

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
This commit is contained in:
Ivailo Monev 2023-06-15 03:59:27 +03:00
parent 5d77471e5b
commit 984399a1dc
2 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gwenview/lib/document/loadingdocumentimpl.cpp
View file

@ -191,12 +191,6 @@ struct LoadingDocumentImplPrivate
mFormat = reader.format();
if (mFormat == "jpg") {
// if mFormatHint was "jpg", then mFormat is "jpg", but the rest of
// Gwenview code assumes JPEG images have "jpeg" format.
mFormat = "jpeg";
}
LOG("mFormat" << mFormat);
GV_RETURN_VALUE_IF_FAIL(!mFormat.isEmpty(), false);

6
gwenview/tests/auto/documenttest.cpp
View file

@ -146,12 +146,12 @@ void DocumentTest::testLoad_data()
QTest::addColumn<int>("maxHeight");
testLoad_newRow("test.png", "png");
testLoad_newRow("160382_corrupted.jpeg", "jpeg", MimeTypeUtils::KIND_IMAGE, false, 55);
testLoad_newRow("160382_corrupted.jpeg", "jpg", MimeTypeUtils::KIND_IMAGE, false, 55);
testLoad_newRow("1x10k.png", "png");
testLoad_newRow("1x10k.jpg", "jpeg");
testLoad_newRow("1x10k.jpg", "jpg");
testLoad_newRow("289819_does_not_load.png", "png");
testLoad_newRow("png-with-jpeg-extension.jpg", "png");
testLoad_newRow("jpg-with-gif-extension.gif", "jpeg");
testLoad_newRow("jpg-with-gif-extension.gif", "jpg");
// RAW preview
testLoad_newRow("CANON-EOS350D-02.CR2", "cr2", MimeTypeUtils::KIND_IMAGE, false);