Djam/u-boot
1
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-04-04 12:04:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

net: lwip: Remove error print on failed tx

Browse source 
When an ethernet driver fails to send a frame we print an error in lwIP.
But depending on how often that error is it might significantly delay
transmissions.

For example downloading a big file with the rpi4 spams the console with
'send error: -101', but removing the print makes the file download with
an average speed of ~8.5MiB/s since the packets are retransmitted.

So let's move it to a 'debug' in lwIP and expect ethernet drivers to handle
the failure if it's severe.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
This commit is contained in:
Ilias Apalodimas 2025-03-26 10:28:58 +02:00 • committed by Jerome Forissier
parent 36510e4e41
commit f93b15e706
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/lwip/net-lwip.c
View file

@ -50,7 +50,7 @@ static err_t linkoutput(struct netif *netif, struct pbuf *p)
err = eth_get_ops(udev)->send(udev, pp ? pp : p->payload, p->len);
free(pp);
if (err) {
log_err("send error %d\n", err);
debug("send error %d\n", err);
return ERR_ABRT;
}