From f93b15e70649d0639b71206abf03ca34184a0ed3 Mon Sep 17 00:00:00 2001 From: Ilias Apalodimas Date: Wed, 26 Mar 2025 10:28:58 +0200 Subject: [PATCH] net: lwip: Remove error print on failed tx When an ethernet driver fails to send a frame we print an error in lwIP. But depending on how often that error is it might significantly delay transmissions. For example downloading a big file with the rpi4 spams the console with 'send error: -101', but removing the print makes the file download with an average speed of ~8.5MiB/s since the packets are retransmitted. So let's move it to a 'debug' in lwIP and expect ethernet drivers to handle the failure if it's severe. Signed-off-by: Ilias Apalodimas Reviewed-by: Jerome Forissier --- net/lwip/net-lwip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/lwip/net-lwip.c b/net/lwip/net-lwip.c index cab1dd7d483..4d2aa6099dd 100644 --- a/net/lwip/net-lwip.c +++ b/net/lwip/net-lwip.c @@ -50,7 +50,7 @@ static err_t linkoutput(struct netif *netif, struct pbuf *p) err = eth_get_ops(udev)->send(udev, pp ? pp : p->payload, p->len); free(pp); if (err) { - log_err("send error %d\n", err); + debug("send error %d\n", err); return ERR_ABRT; }