mirror of
https://github.com/ARM-software/arm-trusted-firmware.git
synced 2025-04-13 08:04:27 +00:00
2590e819eb
MPMM is a core-specific microarchitectural feature. It has been present in every Arm core since the Cortex-A510 and has been implemented in exactly the same way. Despite that, it is enabled more like an architectural feature with a top level enable flag. This utilised the identical implementation. This duality has left MPMM in an awkward place, where its enablement should be generic, like an architectural feature, but since it is not, it should also be core-specific if it ever changes. One choice to do this has been through the device tree. This has worked just fine so far, however, recent implementations expose a weakness in that this is rather slow - the device tree has to be read, there's a long call stack of functions with many branches, and system registers are read. In the hot path of PSCI CPU powerdown, this has a significant and measurable impact. Besides it being a rather large amount of code that is difficult to understand. Since MPMM is a microarchitectural feature, its correct placement is in the reset function. The essence of the current enablement is to write CPUPPMCR_EL3.MPMM_EN if CPUPPMCR_EL3.MPMMPINCTL == 0. Replacing the C enablement with an assembly macro in each CPU's reset function achieves the same effect with just a single close branch and a grand total of 6 instructions (versus the old 2 branches and 32 instructions). Having done this, the device tree entry becomes redundant. Should a core that doesn't support MPMM arise, this can cleanly be handled in the reset function. As such, the whole ENABLE_MPMM_FCONF and platform hooks mechanisms become obsolete and are removed. Change-Id: I1d0475b21a1625bb3519f513ba109284f973ffdf Signed-off-by: Boyan Karatotev <boyan.karatotev@arm.com>
83 lines
2.4 KiB
ArmAsm
83 lines
2.4 KiB
ArmAsm
/*
|
|
* Copyright (c) 2023-2025, Arm Limited. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
#include <arch.h>
|
|
#include <asm_macros.S>
|
|
#include <common/bl_common.h>
|
|
#include <cortex_gelas.h>
|
|
#include <cpu_macros.S>
|
|
#include <plat_macros.S>
|
|
|
|
/* Hardware handled coherency */
|
|
#if HW_ASSISTED_COHERENCY == 0
|
|
#error "Gelas must be compiled with HW_ASSISTED_COHERENCY enabled"
|
|
#endif
|
|
|
|
/* 64-bit only core */
|
|
#if CTX_INCLUDE_AARCH32_REGS == 1
|
|
#error "Gelas supports only AArch64. Compile with CTX_INCLUDE_AARCH32_REGS=0"
|
|
#endif
|
|
|
|
#if FEAT_PABANDON == 0
|
|
#error "Gelas must be compiled with FEAT_PABANDON enabled"
|
|
#endif
|
|
|
|
#if ERRATA_SME_POWER_DOWN == 0
|
|
#error "Gelas needs ERRATA_SME_POWER_DOWN=1 to powerdown correctly"
|
|
#endif
|
|
|
|
cpu_reset_prologue cortex_gelas
|
|
|
|
cpu_reset_func_start cortex_gelas
|
|
/* ----------------------------------------------------
|
|
* Disable speculative loads
|
|
* ----------------------------------------------------
|
|
*/
|
|
msr SSBS, xzr
|
|
/* model bug: not cleared on reset */
|
|
sysreg_bit_clear CORTEX_GELAS_CPUPWRCTLR_EL1, \
|
|
CORTEX_GELAS_CPUPWRCTLR_EL1_CORE_PWRDN_BIT
|
|
enable_mpmm
|
|
cpu_reset_func_end cortex_gelas
|
|
|
|
/* ----------------------------------------------------
|
|
* HW will do the cache maintenance while powering down
|
|
* ----------------------------------------------------
|
|
*/
|
|
func cortex_gelas_core_pwr_dwn
|
|
/* ---------------------------------------------------
|
|
* Flip CPU power down bit in power control register.
|
|
* It will be set on powerdown and cleared on wakeup
|
|
* ---------------------------------------------------
|
|
*/
|
|
sysreg_bit_toggle CORTEX_GELAS_CPUPWRCTLR_EL1, \
|
|
CORTEX_GELAS_CPUPWRCTLR_EL1_CORE_PWRDN_BIT
|
|
isb
|
|
ret
|
|
endfunc cortex_gelas_core_pwr_dwn
|
|
|
|
/* ---------------------------------------------
|
|
* This function provides Gelas specific
|
|
* register information for crash reporting.
|
|
* It needs to return with x6 pointing to
|
|
* a list of register names in ascii and
|
|
* x8 - x15 having values of registers to be
|
|
* reported.
|
|
* ---------------------------------------------
|
|
*/
|
|
.section .rodata.cortex_gelas_regs, "aS"
|
|
cortex_gelas_regs: /* The ASCII list of register names to be reported */
|
|
.asciz "imp_cpuectlr_el1", ""
|
|
|
|
func cortex_gelas_cpu_reg_dump
|
|
adr x6, cortex_gelas_regs
|
|
mrs x8, CORTEX_GELAS_IMP_CPUECTLR_EL1
|
|
ret
|
|
endfunc cortex_gelas_cpu_reg_dump
|
|
|
|
declare_cpu_ops cortex_gelas, CORTEX_GELAS_MIDR, \
|
|
cortex_gelas_reset_func, \
|
|
cortex_gelas_core_pwr_dwn
|