mirror of
https://github.com/ARM-software/arm-trusted-firmware.git
synced 2025-04-17 10:04:26 +00:00
0cc7aa8964
At present, the function provided by the translation library to enable
MMU constructs appropriate values for translation library, and programs
them to the right registers. The construction of initial values,
however, is only required once as both the primary and secondaries
program the same values.
Additionally, the MMU-enabling function is written in C, which means
there's an active stack at the time of enabling MMU. On some systems,
like Arm DynamIQ, having active stack while enabling MMU during warm
boot might lead to coherency problems.
This patch addresses both the above problems by:
- Splitting the MMU-enabling function into two: one that sets up
values to be programmed into the registers, and another one that
takes the pre-computed values and writes to the appropriate
registers. With this, the primary effectively calls both functions
to have the MMU enabled, but secondaries only need to call the
latter.
- Rewriting the function that enables MMU in assembly so that it
doesn't use stack.
This patch fixes a bunch of MISRA issues on the way.
Change-Id: I0faca97263a970ffe765f0e731a1417e43fbfc45
Signed-off-by: Jeenu Viswambharan <jeenu.viswambharan@arm.com>
91 lines
1.8 KiB
ArmAsm
91 lines
1.8 KiB
ArmAsm
/*
|
|
* Copyright (c) 2018, ARM Limited and Contributors. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
#include <asm_macros.S>
|
|
#include <assert_macros.S>
|
|
#include <xlat_tables_v2.h>
|
|
|
|
.global enable_mmu_direct_el1
|
|
.global enable_mmu_direct_el3
|
|
|
|
/* Macros to read and write to system register for a given EL. */
|
|
.macro _msr reg_name, el, gp_reg
|
|
msr \reg_name\()_el\()\el, \gp_reg
|
|
.endm
|
|
|
|
.macro _mrs gp_reg, reg_name, el
|
|
mrs \gp_reg, \reg_name\()_el\()\el
|
|
.endm
|
|
|
|
.macro define_mmu_enable_func el
|
|
func enable_mmu_direct_\()el\el
|
|
#if ENABLE_ASSERTIONS
|
|
_mrs x1, sctlr, \el
|
|
tst x1, #SCTLR_M_BIT
|
|
ASM_ASSERT(eq)
|
|
#endif
|
|
|
|
/* Invalidate TLB entries */
|
|
.if \el == 1
|
|
TLB_INVALIDATE(vmalle1)
|
|
.else
|
|
.if \el == 3
|
|
TLB_INVALIDATE(alle3)
|
|
.else
|
|
.error "EL must be 1 or 3"
|
|
.endif
|
|
.endif
|
|
|
|
mov x7, x0
|
|
ldr x0, =mmu_cfg_params
|
|
|
|
/* MAIR */
|
|
ldr w1, [x0, #(MMU_CFG_MAIR0 << 2)]
|
|
_msr mair, \el, x1
|
|
|
|
/* TCR */
|
|
ldr w2, [x0, #(MMU_CFG_TCR << 2)]
|
|
_msr tcr, \el, x2
|
|
|
|
/* TTBR */
|
|
ldr w3, [x0, #(MMU_CFG_TTBR0_LO << 2)]
|
|
ldr w4, [x0, #(MMU_CFG_TTBR0_HI << 2)]
|
|
orr x3, x3, x4, lsl #32
|
|
_msr ttbr0, \el, x3
|
|
|
|
/*
|
|
* Ensure all translation table writes have drained into memory, the TLB
|
|
* invalidation is complete, and translation register writes are
|
|
* committed before enabling the MMU
|
|
*/
|
|
dsb ish
|
|
isb
|
|
|
|
/* Set and clear required fields of SCTLR */
|
|
_mrs x4, sctlr, \el
|
|
mov_imm x5, SCTLR_WXN_BIT | SCTLR_C_BIT | SCTLR_M_BIT
|
|
orr x4, x4, x5
|
|
|
|
/* Additionally, amend SCTLR fields based on flags */
|
|
bic x5, x4, #SCTLR_C_BIT
|
|
tst x7, #DISABLE_DCACHE
|
|
csel x4, x5, x4, ne
|
|
|
|
_msr sctlr, \el, x4
|
|
isb
|
|
|
|
ret
|
|
endfunc enable_mmu_direct_\()el\el
|
|
.endm
|
|
|
|
/*
|
|
* Define MMU-enabling functions for EL1 and EL3:
|
|
*
|
|
* enable_mmu_direct_el1
|
|
* enable_mmu_direct_el3
|
|
*/
|
|
define_mmu_enable_func 1
|
|
define_mmu_enable_func 3
|