mirror of
https://github.com/ARM-software/arm-trusted-firmware.git
synced 2025-04-16 09:34:18 +00:00
09d40e0e08
Enforce full include path for includes. Deprecate old paths.
The following folders inside include/lib have been left unchanged:
- include/lib/cpus/${ARCH}
- include/lib/el3_runtime/${ARCH}
The reason for this change is that having a global namespace for
includes isn't a good idea. It defeats one of the advantages of having
folders and it introduces problems that are sometimes subtle (because
you may not know the header you are actually including if there are two
of them).
For example, this patch had to be created because two headers were
called the same way: e0ea0928d5 ("Fix gpio includes of mt8173 platform
to avoid collision."). More recently, this patch has had similar
problems: 46f9b2c3a2 ("drivers: add tzc380 support").
This problem was introduced in commit 4ecca33988 ("Move include and
source files to logical locations"). At that time, there weren't too
many headers so it wasn't a real issue. However, time has shown that
this creates problems.
Platforms that want to preserve the way they include headers may add the
removed paths to PLAT_INCLUDES, but this is discouraged.
Change-Id: I39dc53ed98f9e297a5966e723d1936d6ccf2fc8f
Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com>
102 lines
2.2 KiB
C
102 lines
2.2 KiB
C
/*
|
|
* Copyright (c) 2017-2018, ARM Limited and Contributors. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
/* Runtime firmware routines to report errata status for the current CPU. */
|
|
|
|
#include <assert.h>
|
|
#include <stdbool.h>
|
|
|
|
#include <arch_helpers.h>
|
|
#include <common/debug.h>
|
|
#include <lib/cpus/errata_report.h>
|
|
#include <lib/el3_runtime/cpu_data.h>
|
|
#include <lib/spinlock.h>
|
|
#include <lib/utils.h>
|
|
|
|
#ifdef IMAGE_BL1
|
|
# define BL_STRING "BL1"
|
|
#elif defined(AARCH64) && defined(IMAGE_BL31)
|
|
# define BL_STRING "BL31"
|
|
#elif defined(AARCH32) && defined(IMAGE_BL32)
|
|
# define BL_STRING "BL32"
|
|
#elif defined(IMAGE_BL2) && BL2_AT_EL3
|
|
# define BL_STRING "BL2"
|
|
#else
|
|
# error This image should not be printing errata status
|
|
#endif
|
|
|
|
/* Errata format: BL stage, CPU, errata ID, message */
|
|
#define ERRATA_FORMAT "%s: %s: CPU workaround for %s was %s\n"
|
|
|
|
/*
|
|
* Returns whether errata needs to be reported. Passed arguments are private to
|
|
* a CPU type.
|
|
*/
|
|
int errata_needs_reporting(spinlock_t *lock, uint32_t *reported)
|
|
{
|
|
bool report_now;
|
|
|
|
/* If already reported, return false. */
|
|
if (*reported != 0U)
|
|
return 0;
|
|
|
|
/*
|
|
* Acquire lock. Determine whether status needs reporting, and then mark
|
|
* report status to true.
|
|
*/
|
|
spin_lock(lock);
|
|
report_now = (*reported == 0U);
|
|
if (report_now)
|
|
*reported = 1;
|
|
spin_unlock(lock);
|
|
|
|
return report_now;
|
|
}
|
|
|
|
/*
|
|
* Print errata status message.
|
|
*
|
|
* Unknown: WARN
|
|
* Missing: WARN
|
|
* Applied: INFO
|
|
* Not applied: VERBOSE
|
|
*/
|
|
void errata_print_msg(unsigned int status, const char *cpu, const char *id)
|
|
{
|
|
/* Errata status strings */
|
|
static const char *const errata_status_str[] = {
|
|
[ERRATA_NOT_APPLIES] = "not applied",
|
|
[ERRATA_APPLIES] = "applied",
|
|
[ERRATA_MISSING] = "missing!"
|
|
};
|
|
static const char *const __unused bl_str = BL_STRING;
|
|
const char *msg __unused;
|
|
|
|
|
|
assert(status < ARRAY_SIZE(errata_status_str));
|
|
assert(cpu != NULL);
|
|
assert(id != NULL);
|
|
|
|
msg = errata_status_str[status];
|
|
|
|
switch (status) {
|
|
case ERRATA_NOT_APPLIES:
|
|
VERBOSE(ERRATA_FORMAT, bl_str, cpu, id, msg);
|
|
break;
|
|
|
|
case ERRATA_APPLIES:
|
|
INFO(ERRATA_FORMAT, bl_str, cpu, id, msg);
|
|
break;
|
|
|
|
case ERRATA_MISSING:
|
|
WARN(ERRATA_FORMAT, bl_str, cpu, id, msg);
|
|
break;
|
|
|
|
default:
|
|
WARN(ERRATA_FORMAT, bl_str, cpu, id, "unknown");
|
|
break;
|
|
}
|
|
}
|