mirror of
https://github.com/rpm-software-management/tito.git
synced 2025-02-24 04:32:46 +00:00
a0d0f859c7
03255001d6 moved commands module to src/tito/compat.py to handle
differences between python2 and python3, but missed a bit that
did not show up in unit or functional tests.
Fix those occurences and add unit test to detect the regression.
101 lines
4.2 KiB
Python
101 lines
4.2 KiB
Python
#
|
|
# Copyright (c) 2008-2014 Red Hat, Inc.
|
|
#
|
|
# This software is licensed to you under the GNU General Public License,
|
|
# version 2 (GPLv2). There is NO WARRANTY for this software, express or
|
|
# implied, including the implied warranties of MERCHANTABILITY or FITNESS
|
|
# FOR A PARTICULAR PURPOSE. You should have received a copy of GPLv2
|
|
# along with this software; if not, see
|
|
# http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
|
|
#
|
|
# Red Hat trademarks are not licensed under GPLv2. No permission is
|
|
# granted to use or replicate Red Hat trademarks that are incorporated
|
|
# in this software or its documentation.
|
|
|
|
"""
|
|
Use pep8 to check for errors or deprecations that can cause Python 3 to fail.
|
|
source: https://github.com/jcrocholl/pep8
|
|
docs: http://pep8.readthedocs.org/en/latest/intro.html
|
|
|
|
Python 3 is picky about indentation:
|
|
http://docs.python.org/3.3/reference/lexical_analysis.html
|
|
"""
|
|
|
|
import pep8
|
|
from unit.fixture import *
|
|
|
|
|
|
class TestPep8(TitoUnitTestFixture):
|
|
def setUp(self):
|
|
TitoUnitTestFixture.setUp(self)
|
|
|
|
def test_conformance(self):
|
|
tests = [
|
|
# http://pep8.readthedocs.org/en/latest/intro.html#error-codes
|
|
'E101', # indentation contains mixed spaces and tabs
|
|
'E111', # indentation is not a multiple of four
|
|
'E112', # expected an indented block
|
|
'E113', # unexpected indentation
|
|
'E121', # continuation line indentation is not a multiple of four
|
|
'E122', # continuation line missing indentation or outdented
|
|
'E126', # continuation line over-indented for hanging indent
|
|
'E2', # whitespace errors
|
|
'E3', # blank line errors
|
|
'E4', # import errors
|
|
'E502', # the backslash is redundant between brackets
|
|
'E7', # statement errors
|
|
'E9', # runtime errors (SyntaxError, IndentationError, IOError)
|
|
'W1', # indentation warnings
|
|
'W2', # whitespace warnings
|
|
'W3', # blank line warnings
|
|
'W6', # deprecated features
|
|
]
|
|
|
|
try:
|
|
checker = pep8.StyleGuide(select=tests, paths=[REPO_DIR])
|
|
result = checker.check_files().total_errors
|
|
except AttributeError:
|
|
# We don't have pep8.StyleGuide, so we must be
|
|
# using pep8 older than git tag 1.1-72-gf20d656.
|
|
os.chdir(REPO_DIR)
|
|
checks = ','.join(tests)
|
|
cmd = "pep8 --select=%s %s | wc -l" % (checks, '.')
|
|
result = int(getoutput(cmd))
|
|
|
|
self.assertEqual(result, 0,
|
|
"Found PEP8 errors that may break your code in Python 3.")
|
|
|
|
|
|
class UglyHackishTest(TitoUnitTestFixture):
|
|
def setUp(self):
|
|
TitoUnitTestFixture.setUp(self)
|
|
os.chdir(REPO_DIR)
|
|
|
|
def test_exceptions_2_dot_4(self):
|
|
# detect 'except rpm.error as e:'
|
|
regex = "'^[[:space:]]*except .* as .*:'"
|
|
cmd = "find . -type f -regex '.*\.py$' -exec egrep %s {} + | wc -l" % regex
|
|
result = int(getoutput(cmd))
|
|
self.assertEqual(result, 0, "Found except clause not supported in Python 2.4")
|
|
|
|
def test_exceptions_3(self):
|
|
# detect 'except rpm.error, e:'
|
|
regex = "'^[[:space:]]*except [^,]+,[[:space:]]*[[:alpha:]]+:'"
|
|
cmd = "find . -type f -regex '.*\.py$' -exec egrep %s {} + | wc -l" % regex
|
|
result = int(getoutput(cmd))
|
|
self.assertEqual(result, 0, "Found except clause not supported in Python 3")
|
|
|
|
def test_import_commands(self):
|
|
cmd = "find . -type f -regex '.*\.py$' -exec egrep '^(import|from) commands\.' {} + | grep -v 'compat\.py' | wc -l"
|
|
result = int(getoutput(cmd))
|
|
self.assertEqual(result, 0, "Found commands module (not supported in Python 3)")
|
|
|
|
def test_use_commands(self):
|
|
cmd = "find . -type f -regex '.*\.py$' -exec egrep 'commands\.' {} + | grep -v 'compat\.py' | wc -l"
|
|
result = int(getoutput(cmd))
|
|
self.assertEqual(result, 0, "Found commands module (not supported in Python 3)")
|
|
|
|
def test_print_function(self):
|
|
cmd = "find . -type f -regex '.*\.py$' -exec grep '^[[:space:]]*print .*' {} + | wc -l"
|
|
result = int(getoutput(cmd))
|
|
self.assertEqual(result, 0, "Found print statement (not supported in Python 3)")
|