3892359 changed builder args to always be arrays, so concatenation of
rpmbuild options with other strings then failed.
File "/usr/lib/python2.7/site-packages/tito/release/main.py", line 530, in _koji_release
builder.srpm(dist=disttag)
File "/usr/lib/python2.7/site-packages/tito/builder/main.py", line 210, in srpm
rpmbuild_options = self.rpmbuild_options + self._scl_to_rpmbuild_option()
TypeError: can only concatenate list (not "str") to list
Change builder args to be joined by a single space, allowing multiple
arguments to be passed in.
Merge commits rarely add value to the RPM changelog. This patch removes
lines from the changelog that begin with "Merge pull request" or "Merge
remote-tracking" or "Merge branch". The old behavior can be restored
by setting "keep_merge_commits" to 1 or true.
This patch fixes an issue where all builds for any given subproject were
appearing in MEAD as builds for the top-level POM. Consequently, trying
to build and tag different subprojects did not work because Brew/Koji
saw the build as redundant since the version was populated from the
parent POM.
The --local flag on a git clone creates hardlinks to the files under
.git/objects. In theory this is nice, but in practice it creates the
potential for errors in environments where hardlinking isn't a
possibility (e.g. across filesystems).
This means that adding a non-Maven generated tarball is of no use to
the release process. Set Tito to fail if Maven isn't configured to
yield a tarball via the assembly plugin.
Maven doesn't have any ability that I can find to run a build against a
specific git ref. Instead, we create a temporary checkout based on the
working directory, switch that checkout to the required ref, and then
build.
These tests began failing after a correction to another test. The
other test had been patching the error_out function without unpatching
it and thus polluted the test environment.
Also reset to a known directory at the beginning of the common tests so
that we don't start in a directory that has since been unlinked.
The Maven-generated tar file deviates from the spec in several places.
Fields are padded out with spaces instead of NUL bytes and the user and
group ID are left empty.
This patch alters the tar module to correct these issues and ensures a
consistent unchanging fingerprint for the archive by setting the mtime
on the files to the modified time of the commit.
