diff --git a/src/tito/builder/submodule_aware_builder.py b/src/tito/builder/submodule_aware_builder.py index cd047ee..70d96dd 100644 --- a/src/tito/builder/submodule_aware_builder.py +++ b/src/tito/builder/submodule_aware_builder.py @@ -155,7 +155,7 @@ class SubmoduleAwareBuilder(Builder): for archive in self._submodule_archives( relative_git_dir, submodule_prefix, submodule_commit, submodule_tar_file, submodule_dir - ): + ): yield archive def create_tgz(self, git_root, prefix, commit, relative_dir, dest_tgz): diff --git a/src/tito/common.py b/src/tito/common.py index 8c9fe89..b0a63e8 100644 --- a/src/tito/common.py +++ b/src/tito/common.py @@ -363,7 +363,7 @@ def run_command_print(command, print_on_success=False): def run_subprocess(p): - while(True): + while True: retcode = p.poll() line = p.stdout.readline() if len(line) > 0: diff --git a/src/tito/tar.py b/src/tito/tar.py index 268f30d..8ed0e39 100644 --- a/src/tito/tar.py +++ b/src/tito/tar.py @@ -258,7 +258,7 @@ class TarFixer(object): # Delete the old checksum since it's now invalid and we don't want even # an inadvertent reference to it. - del(chunk_props['checksum']) + del chunk_props['checksum'] # Remove the trailing NUL byte(s) on the end of members for k, v in chunk_props.items():