From 05e3b80205185d22f77b2ad098e5160dd2d9fcd5 Mon Sep 17 00:00:00 2001
From: Devan Goodwin <dgoodwin@redhat.com>
Date: Thu, 9 Jan 2014 15:20:04 -0400
Subject: [PATCH] Extract version/release in external source builder.

---
 src/tito/builder.py                   | 32 ++++++++++++++++++++++++++-
 test/functional/multiproject_tests.py |  4 ++--
 2 files changed, 33 insertions(+), 3 deletions(-)

diff --git a/src/tito/builder.py b/src/tito/builder.py
index 5d30c66..d0e51b1 100644
--- a/src/tito/builder.py
+++ b/src/tito/builder.py
@@ -1127,6 +1127,30 @@ class ExternalSourceBuilder(ConfigObject, BuilderBase):
         self.manual_sources = [os.path.abspath(s) for s in kwargs['sources']]
         debug("Got sources: %s" % self.manual_sources)
 
+    def _get_version_and_release(self):
+        """
+        Get the version and release from the builder.
+        Sources are configured at this point.
+        """
+        # Assuming source0 is a tar.gz we can extract a version and possibly
+        # release from:
+        base_name = os.path.basename(self.sources[0])
+        debug("Extracting version/release from: %s" % base_name)
+
+        # usually a source tarball won't have a release, that is an RPM concept.
+        # Don't forget dist!
+        release = "1%{?dist}"
+
+        # Example filename: tito-0.4.18.tar.gz:
+        simple_version_re = re.compile(".*-(.*).(tar.gz|tgz|zip|bz2)")
+        match = re.search(simple_version_re, base_name)
+        if match:
+            version = match.group(1)
+        else:
+            error_out("Unable to determine version from file: %s" % base_name)
+
+        return (version, release)
+
     def tgz(self):
         self.ran_tgz = True
         self._create_build_dirs()
@@ -1160,6 +1184,12 @@ class ExternalSourceBuilder(ConfigObject, BuilderBase):
         version_regex = re.compile("^(version:\s*)(.+)$", re.IGNORECASE)
         release_regex = re.compile("^(release:\s*)(.+)$", re.IGNORECASE)
 
+        (version, release) = self._get_version_and_release()
+        print("Building version: %s" % version)
+        print("Building release: %s" % release)
+        replacements.append((version_regex, "Version: %s\n" % version))
+        replacements.append((release_regex, "Release: %s\n" % release))
+
         self.replace_in_spec(replacements)
 
         # Copy every normal file in the directory we ran tito from. This
@@ -1193,7 +1223,7 @@ class ExternalSourceBuilder(ConfigObject, BuilderBase):
                 match = re.match(line_regex, line)
                 if match:
                     line = new_line
-                out_f.write(line)
+            out_f.write(line)
 
         in_f.close()
         out_f.close()
diff --git a/test/functional/multiproject_tests.py b/test/functional/multiproject_tests.py
index c7f68bf..76198e2 100644
--- a/test/functional/multiproject_tests.py
+++ b/test/functional/multiproject_tests.py
@@ -89,9 +89,9 @@ class ExternalSourceBuilderTests(TitoGitTestFixture):
         tito('build --rpm --output=%s --no-cleanup --source=%s --debug' %
                 (self.output_dir, self.source_filename))
         self.assertTrue(os.path.exists(
-            os.path.join(self.output_dir, 'extsrc-0.0.1-1.fc20.src.rpm')))
+            os.path.join(self.output_dir, 'extsrc-0.0.2-1.fc20.src.rpm')))
         self.assertTrue(os.path.exists(
-            os.path.join(self.output_dir, 'noarch/extsrc-0.0.1-1.fc20.noarch.rpm')))
+            os.path.join(self.output_dir, 'noarch/extsrc-0.0.2-1.fc20.noarch.rpm')))
 
     # test_tag_rejected