2015-03-25 12:22:45 +01:00
|
|
|
#!/usr/bin/python
|
|
|
|
#
|
|
|
|
# CGI script to handle file updates for the rpms git repository. There
|
|
|
|
# is nothing really complex here other than tedious checking of our
|
|
|
|
# every step along the way...
|
|
|
|
#
|
|
|
|
# License: GPL
|
|
|
|
|
|
|
|
import os
|
|
|
|
import sys
|
|
|
|
import cgi
|
|
|
|
import tempfile
|
|
|
|
import grp
|
|
|
|
import pwd
|
|
|
|
import syslog
|
|
|
|
import smtplib
|
Upload files to new and old paths + remove email
=============
distgit: Upload files to both the new and old path
Currently, the CGI script is set to upload files:
- to the old path if the upload uses md5
- to the new path if the upload uses sha512
The old path is as follows:
/%(srpmname)s/%(filename)s/%(hash)s/%(filename)s
The new path is:
/%(srpmname)s/%(filename)s/%(hashtype)s/%(hash)s/%(filename)s
This was meant to ensure compatibility with current fedpkg which
always downloads from the old path, but will eventually download from
the new path when we move to sha512.
However, working more on this, I now think it would make for a smoother
transition if we instead always stored the files at the new path, but
just hardlinked to the old path if the upload is using md5.
This is what this patch achieves.
With this deployed in production, fedpkg could be patched to try
downloading from the new path, and fallback to the old one if necessary,
which decouples the migration to the new path from the migration to the
new hash.
=============
distgit: Ensure the folder exists
We can't hard link the file if the folder containing the link
destination does not exist.
Hurray for testing in staging!
=============
distgit: os.link fails if the dest already exists
=============
distgit: And so does os.makedirs
=============
distgit: Actually hardlink over the existing source at the old path
Without this, the file could exist at both the old and new path, taking
the space on the disk twice.
This forces a hardlink if the file already existed at the old path.
=============
Remove the lookaside email hook (rely on fedmsg now).
2015-06-03 13:42:57 +02:00
|
|
|
import errno
|
2015-03-25 12:22:45 +01:00
|
|
|
|
|
|
|
import fedmsg
|
|
|
|
import fedmsg.config
|
|
|
|
|
2015-03-25 14:09:05 +01:00
|
|
|
from ConfigParser import ConfigParser
|
|
|
|
|
2015-03-25 12:22:45 +01:00
|
|
|
from email import Header, Utils
|
|
|
|
try:
|
|
|
|
from email.mime.text import MIMEText
|
|
|
|
except ImportError:
|
|
|
|
from email.MIMEText import MIMEText
|
|
|
|
|
|
|
|
import hashlib
|
|
|
|
|
|
|
|
# Reading buffer size
|
|
|
|
BUFFER_SIZE = 4096
|
|
|
|
|
|
|
|
# We check modules exist from this dircetory
|
2015-03-26 14:39:39 +01:00
|
|
|
GITREPO = '/var/lib/dist-git/git/rpms'
|
2015-03-25 12:22:45 +01:00
|
|
|
|
|
|
|
# Lookaside cache directory
|
2015-03-26 14:39:39 +01:00
|
|
|
CACHE_DIR = '/var/lib/dist-git/cache/lookaside/pkgs'
|
2015-03-25 12:22:45 +01:00
|
|
|
|
|
|
|
# Fedora Packager Group
|
|
|
|
PACKAGER_GROUP = 'packager'
|
|
|
|
|
2015-03-25 14:09:05 +01:00
|
|
|
# dist git configuration file
|
|
|
|
CONFIG_FILE = "/etc/dist-git/dist-git.conf"
|
|
|
|
|
2015-03-25 12:22:45 +01:00
|
|
|
def send_error(text):
|
|
|
|
print text
|
|
|
|
sys.exit(1)
|
|
|
|
|
|
|
|
def check_form(form, var):
|
|
|
|
ret = form.getvalue(var, None)
|
|
|
|
if ret is None:
|
|
|
|
send_error('Required field "%s" is not present.' % var)
|
|
|
|
if isinstance(ret, list):
|
|
|
|
send_error('Multiple values given for "%s". Aborting.' % var)
|
|
|
|
return ret
|
|
|
|
|
|
|
|
def check_auth(username):
|
|
|
|
authenticated = False
|
|
|
|
try:
|
|
|
|
if username in grp.getgrnam(PACKAGER_GROUP)[3]:
|
|
|
|
authenticated = True
|
|
|
|
except KeyError:
|
|
|
|
pass
|
|
|
|
return authenticated
|
|
|
|
|
|
|
|
def main():
|
2015-03-25 14:09:05 +01:00
|
|
|
config = ConfigParser()
|
|
|
|
config.read(CONFIG_FILE)
|
|
|
|
|
2015-04-10 11:20:13 +02:00
|
|
|
EMAIL_DOMAIN = _get_conf(config, "notifications", "email_domain", "")
|
|
|
|
PKG_OWNER_EMAILS = _get_conf(config, "notifications", "pkg_owner_emails", "")
|
2015-03-25 14:09:05 +01:00
|
|
|
|
2015-03-25 12:22:45 +01:00
|
|
|
os.umask(002)
|
|
|
|
|
|
|
|
username = os.environ.get('SSL_CLIENT_S_DN_CN', None)
|
|
|
|
if not check_auth(username):
|
|
|
|
print 'Status: 403 Forbidden'
|
|
|
|
print 'Content-type: text/plain'
|
|
|
|
print
|
|
|
|
print 'You must connect with a valid certificate and be in the %s group to upload.' % PACKAGER_GROUP
|
|
|
|
sys.exit(0)
|
|
|
|
|
|
|
|
print 'Content-Type: text/plain'
|
|
|
|
print
|
|
|
|
|
|
|
|
assert os.environ['REQUEST_URI'].split('/')[1] == 'repo'
|
|
|
|
|
|
|
|
form = cgi.FieldStorage()
|
|
|
|
name = check_form(form, 'name')
|
|
|
|
|
|
|
|
# Search for the file hash, start with stronger hash functions
|
|
|
|
if form.has_key('sha512sum'):
|
|
|
|
checksum = check_form(form, 'sha512sum')
|
|
|
|
hash_type = "sha512"
|
|
|
|
|
|
|
|
elif form.has_key('md5sum'):
|
|
|
|
# Fallback on md5, as it's what we currently use
|
|
|
|
checksum = check_form(form, 'md5sum')
|
|
|
|
hash_type = "md5"
|
|
|
|
|
|
|
|
else:
|
|
|
|
send_error('Required checksum is not present.')
|
|
|
|
|
|
|
|
action = None
|
|
|
|
upload_file = None
|
|
|
|
filename = None
|
|
|
|
|
|
|
|
# Is this a submission or a test?
|
|
|
|
# in a test, we don't get a file, just a filename.
|
|
|
|
# In a submission, we don;t get a filename, just the file.
|
|
|
|
if form.has_key('filename'):
|
|
|
|
action = 'check'
|
|
|
|
filename = check_form(form, 'filename')
|
|
|
|
filename = os.path.basename(filename)
|
|
|
|
print >> sys.stderr, '[username=%s] Checking file status: NAME=%s FILENAME=%s %sSUM=%s' % (username, name, filename, hash_type.upper(), checksum)
|
|
|
|
else:
|
|
|
|
action = 'upload'
|
|
|
|
if form.has_key('file'):
|
|
|
|
upload_file = form['file']
|
|
|
|
if not upload_file.file:
|
|
|
|
send_error('No file given for upload. Aborting.')
|
|
|
|
filename = os.path.basename(upload_file.filename)
|
|
|
|
else:
|
|
|
|
send_error('Required field "file" is not present.')
|
|
|
|
print >> sys.stderr, '[username=%s] Processing upload request: NAME=%s FILENAME=%s %sSUM=%s' % (username, name, filename, hash_type.upper(), checksum)
|
|
|
|
|
|
|
|
module_dir = os.path.join(CACHE_DIR, name)
|
|
|
|
hash_dir = os.path.join(module_dir, filename, hash_type, checksum)
|
|
|
|
msgpath = os.path.join(name, module_dir, filename, hash_type, checksum, filename)
|
|
|
|
|
2015-03-26 14:39:39 +01:00
|
|
|
unwanted_prefix = '/var/lib/dist-git/cache/lookaside/pkgs/'
|
2015-03-25 12:22:45 +01:00
|
|
|
if msgpath.startswith(unwanted_prefix):
|
|
|
|
msgpath = msgpath[len(unwanted_prefix):]
|
|
|
|
|
|
|
|
# first test if the module really exists
|
|
|
|
git_dir = os.path.join(GITREPO, '%s.git' % name)
|
|
|
|
if not os.path.isdir(git_dir):
|
|
|
|
print >> sys.stderr, '[username=%s] Unknown module: %s' % (username, name)
|
|
|
|
send_error('Module "%s" does not exist!' % name)
|
|
|
|
|
|
|
|
# try to see if we already have this file...
|
|
|
|
dest_file = os.path.join(hash_dir, filename)
|
|
|
|
if os.path.exists(dest_file):
|
|
|
|
if action == 'check':
|
|
|
|
print 'Available'
|
|
|
|
else:
|
|
|
|
upload_file.file.close()
|
|
|
|
dest_file_stat = os.stat(dest_file)
|
|
|
|
print 'File %s already exists' % filename
|
|
|
|
print 'File: %s Size: %d' % (dest_file, dest_file_stat.st_size)
|
|
|
|
sys.exit(0)
|
|
|
|
elif action == 'check':
|
|
|
|
print 'Missing'
|
|
|
|
sys.exit(0)
|
|
|
|
|
|
|
|
# check that all directories are in place
|
|
|
|
if not os.path.isdir(module_dir):
|
|
|
|
os.makedirs(module_dir, 02775)
|
|
|
|
|
|
|
|
# grab a temporary filename and dump our file in there
|
|
|
|
tempfile.tempdir = module_dir
|
|
|
|
tmpfile = tempfile.mkstemp(checksum)[1]
|
|
|
|
tmpfd = open(tmpfile, 'w')
|
|
|
|
|
|
|
|
# now read the whole file in
|
|
|
|
m = getattr(hashlib, hash_type)()
|
|
|
|
filesize = 0
|
|
|
|
while True:
|
|
|
|
data = upload_file.file.read(BUFFER_SIZE)
|
|
|
|
if not data:
|
|
|
|
break
|
|
|
|
tmpfd.write(data)
|
|
|
|
m.update(data)
|
|
|
|
filesize += len(data)
|
|
|
|
|
|
|
|
# now we're done reading, check the checksum of what we got
|
|
|
|
tmpfd.close()
|
|
|
|
check_checksum = m.hexdigest()
|
|
|
|
if checksum != check_checksum:
|
|
|
|
os.unlink(tmpfile)
|
|
|
|
send_error("%s check failed. Received %s instead of %s." % (hash_type.upper(), check_checksum, checksum))
|
|
|
|
|
|
|
|
# wow, even the checksum matches. make sure full path is valid now
|
|
|
|
if not os.path.isdir(hash_dir):
|
|
|
|
os.makedirs(hash_dir, 02775)
|
|
|
|
print >> sys.stderr, '[username=%s] mkdir %s' % (username, hash_dir)
|
|
|
|
|
|
|
|
os.rename(tmpfile, dest_file)
|
|
|
|
os.chmod(dest_file, 0644)
|
|
|
|
|
|
|
|
print >> sys.stderr, '[username=%s] Stored %s (%d bytes)' % (username, dest_file, filesize)
|
|
|
|
print 'File %s size %d %s %s stored OK' % (filename, filesize, hash_type.upper(), checksum)
|
Upload files to new and old paths + remove email
=============
distgit: Upload files to both the new and old path
Currently, the CGI script is set to upload files:
- to the old path if the upload uses md5
- to the new path if the upload uses sha512
The old path is as follows:
/%(srpmname)s/%(filename)s/%(hash)s/%(filename)s
The new path is:
/%(srpmname)s/%(filename)s/%(hashtype)s/%(hash)s/%(filename)s
This was meant to ensure compatibility with current fedpkg which
always downloads from the old path, but will eventually download from
the new path when we move to sha512.
However, working more on this, I now think it would make for a smoother
transition if we instead always stored the files at the new path, but
just hardlinked to the old path if the upload is using md5.
This is what this patch achieves.
With this deployed in production, fedpkg could be patched to try
downloading from the new path, and fallback to the old one if necessary,
which decouples the migration to the new path from the migration to the
new hash.
=============
distgit: Ensure the folder exists
We can't hard link the file if the folder containing the link
destination does not exist.
Hurray for testing in staging!
=============
distgit: os.link fails if the dest already exists
=============
distgit: And so does os.makedirs
=============
distgit: Actually hardlink over the existing source at the old path
Without this, the file could exist at both the old and new path, taking
the space on the disk twice.
This forces a hardlink if the file already existed at the old path.
=============
Remove the lookaside email hook (rely on fedmsg now).
2015-06-03 13:42:57 +02:00
|
|
|
|
|
|
|
# Add the file to the old path, where fedpkg is currently looking for it
|
|
|
|
if hash_type == "md5":
|
|
|
|
old_dir = os.path.join(module_dir, filename, checksum)
|
|
|
|
old_path = os.path.join(old_dir, filename)
|
|
|
|
|
|
|
|
try:
|
|
|
|
os.makedirs(old_dir)
|
|
|
|
|
|
|
|
except OSError as e:
|
|
|
|
if e.errno != errno.EEXIST:
|
|
|
|
raise e
|
|
|
|
|
|
|
|
try:
|
|
|
|
os.link(dest_file, old_path)
|
|
|
|
|
|
|
|
except OSError as e:
|
|
|
|
if e.errno != errno.EEXIST:
|
|
|
|
raise e
|
|
|
|
|
|
|
|
# The file already existed at the old path, hardlink over it
|
|
|
|
os.unlink(old_path)
|
|
|
|
os.link(old_path)
|
2015-03-25 12:22:45 +01:00
|
|
|
|
|
|
|
# Emit a fedmsg message. Load the config to talk to the fedmsg-relay.
|
|
|
|
try:
|
|
|
|
config = fedmsg.config.load_config([], None)
|
|
|
|
config['active'] = True
|
|
|
|
config['endpoints']['relay_inbound'] = config['relay_inbound']
|
|
|
|
fedmsg.init(name="relay_inbound", cert_prefix="lookaside", **config)
|
|
|
|
|
|
|
|
topic = "lookaside.new"
|
|
|
|
msg = dict(name=name, md5sum=checksum, filename=filename.split('/')[-1],
|
|
|
|
agent=username, path=msgpath)
|
|
|
|
fedmsg.publish(modname="git", topic=topic, msg=msg)
|
|
|
|
except Exception as e:
|
|
|
|
print "Error with fedmsg", str(e)
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
main()
|