add some quotes to make shellcheck happier

This commit is contained in:
Brian Stinson 2019-04-16 13:06:51 -05:00
parent fd37ab5810
commit 9857597bf6

View file

@ -117,7 +117,7 @@ fi
# should go into a function section at some point # should go into a function section at some point
weakHashDetection () { weakHashDetection () {
strHash=${1}; strHash=${1};
case $((`echo ${strHash}|wc -m` - 1 )) in case $((`echo "${strHash}"|wc -m` - 1 )) in
128) 128)
hashBin='sha512sum' hashBin='sha512sum'
;; ;;
@ -186,10 +186,10 @@ fi
while read -r fsha fname ; do while read -r fsha fname ; do
if [ ".${fsha}" = ".da39a3ee5e6b4b0d3255bfef95601890afd80709" ]; then if [ ".${fsha}" = ".da39a3ee5e6b4b0d3255bfef95601890afd80709" ]; then
# zero byte file # zero byte file
touch ${fname} touch "${fname}"
else else
if [ ${CHECK} -eq 1 ]; then if [ ${CHECK} -eq 1 ]; then
hashType=$(weakHashDetection ${fsha}) hashType=$(weakHashDetection "${fsha}")
if [ "${hashType}" == "unknown" ]; then if [ "${hashType}" == "unknown" ]; then
echo 'Failure: Hash type unknown.' >&2 echo 'Failure: Hash type unknown.' >&2
exit 1; exit 1;
@ -203,15 +203,15 @@ while read -r fsha fname ; do
fi fi
if [ -e ${fname} -a ${CHECK} -eq 1 ]; then if [ -e ${fname} -a ${CHECK} -eq 1 ]; then
# check hash sum and force download if wrong # check hash sum and force download if wrong
downsum=$(${hashType} ${fname} | awk '{print $1}') downsum=$(${hashType} "${fname}" | awk '{print $1}')
if [ "${fsha}" != "${downsum}" ]; then if [ "${fsha}" != "${downsum}" ]; then
rm -f ${fname} rm -f "${fname}"
fi fi
fi fi
if [ ! -e "${fname}" ]; then if [ ! -e "${fname}" ]; then
for br in "${branches[@]}" for br in "${branches[@]}"
do do
br=$(echo ${br}| sed -e s'|remotes/origin/||') br=$(echo "${br}"| sed -e s'|remotes/origin/||')
url="${SURL}/${pn}/${br}/${fsha}" url="${SURL}/${pn}/${br}/${fsha}"
echo "Retrieving ${url}" echo "Retrieving ${url}"
curl -L ${QUIET} -f "${url}" -o "${fname}" && break curl -L ${QUIET} -f "${url}" -o "${fname}" && break
@ -220,9 +220,9 @@ while read -r fsha fname ; do
echo "${fname} exists. skipping" echo "${fname} exists. skipping"
fi fi
if [ ${CHECK} -eq 1 ]; then if [ ${CHECK} -eq 1 ]; then
downsum=$(${hashType} ${fname} | awk '{print $1}') downsum=$(${hashType} "${fname}" | awk '{print $1}')
if [ "${fsha}" != "${downsum}" ]; then if [ "${fsha}" != "${downsum}" ]; then
rm -f ${fname} rm -f "${fname}"
echo "Failure: ${fname} hash does not match hash from the .metadata file" >&2 echo "Failure: ${fname} hash does not match hash from the .metadata file" >&2
exit 1; exit 1;
fi fi