kdelibs/kdecore/config/ksettings.cpp
Ivailo Monev 7c787fcae3 kdecore: check if filename argument of KSettings is absolute rather than existing
this ensures that if filename is to be created the fallback lookup is not
used and in case filename is existing directory instead of actual file, as
QFile::exists() may return true for directories, it does not end up as
relative path passed to QSetting which leads to QSettings object being
created with relative name rather than the fallback

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2020-01-09 00:10:22 +00:00

64 lines
1.9 KiB
C++

/*
This file is part of the KDE libraries
Copyright (C) 2019 Ivailo Monev <xakepa10@gmail.com>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "ksettings.h"
#include "kstandarddirs.h"
#include <QApplication>
#include <QFileInfo>
#include <QStringList>
static const QSettings::Format defaultformat = QSettings::IniFormat;
static QString getSettingsPath(const QString &filename)
{
QFileInfo info(filename);
if (info.isAbsolute()) {
return filename;
}
return KStandardDirs::locateLocal("config", filename);
}
KSettings::KSettings(const QString& file, const OpenFlags mode, QObject *parent)
: QSettings(getSettingsPath(file), defaultformat, parent)
{
if ((mode & IncludeGlobals) != mode) {
addSource(KStandardDirs::locateLocal("config", QLatin1String("kdeglobals")));
}
}
KSettings::~KSettings()
{
}
void KSettings::addSource(const QString &source)
{
QSettings settings(source, defaultformat);
#ifndef QT_KATIE
foreach (const QString &key, settings.allKeys()) {
#else
foreach (const QString &key, settings.keys()) {
#endif
if (!QSettings::contains(key)) {
QSettings::setValue(key, settings.value(key));
}
}
}