Commit graph

1088 commits

Author SHA1 Message Date
Ivailo Monev
bd9f76451d generic: remove redundant metatype registrations
builtin

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-03 02:17:57 +03:00
Ivailo Monev
dcb57aa69a kdeui: manually delete the dialog in KMessageBox::createKMessageBox()
Qt::WA_DeleteOnClose can have some unforseen consequences

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 08:57:44 +03:00
Ivailo Monev
aeef583555 kdeui: unregister any registered jobs from KPlasmaJobTracker destructor
this is so that jobs are not left in the plasma applets as active when, for
example, the program that has jobs registered is interrupted by a signal
(be that ctrl+c or something nasty like SIGSEGV). KUiServerJobTracker
was just warning about it but I can do better

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-01 06:48:43 +03:00
Ivailo Monev
f44fc1ee8d kdeui: tweak KMessageBox layout
with a fixed-size contstraint the stretch factor bits are redundant

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 23:33:31 +03:00
Ivailo Monev
0e4e6a717f kdeui: import action collection configuration when adding one to KShortcutsDialog
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 23:02:11 +03:00
Ivailo Monev
faaf690e9e kdeui: use fixed-size size constraint for KMessageBox dialogs
effectively reverting 4ed10bdd76 but with a
twist

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 22:44:17 +03:00
Ivailo Monev
072673d082 kdeui: delete the KMessageBox dialog on close
what if the dialog is closed between show and exec by the window manager
tho?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 22:35:38 +03:00
Ivailo Monev
aebe72a932 generic: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 21:45:09 +03:00
Ivailo Monev
53dc9fede5 kdeui: enable opening of external links for KMessageWidget and disable text selection
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 21:31:32 +03:00
Ivailo Monev
e86c7d9264 kdeui: warn and restore the property text when changing property in KDebugger
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 08:58:29 +03:00
Ivailo Monev
2a566aa4d0 kdeui: rework KMessageBox layout
finally it is not scuffed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 08:24:48 +03:00
Ivailo Monev
78232470de kdeui: always use QTextBrowser for the details text
otherwise the look and feel is not consistent

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 07:49:07 +03:00
Ivailo Monev
0360088d1e kdeui: do not use KSqueezedTextLabel in KMessageBox
because the message may be rich text, see the previous commit

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 07:46:22 +03:00
Ivailo Monev
1c4fa8c32a kdeui: add warning about KSqueezedTextLabel
reminds me of surrogates chopping in QString..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 07:40:55 +03:00
Ivailo Monev
02df654093 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 07:11:05 +03:00
Ivailo Monev
704967c1b7 kdeui: remove unused KPlasmaJobTracker and KNotification data
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 06:42:36 +03:00
Ivailo Monev
c123758bc5 kdeui: remove redundant Q_UNUSED() in KPlasmaJobTracker::infoMessage()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 06:38:16 +03:00
Ivailo Monev
aa43f7335c kdeui: fix regression since 956cfc5a59
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 05:29:50 +03:00
Ivailo Monev
eb0b79bfca kduei: testing build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 04:12:15 +03:00
Ivailo Monev
5a2df923aa kdeui: use QTextBrowser instead of KTextEdit for detailed messages
the only way to make external links accessible right now, may revert it
if QTextEdit gets a method to make external links accessible. required for
the next commit

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 03:34:27 +03:00
Ivailo Monev
a613f682f9 kdeui: correct connection in KNotificationManager::send()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-29 06:11:18 +03:00
Ivailo Monev
307e136a13 kdeui: fix KDebugger events log thread-safety issue
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 18:33:00 +03:00
Ivailo Monev
3d5c97fa56 kdeui: implement basic events fuzzer for KDebugger
basic, anything else has to come with a warning message

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 18:17:21 +03:00
Ivailo Monev
e0124f2d74 kdeui: stub fuzz KDebugger feature
it will do nasty stuff

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 07:43:15 +03:00
Ivailo Monev
22a5f1922a kdeui: stringify events for KDebugger events log
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 07:25:45 +03:00
Ivailo Monev
b3d2df692a kdeui: clear widgets of KDebugger when nothing is selected
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 07:08:52 +03:00
Ivailo Monev
bb704df5ae kdeui: clear the contents of the properties widget of KDebugger
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 06:54:36 +03:00
Ivailo Monev
9dfe6602a9 kdeui: pass the associated action from KKeySequenceWidget to KGlobalAccel
for better shortcut stealing, e.g. for actions with more than one
shortcut

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 04:49:06 +03:00
Ivailo Monev
a2f589fc43 kdeui: log a message when stealing global shortcut from KGlobalAccel::stealShortcutSystemwide()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 04:17:37 +03:00
Ivailo Monev
70feecedcf kdeui: add TODO for global shorcuts stealing
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 04:06:41 +03:00
Ivailo Monev
87926d8e46 kdeui: disable widgets while updating in KDebugger
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 03:06:38 +03:00
Ivailo Monev
229cd9ca10 kdeui: correct property index getting in KDebugger
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 22:31:48 +03:00
Ivailo Monev
fa3f6619cf kdeui: track objects in KDebugger
to not dereference objects

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 00:32:01 +03:00
Ivailo Monev
f81209d44a kdeui: setup header of the objects widget of KDebugger
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 00:20:03 +03:00
Ivailo Monev
e78a460d6c kdeui: use the internal object pointer for properties changes in KDebugger
otherwise dereference may occur

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 00:12:16 +03:00
Ivailo Monev
3c584cfdb1 kdeui: implement properties editor for KDebugger
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 23:49:04 +03:00
Ivailo Monev
30a9360e5e kdeui: disable editing of read-only properties in KDebugger
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 23:30:20 +03:00
Ivailo Monev
70f0f3d997 kdeui: build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 23:27:42 +03:00
Ivailo Monev
956cfc5a59 generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 22:38:19 +03:00
Ivailo Monev
01d1de126a kdeui: use the metaobject class name if not empty in KDebugger
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 19:57:41 +03:00
Ivailo Monev
ec7b5bd959 kdeui: new KDebugger class
I've had the idea about it in my head for years

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 07:43:17 +03:00
Ivailo Monev
76d8f5c423 kdeui: remove unused KAccelGen methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 05:01:26 +03:00
Ivailo Monev
b54f55ede4 kdeui: use QAction::setShortcut() instead of setting property
much faster

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 04:36:47 +03:00
Ivailo Monev
f2e7f97a62 kdeui: use private member for the KAction isShortcutConfigurable property
much more optimal, no funcitonal change

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 04:32:30 +03:00
Ivailo Monev
4c30a62d40 kdeui: set only the active shortcut when reading KActionCollection settings
setting the default makes no sense, the default should come from code not
from the config

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 04:20:48 +03:00
Ivailo Monev
b64a94ac19 kdeui: handle shortcut stealing in KShortcutsEditor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 04:19:37 +03:00
Ivailo Monev
383b6c53d0 kdeui: change only the active shortcut from KShortcutsEditor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 01:47:33 +03:00
Ivailo Monev
a4df5d73f9 kdeui: write shortcuts configuration only to regular config files
that xml gui stuff is pure garbage

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 01:09:52 +03:00
Ivailo Monev
1faf138d4b kdeui: do not emit KAction::globalShortcutChanged() when the default changes or when the shortcut is set for the first time
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 01:06:36 +03:00
Ivailo Monev
d74d369e5e kdeui: simplify KActionCollection settings reading and writing
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-25 23:10:57 +03:00