Commit graph

56 commits

Author SHA1 Message Date
Ivailo Monev
713c9394d7 kdecore: drop message box feature of KDebug
tho it can be fixed (by not using queued up message boxes) I am not into
supporting such feature

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-20 19:40:13 +03:00
Ivailo Monev
1d7883f245 kdecore: replace QDateTime::currentDateTime().time() with QTime::currentTime()
QTime::currentTime() is slightly faster

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-04 22:20:34 +03:00
Ivailo Monev
2308c97882 kdecore: logging to file optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-14 21:59:10 +02:00
Ivailo Monev
7cb0785160 kdecore: add note about QDialog::exec() to the alarm() call in KDebugMessageBoxDevice::writeData()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-29 00:24:31 +03:00
Ivailo Monev
625373ffa8 kdecore: drop KDateTime
with the rewrite (see f452e2e50b),
KDateTime is just glue-code for compatibility now. the exception is
KDateTime::isNightTime() (written by me) which is used only in one place
(kde-workspace/plasma/dataengines/weather/ions/wetter.com/ion_wettercom.cpp)
and can be moved there

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-14 22:35:08 +03:00
Ivailo Monev
6bf6169caf kdecore: return QByteArray from kBacktrace()
to avoid conversion from QString to QByteArray when possible, the trace is
handled as array of latin1-encoded strings anyway

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-04 08:14:53 +03:00
Ivailo Monev
f452e2e50b kdecore: reimplement KDateTime via QDateTime
KDateTime shall be used only for storing date and time while KLocale
shall be used to display such, not even going to test what KDateTime
does because it is basically a few methods on top of QDateTime now.

and because QDateTime knows not much about calendar systems while
KLocale supports several it makes sense for KDateTime to not be used for
displaying date and time thus the TODOs for KLocale are simply removed

note that KLocale still uses its own parser and formatter which means
that the change affects only KDateTime and its uses, not KLocale

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-07-21 07:51:13 +03:00
Ivailo Monev
3e1a64459e kdecore: check if debug messages are disabled globally from KDebugConfig::areaDevice()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-26 23:55:46 +03:00
Ivailo Monev
90c57ada83 kdecore: unregister the helper service and object from KAuthorization destructor
I should (ab)use the object name for more things

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 08:19:15 +02:00
Ivailo Monev
f9171a653f kdecore: cache the debug area devices as KDebugConfig member
reducing the global statics used by KDebug to two - one for the null device
and one for the configuration and internal cache

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 07:42:40 +02:00
Ivailo Monev
6e8e2238cc kdecore: add comment to KDebug() default switch case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 04:51:47 +02:00
Ivailo Monev
f80529f5cd kdecore: replace hard-codec KDebug output types with enums
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 02:44:44 +02:00
Ivailo Monev
4e933b8cc8 kdecore: check if KDebug mutex is destroyed before using it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 17:34:08 +03:00
Ivailo Monev
d33ed63e8f kdecore: cache debug area preferences on demand
most programs use 5-15 areas and if kdebugrc contains preferences for many
areas the initial caching process would take a lot of time

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 05:34:21 +03:00
Ivailo Monev
054f2fc7e7 kdecore: deal with TODO related to KDebug
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 03:28:52 +03:00
Ivailo Monev
a1a03f11a0 kdecore: do not add timestamp to header when the output type is syslog
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 02:54:54 +03:00
Ivailo Monev
70b7bb978d kdecore: use red color for both critical and fatal message type but make the fatal blink
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 05:23:42 +03:00
Ivailo Monev
f433324deb kdecore: KDebug review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 04:04:57 +03:00
Ivailo Monev
6d54fcbe94 kdecore: simplify and unexport KDebug internals
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 00:33:05 +03:00
Ivailo Monev
b45b5344b2 kdecore: cache KDebug devices based on area and output type
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 00:59:46 +03:00
Ivailo Monev
22463b6895 kdecore: cache KDebug area preferences
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 20:11:28 +03:00
Ivailo Monev
65e8d1dfe3 kdecore: open and close the system log for each message
sub-optimal but recommended in glibc/manual/syslog.texi for shared
libraries, there is also the case of multiple KDebugSyslogDevice opening
the system log more than once per-program

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 19:29:58 +03:00
Ivailo Monev
8224768f2a kdecore: print debug messages of shell type to stderr too
for program that outputs something to stdout and other program reads it,
don't want programs to read debug messages

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 07:10:52 +03:00
Ivailo Monev
d834ef9e19 kdecore: fix writing of warning messages to file and test case it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 06:44:30 +03:00
Ivailo Monev
35fa149bc0 kdecore: copyrighting KDebug to me
if I rewrite kBacktrace() there is nothing left not coded by me there, I
wrote backtrace printer for Katie with symbols demangling btw

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 05:51:54 +03:00
Ivailo Monev
271b1a0588 kdecore: print colorized messages that are not of debug type to stderr
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 03:39:26 +03:00
Ivailo Monev
960461d7ce kdecore: destroy devices and reset environment variable caches from kClearDebugConfig()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 03:36:59 +03:00
Ivailo Monev
04c84dfbc1 kdecore: implement KDE_DEBUG_COLOR for KDebug
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 02:53:46 +03:00
Ivailo Monev
f3905e1760 kdecore: implement KDE_DEBUG_METHODNAME for KDebug
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 02:04:33 +03:00
Ivailo Monev
04a111969a kdecore: flush the file stream after printing to it from KDebugShellDevice
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 01:20:15 +03:00
Ivailo Monev
930c5af97c kdecore: unexport internal kDebugDevNull() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-23 00:17:22 +03:00
Ivailo Monev
e4b1268804 kdecore: debug classes, functions and definitions review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-22 19:55:23 +03:00
Ivailo Monev
028414cb07 kdecore: KDebug rewrite
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-22 19:17:52 +03:00
Ivailo Monev
29a8459798 generic: remove checks for system headers that should be present
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-23 15:42:09 +03:00
Ivailo Monev
12c5882412 kdecore: remove obsolete Solaris workaround
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-09-18 20:31:28 +03:00
Ivailo Monev
dd07d6844b kdecore: remove perror() debug stream function [ci reset]
TODO: use qt_error_string() instead of strerror() for thread-safety

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-08-08 21:55:18 +03:00
Ivailo Monev
9bc27f4d04 kdecore: mark KDebugPrivate::level() as const
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-07-26 01:58:40 +03:00
Ivailo Monev
67a8004abd kdecore: do not change the message type of toolkit message writer
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-07-26 01:58:05 +03:00
Ivailo Monev
e8c515b7ff kdecore: correct critical debug messages log level
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-07-21 13:11:43 +03:00
Ivailo Monev
404d67d1de kdecore: remove now unused private variable
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-01-11 08:33:31 +02:00
Ivailo Monev
543af5fde6 kdecore: remove now unused private variable
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-01-10 13:53:07 +02:00
Ivailo Monev
63dcefb9cd kdecore: do not rely on compiler feature to detect null output
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-01-10 12:17:39 +02:00
Ivailo Monev
366c36f02a kdecore: remove unused KDebug block feature
fix expected output in test while at it, test now passes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-01-10 12:16:48 +02:00
Ivailo Monev
0ea27e5d09 kdecore: remove unused code
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-01-03 02:13:38 +02:00
Ivailo Monev
d9426e514c kdecore: move variable closer to the scope it is used in
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-01-03 02:09:04 +02:00
Ivailo Monev
b0c48bbe79 kdecore: replace QThreadStorage with thread_local
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-14 22:55:09 +00:00
Ivailo Monev
896476b53a generic: replace QThreadStorage with thread_local where possible
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
2019-05-14 21:51:40 +00:00
Ivailo Monev
8006199dbe generic: misc cleanups
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-12-21 15:52:53 +00:00
Ivailo Monev
949dff9e92 generic: misc cleanups
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-10-19 03:32:06 +00:00
Ivailo Monev
344cd812dc generic: misc cleanups
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-30 00:30:19 +00:00