Commit graph

242 commits

Author SHA1 Message Date
Ivailo Monev
ec2e04c3d8 plasma: remove duplicate header inclusions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 13:30:11 +02:00
Ivailo Monev
f0a1b5fb6b plasma: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 11:12:26 +02:00
Ivailo Monev
3ce0161856 plasma: remove unused and private Plasma::Animator member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 10:16:01 +02:00
Ivailo Monev
f6dba585d7 plasma: remove declaration of non-existing Plasma::Animator signals
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 10:12:01 +02:00
Ivailo Monev
716152020d plasma: remove unused Plasma::Animator::Movement enum
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 10:11:38 +02:00
Ivailo Monev
6fec902232 plasma: remove declaration of non-existing SlideAnimationPrivate class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 10:04:55 +02:00
Ivailo Monev
5933638f18 plasma: remove unused Plasma::AnimatorPrivate member and methods, also the custom easing type
the animations use either QEasingCurve or JS code (which will eventually
be converted to sub-class of QEasingCurve for performance reasons)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 10:00:51 +02:00
Ivailo Monev
110e53a48e plasma: remove unused X-Plasma-Args property
according to the chanages log (see kde-workspace/plasma/design/CHANGELOG-4.4)
it was used by the mediawiki runner which is no longer supported

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 07:32:35 +02:00
Ivailo Monev
69f56fa9d8 plasma: remove unused Plasma::ComboBoxPrivate members
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 03:08:57 +02:00
Ivailo Monev
97372a82ef plasma: remove unused AbstractDialogManager class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 00:06:27 +02:00
Ivailo Monev
3fca1f6504 plasma: pass the script data directly to QScriptEngine::evaluate()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 10:06:36 +02:00
Ivailo Monev
0aa020de88 plasma: remove duplicate animation registration
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 09:49:47 +02:00
Ivailo Monev
aef479ab03 plasma: do not guess the mask color in FrameSvg::mask()
using the mask created by QPixmap::mask() is much more reliable way
to get one, fixes masking in case compositor is not active for example

side note: feels good to finally land the fix for masking

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-06 09:26:21 +02:00
Ivailo Monev
a3d14ed9f8 plasma: query KWindowSystem directly for the compositor state
because Plasma::Theme (and Plasma::ThemePrivate indirectly) may be created
before QCoreApplication/QApplication instance by Theme::defaultTheme()
and application instance is required for QX11Info::display() to return
non-null (which KWindowSystem uses but has fallback in case it is null
in KWindowSystem::compositingActive())

note that KWindowSystem::compositingActive() returns cached value if
XFixes is available

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-06 10:27:10 +02:00
Ivailo Monev
bc067dbdfa kio: drop support for putting slaves on hold
with klauncher no longer responsible for KIO slave the next step is to
make them plugins and the feature to put them on hold will be of no value
because QLibrary reuses library/plugin instances and creating a new
slave object will be cheap

in other words the performance will be similar to that of KFileMetaInfo
for which I also wrote the plugins myself - they are pretty quick
compared to what strigi was doing and with more flexible configuration
interface but it took some effort to get there

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-06 04:22:23 +02:00
Ivailo Monev
148110f398 generic: drop locolor support
`apt-file` search yeilds 221 files matching (8 packages provide such),
it is also unused by plasma even tho there are leftovers from support for it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-05 01:30:27 +02:00
Ivailo Monev
a684811e80 plasma: remove duplicate header inclusions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-03 03:54:58 +02:00
Ivailo Monev
0f0c306927 plasma: move bufferPixmap variable to the scope it is used in
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-03 00:57:54 +02:00
Ivailo Monev
ce4f5b3c14 plasma: build fix for the case when NDEBUG is not defined
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-30 10:15:50 +02:00
Ivailo Monev
a8ec0ae048 plasma: remove binary compat bits
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-28 01:28:02 +02:00
Ivailo Monev
98f1b0b90a plasma: fix shortcuts
who tought using the same shortcut for multiple actions is going to work?
the single character shortcuts are very likely to conflict with other
shortcuts aswell

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 11:47:09 +02:00
Ivailo Monev
e50350ac20 plasma: remove redundant QString construct in correctPathCase() function
path is a QString constant reference

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-23 22:02:32 +02:00
Ivailo Monev
c70b115d3f plasma: clear tooltip mask when compositor is active
as is done by Plasma::Dialog

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 14:04:06 +02:00
Ivailo Monev
b63686e9d0 generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 04:43:56 +02:00
Ivailo Monev
a5734faf0f kdeui: new KPixmap class
very much written for use case, not to make sense. while porting to it I
already noticed there are leaks for X11 pixmaps and may have to write
glue code to keep track of the pixmaps and release them before
application quits, that will be a huge performance penalty tho so may
have to be ifdef'ed for debug builds only

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-09 02:08:27 +02:00
Ivailo Monev
38cc86db41 plasma: export DialogShadows class
there are 3 copies of the sources for that class because it is not
exported (one here, one in kde-workspace and one in kde-extraapps) with
one class that is very similar to it - PanelShadows (in kde-workspace
repo, part of plasmagenericshell library)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-07 18:05:11 +02:00
Ivailo Monev
d88d74f0c9 plasma: remove unused header inclusion
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 12:56:51 +02:00
Ivailo Monev
d37ea70af9 plasma: remove redundant connection to QCoreApplication::aboutTOQuit() signal
at the point where the application is about to exit it is not safe to even
access the global static (by calling Plasma::Theme::defaultTheme()) since
it will be deleted

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-05 04:22:58 +02:00
Ivailo Monev
b403cadd86 plasma: wallpaper cache lookup optimization
QFile::exists() uses temporary QFileInfo object that does the same

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 19:03:45 +03:00
Ivailo Monev
d4ac838463 plasma: return if the X11 property is deleted in Plasma::WindowEffects::highlightWindows()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:39:43 +03:00
Ivailo Monev
b0b9fb8fce plasma: remove redundant computations and checks in Plasma::WindowEffects functions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:37:05 +03:00
Ivailo Monev
35cb26227d plasma: use specialized QImage constructor instead of constructing and loading
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:31:40 +03:00
Ivailo Monev
1b15162b50 plasma: deal with TODO related to moving Plasma::Wallpaper member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:27:49 +03:00
Ivailo Monev
f34d660dbb plasma: automatic MOC-ing warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-24 18:26:01 +03:00
Ivailo Monev
6e995c6db0 plasma: do not attempt to guess elements from SharedSvgRenderer constructor
once it has been done and interesting elements information reaches the
disk cache (which is shared config) parsing the file again is a waste

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-17 00:01:25 +03:00
Ivailo Monev
9c6ba7e9e2 generic: drop support for storing passwords in kcfg files
use KPasswdStore instead

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-16 19:11:32 +03:00
Ivailo Monev
decb354a0d generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-14 16:16:22 +03:00
Ivailo Monev
3ab3f3b47f kutils: new karchive library to replace KZip and KTar
it has to solve a few problems like:
1. blocking the current thread while listing, extracting or adding to
   archive
2. lack of support for some archive formats such as 7-zip in the
   previously available classes for dealing with archive
3. progress and error reporting

a KArchiveJob class may have to be implemented to solve the above
issues. the API is just as frustrating to use as KTar and KZip right now
tho and I am not happy with that but the class itself is a 3-rd rewrite
of what was once Python module, plugin for another project and now used
as base in library.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-06 16:53:55 +03:00
Ivailo Monev
46b529fc21 plasma: drop methods to install, uninstall, register and get package file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-04 21:53:59 +03:00
Ivailo Monev
e96a8c4813 plasma: remove redundant reimplementations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-04 04:17:15 +03:00
Ivailo Monev
9e7a184394 plasma: remove bogus declaration of RotationAnimation::setEasingCurve()
not implemented actually

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-04 04:17:00 +03:00
Ivailo Monev
9b07290ada kdeui: prefix HOME_URL, BUG_REPORT_URL and BUG_REPORT_EMAIL definitions with "KDE_"
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-03 16:25:13 +03:00
Ivailo Monev
ed7e30c232 plasma: remove noop ContainmentActions reimplementation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-02 00:31:16 +03:00
Ivailo Monev
e473efecec plasma: someone's typo
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-02 00:04:57 +03:00
Ivailo Monev
792357e82e plasma: const-ify Dialog::graphicsWidget() getter
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-29 22:51:50 +03:00
Ivailo Monev
7dc5187778 kdecore: replace most of KRandomSequence with new KRandom::randomMax() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-26 12:58:37 +03:00
Ivailo Monev
23fd8e397b plasma: replace tabs with space in package source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-26 09:54:32 +03:00
Ivailo Monev
e88c621aa2 generic: authorization reimplementation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-25 19:27:41 +03:00
Ivailo Monev
01d40bf689 plasma: drop custom categories support
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-21 02:42:25 +03:00
Ivailo Monev
87aaa67622 plasma: Plasma::WindowEffects::isEffectAvailable() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-20 13:56:54 +03:00