Commit graph

411 commits

Author SHA1 Message Date
Ivailo Monev
589c3ca009 kutils: change the slider position before load() in KMediaWidget::open()
fixes rare runtime warning about seek command failure. the proper thing
to do is close, wait for close to happen, set slider position, load and
continue the event cycle but that's too complicated when buffering is not
expected to happen on seek (i.e. when a file from the hard-disk is
currently loaded)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-14 22:09:23 +02:00
Ivailo Monev
b38a3f8b41 kutils: fake seek to start when re-opening path from KMediaWidget::open()
the event for the position update may be in queue and received after
load()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-14 21:46:41 +02:00
Ivailo Monev
6ab1b28de5 Merge branch 'master' of https://scm.osdn.net/gitroot/kde/kdelibs 2022-12-14 19:42:34 +02:00
Ivailo Monev
06c1b9dda8 kutils: correct disconnection in KAudioPlayerModule::_removeFinished()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-14 19:42:18 +02:00
Ivailo Monev
de4c9f1d6a kioslave: add disabled curl_easy_setopt() to http KIO slave
for debugging connection issues

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-14 14:26:50 +02:00
Ivailo Monev
6adc4fcaea kutils: increase the KDecompressor buffer size increment to 1MB
speeds up loading of large gzip-compressed files for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-14 09:54:10 +02:00
Ivailo Monev
a9c334844d kutils: reserve space for the metadata items from KExiv2::metadata()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-14 01:11:33 +02:00
Ivailo Monev
90c57ada83 kdecore: unregister the helper service and object from KAuthorization destructor
I should (ab)use the object name for more things

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 08:19:15 +02:00
Ivailo Monev
7ba06852a7 kutils: add TODO for KMediaWidget
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 13:20:56 +02:00
Ivailo Monev
00d47751c1 kutils: set the position to zero when the player finishes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 13:02:01 +02:00
Ivailo Monev
a0254bdc68 kutils: set KMediaWidget position independant of the value
now it works as expected when the arrow keys are pressed or when its
position is changed by clicking while having the mouse cursor on either
side of the current position

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-06 11:35:07 +02:00
Ivailo Monev
df1263c847 kutils: UIC warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-06 00:13:40 +02:00
Ivailo Monev
bd2231fdd6 kutils: use only the width as condition for showing the play button text
the height does not affect the position slider size

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-02 07:11:10 +02:00
Ivailo Monev
0cdb519ddc kutils: poll for state changes even if org.freedesktop.login1 interface is used
the state is tracked anyway and now the code path for both is the same

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-02 06:14:30 +02:00
Ivailo Monev
84f426d37f kutils: include kpasswdstore library directories
fixes bootstrap build

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-02 02:50:59 +02:00
Ivailo Monev
eb94c30c11 kutils: const-ify variable in KMediaWidget::dropEvent()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-01 02:53:06 +02:00
Ivailo Monev
d6d17d194c kutils: use KMessageBox for the drop event error
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-01 02:51:54 +02:00
Ivailo Monev
d359858513 kutils: correct default value for widgetStyle
is keramik v3.x style?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-30 08:39:37 +02:00
Ivailo Monev
806b06db55 kutils: update org.freedesktop.ScreenSaver interface file used by kidletime
those methods were not implemented and were removed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-30 04:58:11 +02:00
Ivailo Monev
bdccbb1709 generic: implement hybrid suspend/sleep method
marking as extension because it was not implemented before and the FDO
spec is dead (i.e. not a spec anymore), may or may not work with other
power managers implementing the interface (org.freedesktop.PowerManagement)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-30 02:14:44 +02:00
Ivailo Monev
f744763fcd kutils: update the play button from KMediaWidget::setPlay()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 07:27:07 +02:00
Ivailo Monev
a735d4ee3b kutils: remove TODO related to KMediaWidget
don't have to restore the position from KMediaWidget itself

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 07:26:42 +02:00
Ivailo Monev
22755ffef1 kutils: drop the fullscreen option of the media widget
that nasty hack was working like a charm tho. oh, well..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 07:08:27 +02:00
Ivailo Monev
8c1a5d300a kutils: invert the meaning of the KMediaWidget::setPlay() argument
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 06:54:53 +02:00
Ivailo Monev
238f9c37bc kutils: drop the hidden controls option
it is very tricky to do it correctly, especially with KMainWindow and the
like doing their thing with menu/status bars

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 06:20:37 +02:00
Ivailo Monev
7408c3b692 kutils: de-duplicate KAbstractPlayer code
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 06:03:56 +02:00
Ivailo Monev
12a58a3ee0 kutils: media classes debug and warning messages review
some of them were wrapped in i18n() macro with the idea to use some of them
in errorString() getter to report MPV initialization failure for example
but I do not think I will implement that (not that there is error(QString)
signal for reporting MPV failure after its initialization)

the debug messages are also quite spammy (because of time-pos property
changing constantly while playing for example), i.e. don't enable them
unless you have good reason for that because multiple media classes
instances can quickly fill your ~/.xsession-errors with lots of messages

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 02:22:04 +02:00
Ivailo Monev
7f4e028fb6 kutils: do not observe loadfile property
altought it is a command an event it send for it but the property is not
used by the media classes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 02:09:40 +02:00
Ivailo Monev
883db83628 kutils: KMediaPlayer initialization optimization
there used to be "vo" option doing the same I believe, anyway it should
speed up initializations by not checks for other contexts (it is to be
rendered into X11 window after all)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-29 01:15:44 +02:00
Ivailo Monev
254431d75a kutils: udate comment in KMediaWidget::_updateError()
there used to be option to disable the controls (play/pause button,
position slider, etc.)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-28 23:07:13 +02:00
Ivailo Monev
b0e419b650 kutils: set the horizontal size type of the main KMediaWidgetUI widget to expanding
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 06:13:59 +02:00
Ivailo Monev
797ecf1dfc kutils: show KMediaWidget play button text conditionally
this feature is mostly for Dolphin which fits it into a small area and
there really is not enough space for the position slider

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 05:59:37 +02:00
Ivailo Monev
e5dbeb8cb4 kutils: correct slot name in KMediaWidget constructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 04:52:16 +02:00
Ivailo Monev
5d0377b9e6 kutils: rename the internal KMediaWidget UI class
so that the uic tool does not generate code that uses variables with
the name of the private KMediaWidget class (KMediaWidgetPrivate)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 00:45:28 +02:00
Ivailo Monev
667c23d743 kutils: delete the player before the UI from KMediaWidget destructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 00:36:02 +02:00
Ivailo Monev
e20d610997 kutils: load kpasswdstore module in phase 1
see the hack in kdirshare module

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 19:01:10 +02:00
Ivailo Monev
a4ec0f5724 kutils: implement login via OAuth access token
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 07:56:02 +02:00
Ivailo Monev
38635d4406 kio: implement IconAlpha config option for previews
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 23:35:39 +02:00
Ivailo Monev
2bfb406a69 kutils: format and indent kcmoduleloader source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 14:02:04 +02:00
Ivailo Monev
a9c4638559 kutils: remove now bogus KCModuleLoader::unloadModule() method
QLibrary was rewritten and no longer uses internal reference count for
unloading thus constructing KPluginLoader object and unloading the library
does not have the effect it used to have, the KCModule pointer is deleted
by KCModuleProxy::deleteClient() regardless and QLibrary takes care of the
rest

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 05:55:24 +02:00
Ivailo Monev
c9fc4fa758 kutils: remove redundant KCModuleProxy::minimumSizeHint() reimplementation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 05:47:50 +02:00
Ivailo Monev
2105d01df8 kutils: check the qApp pointer in KCModuleProxy::deleteClient()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-16 05:37:19 +02:00
Ivailo Monev
9b41127ecb generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 00:40:18 +02:00
Ivailo Monev
134d90ee06 kdecore: remove unused custom autostart path
the XDG path is be used instead, the custom autostart path was for programs
and scripts which is not feature mentioned in the spec

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-04 09:54:48 +02:00
Ivailo Monev
bb9979b108 kutils: plug KExiv2 memory leaks
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-02 12:15:09 +02:00
Ivailo Monev
90928e8320 generic: store package found definitions in config header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-30 05:41:21 +02:00
Ivailo Monev
4cffecc6af kutils: verify the KArchive progress signal values in its test case
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-27 09:49:28 +03:00
Ivailo Monev
3f692a32f9 kutils: implement progress signal for KArchive
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-27 03:47:53 +03:00
Ivailo Monev
d84dd15cdf kutils: check the return value of CURLOPT_LOGIN_OPTIONS option setup in KEMail
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 11:38:55 +03:00
Ivailo Monev
252c2b96d5 kutils: ensure startup notification events are processed from KEMailDialog::showEvent()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-26 07:12:34 +03:00