Commit graph

572 commits

Author SHA1 Message Date
Ivailo Monev
e596f9a5d6 kdeui: unreserve KMessageBox::DialogType::SSLMessageBox
KIO SSL support was dropped some time ago (the certificates related code
that was used by konqueror)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-13 14:36:47 +02:00
Ivailo Monev
7cfcbc3775 kdeui: new KCrash::Backtrace to log backtraces
for programs that cannot call drkonqi to show backtrace (such as
ksmserver or any non-GUI D-Bus service)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 12:28:21 +02:00
Ivailo Monev
bdff3fa4e7 kdeui: log backtrace when no KCrash flags are set
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 12:17:48 +02:00
Ivailo Monev
6784f51d58 kdeui: tweak KNotificationManager and KGlobalAccel for automatic service activation
KGlobalAccelPrivate uses service watcher and the interface is invalid until
the service is activated (either by the first call of the interface or some
other lazy-initialization method), however KNotificationManager does
connect to signals immediately (which should work regardless) but the error
may have been logged before

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 12:00:23 +02:00
Ivailo Monev
a1951cfbae kdeui: reuse the already created interface in KGlobalAccelPrivate::getComponent()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 11:37:02 +02:00
Ivailo Monev
32dbecf2c6 kdeui: disable auto-restart when the application is about to quit
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 10:19:13 +02:00
Ivailo Monev
717fd59dc8 kdeui: send only SIGTERM before killing the selection owner via XKillClient()
XKillClient() is the same as sending SIGKILL

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 09:24:33 +02:00
Ivailo Monev
eb8ff2c536 kdeui: remove unused and private KHBox member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:55:12 +02:00
Ivailo Monev
593dd8b8d3 kdeui: format and indent khbox source and header files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:53:13 +02:00
Ivailo Monev
e7ae8c8351 kdeui: remove unused and private KTabBar methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:46:18 +02:00
Ivailo Monev
d5d26f9b11 kdeui: remove unused and non-operational KWindowSystem::allowExternalProcessWindowActivation() method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:06:40 +02:00
Ivailo Monev
ca762874c8 kdeui: remove KWindowSystem::doNotManage() method
what if KWin is not running? it's not a WM spec thing anyway

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 04:04:20 +02:00
Ivailo Monev
0e980c95cc kdeui: remove redundant attempts to start D-Bus services
creating QDBusInterface should start the services, in case the services
cannot be started tho delays may be experienced (such as the UI freezing
while waiting for D-Bus reply to finish) thus logging error

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 03:40:07 +02:00
Ivailo Monev
f27ab85ce6 kdeui: correct breaks indentation in KPixmapSequenceOverlayPainter::eventFilter()
they look really out of place, don't they?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 13:16:20 +02:00
Ivailo Monev
802bf9aaf1 kdeui: KPixmap documentation correction
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 13:12:30 +02:00
Ivailo Monev
6c98720e24 kdeui: implement KCrash::NoRestart flag
for programs that cannot be restarted by simply exec-ing them such as the
KIO slaves which require application socket as argument

note that restarting is maybe works thing - programs started by kdesudo
cannot be restarted (properly) as they are exec-ed by other program that
does the setup for them to function the way they should

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 00:36:35 +02:00
Ivailo Monev
d4bf3d7a70 kdeui: exit after logging error when drkonqi is not installed
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 08:54:32 +02:00
Ivailo Monev
41418cb12b kdeui: set the KCrash handler to the default one if command line args are not initialized
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 08:33:04 +02:00
Ivailo Monev
6896f96245 kdeui: check if the KCmdLineArgs pointer is non-null before using it
fixes possible crash (e.g. when KCmdLineArgs is not initialized)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 07:49:43 +02:00
Ivailo Monev
d258df3881 generic: unblock signals when setting handlers for them
generally, those signals should not be blocked but it seems something is
blocking consequent SIGSEGV signals send by `kill` for example

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 07:45:25 +02:00
Ivailo Monev
be2d99738e kdeui: use system() instead of QProcess to execute drkonqi
less things can go wrong

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-07 07:14:26 +02:00
Ivailo Monev
b3d1569867 kdeui: tag comment as note in KCrash::defaultCrashHandler()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-05 23:16:46 +02:00
Ivailo Monev
b447c353a7 kdeui: log error in case neither of the KCrash flags is set
since any message type can be set to log via syslog() that may be the only
way to know when a program without interface (such as service) crashes

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-05 04:23:05 +02:00
Ivailo Monev
7205f8f391 kdeui: install the KWindowSystemPrivate event filter before selection XFixes input
fixes possible X11 event race

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-05 02:48:44 +02:00
Ivailo Monev
148110f398 generic: drop locolor support
`apt-file` search yeilds 221 files matching (8 packages provide such),
it is also unused by plasma even tho there are leftovers from support for it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-05 01:30:27 +02:00
Ivailo Monev
ef0dd41a12 kdeui: do not assume XDisplayString() and getenv() return non-null
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-05 00:45:26 +02:00
Ivailo Monev
5177126cc6 generic: documentation update
note that the kdeinit README used to reference Pentium 3 CPU

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-05 02:08:10 +02:00
Ivailo Monev
aa6b5ea4f0 kinit: klauncher and KCrash rewrite
much simpler and easier to maintain, also it will be proper D-Bus
service now with no sockets, process title hack and whatnot. KCrash
and startkde script (in kde-workspace repo) have to be adjusted for
it tho

note that the internal KIO scheduler already has the functionality to
put slaves on hold but now they will be started as detached process.
eventually they may become plugins (they are loaded as such by kioslave
program) without event loop dispatcher

fixes application startup notification (ASN) and cleanup issues

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-04 23:20:15 +02:00
Ivailo Monev
409253ab09 kdeui: enable complex animation effects by default if compositing manager is running
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-03 03:22:28 +02:00
Ivailo Monev
ac32164782 kdeui: remove unused KFontChooser widget
unused since the raw (X11) fonts support was dropped

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-27 07:29:50 +02:00
Ivailo Monev
d37a7c4c6e kdeui: ensure the favicon has size suitable for overlay
with commit de8c7f6af1d79c6b3cd3e8b2a21a56a020163b73 (in kde-workspace) I
changed the behaviour of favicon KDED module to not down-scale the favicons
to 16x16 and that ofcourse means large favicons (e.g. 256x256, yes some
websites have favicon with such size) may be overlayed on top of 32x32 icon
which does not look OK.

with this change the icon overlay will match the visual ratio of any
other icon overlay, unfortunetly that means scaling the favicon (i.e. for
large icons such 256x256, favicon with size 16x16 may be up-scaled to 32x32
) but it will still look better than it used to

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-25 04:44:04 +02:00
Ivailo Monev
0cafb27096 kdeui: do not detach the QImage object in KStatusNotifierItemPrivate::imageToStruct()
it cannot be detached even if not copied (as done when it is not in
QImage::Format_ARGB32 format) because image is constant reference but if it
is converted it will be actually detached, also QByteArray takes ownership
of the data

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-24 20:23:56 +02:00
Ivailo Monev
169eb9fed6 Merge branch 'master' of https://scm.osdn.net/gitroot/kde/kdelibs 2022-11-22 23:15:46 +02:00
Ivailo Monev
7d102a665e kdeui: remove FIXME
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 23:45:40 +02:00
Ivailo Monev
b7e58ab6e8 kdeui: replace tab with space in KPassivePopup::setPopupStyle()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 23:15:33 +02:00
Ivailo Monev
0ddd9e7046 kdeui: rewrite KGlobalSettings graphics effects level getter
why does a method named reloadStyleSettings reload graphics effects level
settings and not application style settings?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-22 04:44:24 +02:00
Ivailo Monev
8cc2e71c91 kdeui: enable tear-off handles depending on the graphic effects level
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 23:39:15 +02:00
Ivailo Monev
1d760e4f09 kdeui: remove reference to non-existing KPopupTitle class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 23:35:59 +02:00
Ivailo Monev
521d3cd59b kdeui: remove unused KFadeWidgetEffect class
for example on how to do it (somewhat) properly see KMessageWidget

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 20:05:45 +02:00
Ivailo Monev
a37bd35627 kdeui: render KMessageWidget snapshot into QImage
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 18:44:19 +02:00
Ivailo Monev
d6fc2d834b kdeui: remove redundant reimplementations
the purge of binary compatibility bits is always on

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 16:05:38 +02:00
Ivailo Monev
f79e175d56 kdeui: format and indent khelpmenu source file
those breaks after return look very out of place

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 04:37:27 +02:00
Ivailo Monev
5c8d1d2e6b kdeui: remove redundant reimplementations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 04:11:11 +02:00
Ivailo Monev
3b6f69ac67 kdeui: remove redundant KMessageWidget::showEvent() reimplementation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-21 02:17:22 +02:00
Ivailo Monev
c43d9e8df7 kdeui: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-19 05:02:18 +02:00
Ivailo Monev
7555229053 kdeui: print error message if reading hex QColor from config results in invalid color
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-19 00:56:26 +02:00
Ivailo Monev
24e00f8ca5 kdeui: remove unused QFontDatabase header inclusion in kfontdialog source file
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 15:20:05 +02:00
Ivailo Monev
6424bc5ab8 kdeui: correct QFontDatabase::standardSizes() usage in KFontSizeAction
since it is a static method there is no need to create QFontDatabase object

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 15:18:57 +02:00
Ivailo Monev
792a8a442c kdeui: remove redundant KTabBar reimplementations
binary compatibility bits..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 02:44:18 +02:00
Ivailo Monev
27b5f27d2e kdeui: check if Xfixes is available before using xfixesEventBase
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 00:45:38 +02:00