Commit graph

111 commits

Author SHA1 Message Date
Ivailo Monev
6cdb77afd3 generic: various cleanups
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2018-07-17 15:35:02 +00:00
Ivailo Monev
151a5d4763 kutils: disconnect KAudioPlayerModule from the slot it was connected to
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2017-08-03 03:52:23 +00:00
Ivailo Monev
a22d3b9663 kutils: minor kmediaplayer cleanups
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2017-07-08 13:08:34 +00:00
Ivailo Monev
6ebc1cc143 kutils: make the KDED audio player module settings configurable
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-12-19 06:07:56 +00:00
Ivailo Monev
8a50a80c4e kutils: minor media classes and documentation review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-12-19 05:56:33 +00:00
Ivailo Monev
62c851e322 kutils: store the player's volume as integer rather than variant
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-12-19 05:55:20 +00:00
Ivailo Monev
c89aaffc1a kutils: add asserts for properties handling and a comment about a quirck
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-11-09 02:03:01 +00:00
Ivailo Monev
63d4353e4a kutils: more const-ing
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-24 20:18:18 +00:00
Ivailo Monev
cd19be08aa kutils: fix bootstrap build of kmediaplayer
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-24 20:17:20 +00:00
Ivailo Monev
c0fd00a6d3 kutils: const-const-constop it
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-24 18:21:23 +00:00
Ivailo Monev
a622ec8ea3 kutils: add kaudioplayer KDED module
the module has some use cases, like avoiding linkage to the
kmediaplayer library which links to MPV, which links to FFmpeg.
and since the module is loaded on demand there should be no change
in terms of resources usage untils it is used, in which case it
will use (roughly) the resources of single MPV instance until
kded4 quits.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-22 02:55:48 +00:00
Ivailo Monev
0c12ff6ce8 kutils: avoid use of delete on QObject derived classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-21 21:29:22 +00:00
Ivailo Monev
8f1b574050 kutils: improve the position slider and hidden controls behaviour
now when the slider is being dragged the player does not continuesly seek,
it does it only when the slider is released to avoid bad noise during the
quick seeking.

also, the controls will not be hidden now while any of the controls is
being pressed by the user, it's still not perfect because once the user
releases it the controls will be hidden and then (most likely) shown again
(unless no mouse was used for the interactive, e.g. tab for selection and
then space for interaction) but that will require even more connections
to the controls so I'm leaving it as is for now.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-21 18:43:47 +00:00
Ivailo Monev
293536b688 kutils: const-fy the media classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-21 17:58:44 +00:00
Ivailo Monev
e720461043 kutils: update example KMediaWidget code
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-19 06:02:59 +00:00
Ivailo Monev
e73768a99a kutils: hide private members of media widget class behind KMediaWidgetPrivate
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-19 05:54:39 +00:00
Ivailo Monev
72fed1d6a5 kutils: hide private members of media classes behind KAbstractPlayerPrivate
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-19 05:30:36 +00:00
Ivailo Monev
36072e6f92 generic: remove now redundant QT_KATIE guards
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-13 22:43:04 +00:00
Ivailo Monev
f006ffc089 kutils: fix a race in controls handler
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-13 15:03:25 +00:00
Ivailo Monev
5625d3bd29 generic: build system cleanups
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-03 00:32:29 +00:00
Ivailo Monev
1e26bf4a5d generic: build system cleanups
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-09-03 00:05:54 +00:00
Ivailo Monev
3e1adad878 kutils: remove KAudioWidget
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-08-09 03:30:37 +00:00
Ivailo Monev
155082bdf3 kutils: fix the window id setup in KMediaPlayer
WId should be unsigned long for Q_WS_X11 (see qwindowdefs.h from Qt4) but
MPV requiers that the type is intptr_t (see options.rst from MPV) yet none
of them works but quintptr does - it's magic.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-08-09 03:29:12 +00:00
Ivailo Monev
d1ee2575c1 kutils: make the player thread-safe
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-06-22 17:22:29 +00:00
Ivailo Monev
30c6025c61 kutils: the static cast was needed, oops
neither the compiler would complain (QVariant can hold custom types via
runtime registration) nor runtime warning about invalid QVariant was issued
for this (because it was casted to something, not sure what but it was the
wrong type)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-06-04 01:07:37 +00:00
Ivailo Monev
ecf6f851af kutils: use method that works on x86_64 for widget ID setup in KMediaPlayer
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-06-03 22:15:57 +00:00
Ivailo Monev
2d823ecdd8 generic: make MPV recommended not required
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-05-14 10:07:58 +00:00
Ivailo Monev
1f34f5ad73 generic: use CMake export header generator
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-27 20:13:02 +00:00
Ivailo Monev
cb09d66b2f kutils: review media classes documentation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-22 21:12:03 +00:00
Ivailo Monev
a0041f5d78 kutils: workaround issue wtih async access to the handle
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-21 13:57:31 +00:00
Ivailo Monev
17bdb396ea kutils: remove redudnant controls visibility variable
this improves on https://github.com/fluxer/kdelibs/commit/8e9028c4 because
it takes the initial state (so to say) into account (m_visible was not set
on initialization)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-12 09:48:04 +00:00
Ivailo Monev
4cc9dd4da6 kutils: use partitially-seekable property as fallback for seekable signal
this allows to enable seek sliders on streams not only when the stream has
been fully loaded

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-11 09:27:29 +00:00
Ivailo Monev
c26366971f kutils: fix compiler warning
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-11 08:23:38 +00:00
Ivailo Monev
c9fb1c8f6b generic: misc cleanups
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-08 01:17:17 +00:00
Ivailo Monev
d6103c84ce generic: get rid of KZoneAllocator
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-06 09:15:26 +00:00
Ivailo Monev
4f06efd99d kutils: constify KMediaPlayer::isMimeSupported()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-04-04 01:43:24 +00:00
Ivailo Monev
45a6db5fac kutils: implement overload for KAbstractPlayer::load()
it is needed in Okular and in KNotify I think so with the overload method
the possibility for MPV API break to affect those application will be
reduced, KAbstractPlayer is ment to be abstraction after all

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-31 17:32:20 +00:00
Ivailo Monev
96983d211e kutils: add prototype KAudioWidget
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-31 05:03:57 +00:00
Ivailo Monev
66aa3a1ca4 kutils: provide minimum size hint for KMediaWidget
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-29 16:26:12 +00:00
Ivailo Monev
3b18e56da7 kutils: attempt to set the statusbar text too when window is KMainWidnow
the change is questionable, the application may have different use case
for it but with this change it displays errors and currently played path
title which is kinda usefull if there is no window manager at all

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-29 06:34:46 +00:00
Ivailo Monev
8e9028c480 kutils: make emision of controls signal reliable for external use
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-29 06:32:50 +00:00
Ivailo Monev
ab4de0a79e kutils: fix fail to do fullscreen without parent window after doing it once
basicly once the hack is used m_parent becomes valid widget, to avoid using
it the second time fullscreen is requested just set it to NULL thus making
it invalid and the hack will be used again

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-29 05:45:29 +00:00
Ivailo Monev
fbf35f4caa kutils: improve media classes protocols check
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-28 23:59:21 +00:00
Ivailo Monev
00a309ee39 kutils: fix bootstrap build of kemoticons
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-28 04:10:43 +00:00
Ivailo Monev
483854d35a kutils: add bits to control audio output of media classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-27 23:23:07 +00:00
Ivailo Monev
f02ad6cc2a kutils: make the finished() emision more reliable
without extra path property check it can be emited twice (or even more?)
because MPV will try to use SSL and fallback to non-secure connection when
that is not possible and emit the event after load which, aside from being
innacurate for our use cases, causes unnecessary widgets actions.

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-27 18:52:37 +00:00
Ivailo Monev
cdacdd9bc4 kutils: allow multiple options to be passed to the KMediaWidget constructor
and make use of it in KHTML

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-27 18:18:53 +00:00
Ivailo Monev
314fa967a4 kutils: report media player command errors
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-27 17:34:52 +00:00
Ivailo Monev
7506a2cef6 generic: misc cleanups
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-27 02:35:23 +00:00
Ivailo Monev
8a6bb39279 kutils: revert lazy initialization changes
it has too many side effects that will complicate things more then it is
worth it to save a few MB of RAM per-application until load

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2016-03-26 21:29:11 +00:00