Commit graph

5277 commits

Author SHA1 Message Date
Ivailo Monev
dcb57aa69a kdeui: manually delete the dialog in KMessageBox::createKMessageBox()
Qt::WA_DeleteOnClose can have some unforseen consequences

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 08:57:44 +03:00
Ivailo Monev
2abb4cf251 kio: prioritize some type of jobs and do not reuse slaves
turned out the some slaves, the file slave for one, is not ready for
reusable action..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 08:24:10 +03:00
Ivailo Monev
df7257e308 kio: remove unused and internal KIO::SlaveBase::sendAndKeepMetaData() method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 06:38:46 +03:00
Ivailo Monev
0d6c466f34 kio: merge KIO::SessionData into KIO::Scheduler
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 06:29:30 +03:00
Ivailo Monev
4fb4ce61ef kio: job scheduler review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 05:36:30 +03:00
Ivailo Monev
34687b1e91 kio: stop the idle check timer once there are no more slaves
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 05:33:27 +03:00
Ivailo Monev
3bf383938b kio: kill job slaves idle for more than 1 minute
that was borked before me reworking the job scheduler, not anymore

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 05:31:50 +03:00
Ivailo Monev
5108de6bc1 kio: use only the host for determening when to not reuse a slave
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 03:53:50 +03:00
Ivailo Monev
481b9fa430 kio: do not call KProtocolManager::reparseConfiguration from KIO::SessionData::reset()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 03:51:16 +03:00
Ivailo Monev
305e5d90ce kio: do not call KProtocolManager::reparseConfiguration from KIO::Scheduler::reparseSlaveConfiguration()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 03:42:49 +03:00
Ivailo Monev
540ee2cde7 kio: rework the job scheduler
thread-safe and private

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-02 02:16:50 +03:00
Ivailo Monev
81ed3d4665 kio: always emit speed from KIO::SlaveInterface
even if processed size is not available (zero or less), that means either
stalled or just unknown. if the job is not in running state then it is
unknown and is what job interfaces can use to determine that

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-01 08:02:14 +03:00
Ivailo Monev
aeef583555 kdeui: unregister any registered jobs from KPlasmaJobTracker destructor
this is so that jobs are not left in the plasma applets as active when, for
example, the program that has jobs registered is interrupted by a signal
(be that ctrl+c or something nasty like SIGSEGV). KUiServerJobTracker
was just warning about it but I can do better

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-01 06:48:43 +03:00
Ivailo Monev
77d32f4169 kio: always calculate the speed on fixed 1sec interval based on the difference in processed size
because there are quircks such as slaves emitting total and/or processed
size way too often, the total size may not even be known at the start of
the get (chunked HTTP(s) transfer)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-01 06:15:31 +03:00
Ivailo Monev
c1a8f1087a kio: remove unused KIO::SlaveInterface method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-01 04:59:59 +03:00
Ivailo Monev
71971d1699 kio: unexport KIO::SlaveInterface
private class, not much to say. KIO::Scheduler and some classes should
not be exported either

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-05-01 04:50:22 +03:00
Ivailo Monev
f44fc1ee8d kdeui: tweak KMessageBox layout
with a fixed-size contstraint the stretch factor bits are redundant

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 23:33:31 +03:00
Ivailo Monev
0e4e6a717f kdeui: import action collection configuration when adding one to KShortcutsDialog
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 23:02:11 +03:00
Ivailo Monev
faaf690e9e kdeui: use fixed-size size constraint for KMessageBox dialogs
effectively reverting 4ed10bdd76 but with a
twist

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 22:44:17 +03:00
Ivailo Monev
072673d082 kdeui: delete the KMessageBox dialog on close
what if the dialog is closed between show and exec by the window manager
tho?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 22:35:38 +03:00
Ivailo Monev
aebe72a932 generic: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 21:45:09 +03:00
Ivailo Monev
53dc9fede5 kdeui: enable opening of external links for KMessageWidget and disable text selection
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 21:31:32 +03:00
Ivailo Monev
e86c7d9264 kdeui: warn and restore the property text when changing property in KDebugger
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 08:58:29 +03:00
Ivailo Monev
2a566aa4d0 kdeui: rework KMessageBox layout
finally it is not scuffed

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 08:24:48 +03:00
Ivailo Monev
78232470de kdeui: always use QTextBrowser for the details text
otherwise the look and feel is not consistent

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 07:49:07 +03:00
Ivailo Monev
0360088d1e kdeui: do not use KSqueezedTextLabel in KMessageBox
because the message may be rich text, see the previous commit

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 07:46:22 +03:00
Ivailo Monev
1c4fa8c32a kdeui: add warning about KSqueezedTextLabel
reminds me of surrogates chopping in QString..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 07:40:55 +03:00
Ivailo Monev
02df654093 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 07:11:05 +03:00
Ivailo Monev
704967c1b7 kdeui: remove unused KPlasmaJobTracker and KNotification data
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 06:42:36 +03:00
Ivailo Monev
c123758bc5 kdeui: remove redundant Q_UNUSED() in KPlasmaJobTracker::infoMessage()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 06:38:16 +03:00
Ivailo Monev
aa43f7335c kdeui: fix regression since 956cfc5a59
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 05:29:50 +03:00
Ivailo Monev
a5d82b62dd kdecore: stabilize KConfig tests
not relying on the order groups appear in the list

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 04:29:47 +03:00
Ivailo Monev
eb0b79bfca kduei: testing build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 04:12:15 +03:00
Ivailo Monev
e13f945e89 kio: allow links for KIO job errors
requires the previous commit

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 03:35:08 +03:00
Ivailo Monev
5a2df923aa kdeui: use QTextBrowser instead of KTextEdit for detailed messages
the only way to make external links accessible right now, may revert it
if QTextEdit gets a method to make external links accessible. required for
the next commit

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 03:34:27 +03:00
Ivailo Monev
4d017d011b kio: KIO::SlaveInterface optimization and prepration to unexport it
reparenting the KIO::ConnectionServer object (held as pointer) was
sub-optimal

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 02:53:59 +03:00
Ivailo Monev
a37180e9ec kio: use QElapsedTimer for the idle time
assuming monotonic clock is supported and enabled on the system the idle
time will not be subject to clock jumps

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 02:21:24 +03:00
Ivailo Monev
6b4693904c kio: remove unused definitions and methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-30 01:38:36 +03:00
Ivailo Monev
3361c25982 kio: adjust to thumbnail slave changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-29 12:17:52 +03:00
Ivailo Monev
a613f682f9 kdeui: correct connection in KNotificationManager::send()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-29 06:11:18 +03:00
Ivailo Monev
ae4c786744 kinit: start services in the service path if not empty
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-28 22:01:11 +03:00
Ivailo Monev
307e136a13 kdeui: fix KDebugger events log thread-safety issue
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 18:33:00 +03:00
Ivailo Monev
3d5c97fa56 kdeui: implement basic events fuzzer for KDebugger
basic, anything else has to come with a warning message

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 18:17:21 +03:00
Ivailo Monev
e0124f2d74 kdeui: stub fuzz KDebugger feature
it will do nasty stuff

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 07:43:15 +03:00
Ivailo Monev
22a5f1922a kdeui: stringify events for KDebugger events log
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 07:25:45 +03:00
Ivailo Monev
b3d2df692a kdeui: clear widgets of KDebugger when nothing is selected
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 07:08:52 +03:00
Ivailo Monev
bb704df5ae kdeui: clear the contents of the properties widget of KDebugger
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 06:54:36 +03:00
Ivailo Monev
9dfe6602a9 kdeui: pass the associated action from KKeySequenceWidget to KGlobalAccel
for better shortcut stealing, e.g. for actions with more than one
shortcut

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 04:49:06 +03:00
Ivailo Monev
98f6b2b434 plasma: update the key sequence widget when the applet global shortcut changes
for the case when it is stolen

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 04:18:19 +03:00
Ivailo Monev
a2f589fc43 kdeui: log a message when stealing global shortcut from KGlobalAccel::stealShortcutSystemwide()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-27 04:17:37 +03:00