Commit graph

410 commits

Author SHA1 Message Date
Ivailo Monev
8791f0571b plasma: do not emit Plasma::RunnerContext::matchesChanged() from Plasma::RunnerContext::reset()
any preperation for matching anew should be done prior to starting a query

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:14:48 +03:00
Ivailo Monev
6514cb22a6 plasma: remove unused private member
performance gain for the runners, there should be no duplicates and even
if there was the only thing that was done about it is to print a debug
message when build for debugging

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 22:06:26 +03:00
Ivailo Monev
595991ff55 plasma: simplify runners setup and correct signals emission
Plasma::RunnerManager::matchesChanged() is now emitted when new matches
arive, Plasma::RunnerManager::queryFinished() when matching is done (all
match jobs finished)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 18:18:42 +03:00
Ivailo Monev
f452997709 plasma: remove unused and redundant Plasma::RunnerContext methods
nothing but the manager is supposed to remove matches and there is a
Plasma::RunnerContext::reset() method

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 17:32:27 +03:00
Ivailo Monev
ac5d407fd5 plasma: remove unused Plasma::RunnerContext methods arguments
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 17:09:11 +03:00
Ivailo Monev
97cfe669fc plasma: do not magically adjust the speed of runners
I've optimized the runners enough to not need such bits

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 07:53:05 +03:00
Ivailo Monev
afb548b2ed plasma: unlock Plasma::QueryMatch
assuming that match (Plasma::QueryMatch) objects are modified by one thread
in the runner itself only or operated on a copy of one matching does not
need a mutex

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 07:43:34 +03:00
Ivailo Monev
632dd982df plasma: remove redundant KThreadPool::setMaxThreadCount() call
KThreadPool uses the same value by default

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 06:40:49 +03:00
Ivailo Monev
a871678ec4 plasma: rework runners classes to not pass around the context
unused in most cases, shared data and dangerous to pass around

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 05:15:02 +03:00
Ivailo Monev
2f485d5376 generic: replace QThreadPool and QRunnable with custom class
on a side note it does not solve any thread-safety issues, such are out
of the scope of the class

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 03:05:03 +03:00
Ivailo Monev
747c37269b plasma: remove unused Plasma::RunnerContext MIME type info
runners can determine it anyway, generic type detection is done already

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 01:02:11 +03:00
Ivailo Monev
b2a66f5a72 plasma: const-ify Plasma::RunnerContext arguments
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 00:16:31 +03:00
Ivailo Monev
7683b1d29e plasma: drop redundant Plasma::QueryMatch type feature
it could be used to sort ala relevance but what would the relevance feature
would be for then?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-18 00:06:05 +03:00
Ivailo Monev
c4c494d705 plasma: do not copy the query match in Plasma::RunnerContext::addMatch()
its relevance remains unchanged

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 23:01:28 +03:00
Ivailo Monev
e7fcb90738 plasma: actually use the priority
the runners priority property was not used for anything, it is now

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 21:35:38 +03:00
Ivailo Monev
4152c2b044 plasma: de-virtualize Plasma::Animation::setDuration() and make it public
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 21:10:35 +03:00
Ivailo Monev
54d5ec4782 plasma: initialize all members of private class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 20:05:47 +03:00
Ivailo Monev
22e93f449e plasma: properly initialize internal class members
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 19:57:40 +03:00
Ivailo Monev
935b228484 plasma: simplify animations classes
the proxy class Plasma::EasingAnimation is simply redundant, just one
more virtual function call which slows the animations

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 19:44:26 +03:00
Ivailo Monev
76fa8e28b8 plasma: remove checks for non-existing properties in Plasma::ScrollWidget
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 01:47:22 +03:00
Ivailo Monev
a179fd4603 plasma: drop unused runners matching feature
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-17 00:49:17 +03:00
Ivailo Monev
3f4425e9bb plasma: remove redundant Plasma::Animator::Animation::LastAnimation enum
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 23:31:47 +03:00
Ivailo Monev
8163991f03 plasma: rework runners to not rely on configuration
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 23:23:58 +03:00
Ivailo Monev
1f11147bd4 plasma: drop redundant Plasma::PluginLoader class
not finished either

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 22:33:18 +03:00
Ivailo Monev
95340211ee plasma: drop now unused runner options feature
not to be confused with runners configuration

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 21:40:44 +03:00
Ivailo Monev
5597939dbf plasma: remove unused header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 21:40:17 +03:00
Ivailo Monev
f4c2f5c84e generic: drop stylesheet support
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-16 04:31:21 +03:00
Ivailo Monev
d4fb98cc28 generic: KIO protocols classification optimization
unfortunate as it is the class for getting protocol information is not
part of kio library so generic..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-14 09:54:36 +03:00
Ivailo Monev
649e704698 plasma: documentation corrections
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-13 16:38:57 +03:00
Ivailo Monev
b9b86aa316 plasma: remove unused private member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-11 15:06:46 +03:00
Ivailo Monev
4a4488c127 plasma: const-correct private method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-11 15:05:11 +03:00
Ivailo Monev
222c0282be plasma: remove unused private methods
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-11 15:03:41 +03:00
Ivailo Monev
bb1e962276 plasma: remove unused private method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-11 13:47:28 +03:00
Ivailo Monev
2fe79a003e plasma: warn when runner fails to load
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-11 13:17:13 +03:00
Ivailo Monev
851e7ec05c plasma: drop unused category exclusion feature
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-11 06:06:33 +03:00
Ivailo Monev
def76d2d7c plasma: remove declaration of non-existing Plasma::WindowPreview::previewsAvailable() method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-11 01:48:35 +03:00
Ivailo Monev
899f94c78d plasma: correct base class call in Plasma::Label::itemChange()
it has been like this since before the fork

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-10 11:06:43 +03:00
Ivailo Monev
d21869a910 plasma: remove stylesheet getters and setters
slowly but surely stylesheets feature will dissapear

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-10 04:03:03 +03:00
Ivailo Monev
831986ac81 plasma: remove unused Plasma::IntervalAlignment enums
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-08 14:51:36 +03:00
Ivailo Monev
52a8caa5ee plasma: drop everything related to dataengines
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-08 11:32:12 +03:00
Ivailo Monev
9d836c7de9 plasma: remove unused Plasma::Position enumbs
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-07 20:07:56 +03:00
Ivailo Monev
fe064f648f plasma: remove unused Plasma::ComponentType enums
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-07 20:04:28 +03:00
Ivailo Monev
f3a9b3c0c2 plasma: do not lock when setting runners speed
much like done for the priority, the speed is enum and not shared data so..

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-07 19:36:37 +03:00
Ivailo Monev
c61c158983 plasma: set the style before creating the native widget of Plasma::TextEdit
otherwise the style pointer is null and the native widget (KTextEdit) does
not get to experience the nativeness, it has been like since before the
fork

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-06 18:59:47 +03:00
Ivailo Monev
ead9bb1090 plasma: remove redundant private method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-05 12:19:04 +03:00
Ivailo Monev
869ea51b06 plasma: remove unused private member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-05 12:16:20 +03:00
Ivailo Monev
f717c418f8 plasma: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-05 12:13:34 +03:00
Ivailo Monev
8e83f663ba plasma: Plasma::Meter painting optimization
simply using proper type, caching result from getters and properly scoping
variables

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-05 11:57:23 +03:00
Ivailo Monev
1a0f259d1b plasma: paint elided text from Plasma::Meter
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-05 11:07:13 +03:00
Ivailo Monev
f8955d1473 plasma: do not paint bars from Plasma::SignalPlotter, paint elided title instead
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-05 10:53:52 +03:00