Commit graph

66 commits

Author SHA1 Message Date
Ivailo Monev
f2e7f97a62 kdeui: use private member for the KAction isShortcutConfigurable property
much more optimal, no funcitonal change

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 04:32:30 +03:00
Ivailo Monev
4c30a62d40 kdeui: set only the active shortcut when reading KActionCollection settings
setting the default makes no sense, the default should come from code not
from the config

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 04:20:48 +03:00
Ivailo Monev
a4df5d73f9 kdeui: write shortcuts configuration only to regular config files
that xml gui stuff is pure garbage

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 01:09:52 +03:00
Ivailo Monev
1faf138d4b kdeui: do not emit KAction::globalShortcutChanged() when the default changes or when the shortcut is set for the first time
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-26 01:06:36 +03:00
Ivailo Monev
d74d369e5e kdeui: simplify KActionCollection settings reading and writing
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-25 23:10:57 +03:00
Ivailo Monev
11e40bd6d2 kdeui: ungrab all shortcuts from KGlobalAccelPrivate::remove()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-25 10:34:58 +03:00
Ivailo Monev
45ef26718a kdeui: emit globalShortcutChanged() from KAction
no way the grab failed or something other than KGlobalAccel grabs the
shortcut by force from KGlobalAccel, right?

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-24 23:37:43 +03:00
Ivailo Monev
9ca75a8355 kdeui: implement KShortcutsEditor::keyChange() signal
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-24 22:18:55 +03:00
Ivailo Monev
843463c95d kdeui: drop KSortcut
missing proper configuration interface for the shortcuts, the old one
was borked anyway

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-24 10:19:03 +03:00
Ivailo Monev
a8906fbcf5 kdeui: testing build fix
tests pass to no surprise

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-24 06:15:13 +03:00
Ivailo Monev
39998ee94e kdeui: accept the ambiguous event in KAction::event()
with an upcomming change in Katie it is required to stop sending events

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-24 06:14:29 +03:00
Ivailo Monev
671d45fe1d generic: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-22 04:29:48 +03:00
Ivailo Monev
d725bcef69 kdeui: remove old KGlobalAccel autoloading feature leftovers
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-22 02:51:29 +03:00
Ivailo Monev
594e901c4a kdeui: rework KGlobalAccel
global shortcut resolution (the KGlobalAccel methods) work on
application level, X11 as far as I can tell does not have a method to
tell which application has grabbed a key (to fill KGlobalShortcutInfo).
other than that no configuration interface for global shortcuts (not by
KGlobalAccel itself, plasma and its applets have interface for that),
also the shortcuts interface did not and still does not handle global
shortcuts well so that is something to look into.

one of the problems solved with this change is the fact that multiple
plasma applets (e.g. multiple instances of the keyboard applet) could
not use the same shortcut, now it is possible. as for which applet gets
the shortcut action it is the one that has the grab first - that is how
key grabbing works in X11

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-04-22 00:07:35 +03:00
Ivailo Monev
45674c0c4e kdeui: replace KFontDialog and KFontChooser with QFontDialog
requires the following commit from the Katie repo:
97fea30784dfdc41a6599ea31219d0b366d8efaa

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-31 19:01:45 +03:00
Ivailo Monev
bb11a3e5f4 kdeui: replace KFontComboBox with QFontComboBox
one less class to maintain with substitute provided by Katie

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-31 01:40:10 +02:00
Ivailo Monev
a324de58dc kdeui: log KAction warning to the correct debug area
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2024-03-22 14:42:24 +02:00
Ivailo Monev
fbfb374b9c generic: drop scripting and tray support
after changes to multiple sub-projects (Katie, kdelibs, kde-workspace
and kde-extraapps) that finally happened, can write lots about it but I
will keep it short - by rewriting parts that were using js/qml (e.g. the
plasma applets) the desktop startup was reduced to half, also the legacy
tray thing shall be no more (anything that needs tray icon shall be a
plasma applet now) thus some applications and features will be dropped
aswell. see all repositories for the changes done

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-10-21 08:06:58 +03:00
Ivailo Monev
cc338a8f3b kdeui: build fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 16:09:52 +03:00
Ivailo Monev
7145876ebd generic: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 03:25:39 +03:00
Ivailo Monev
640cfb06e3 kdeui: KRecentFilesAction::saveEntries() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 03:00:45 +03:00
Ivailo Monev
91168f281c kdeui: remove unused variable in KRecentFilesAction::saveEntries()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:58:04 +03:00
Ivailo Monev
9acda75f99 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:57:26 +03:00
Ivailo Monev
312c5a6268 kdeui: de-virtualize KPasteTextAction destructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:32:18 +03:00
Ivailo Monev
7fda04bcd0 kdeui: remove unused KPasteTextAction::setMixedMode() method
not only is the method unused but so is the KPasteTextActionPrivate member

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:31:28 +03:00
Ivailo Monev
c9d9c44643 kdeui: initialize KPasteTextActionPrivate members from its constructor
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:28:45 +03:00
Ivailo Monev
6278217dc6 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 02:26:32 +03:00
Ivailo Monev
b1b18231d8 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 01:52:15 +03:00
Ivailo Monev
e8cb5109be kdeui: remove unused variable in KActionCollection::exportGlobalShortcuts()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 01:41:36 +03:00
Ivailo Monev
c573c74ea1 kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 01:40:03 +03:00
Ivailo Monev
8f21b07de6 kdeui: remove unused KActionCategoryPrivate member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-28 01:27:27 +03:00
Ivailo Monev
5ff064886b kdeui: de-virtualize KAction desctructor
KAction has no virtual methods

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 19:17:38 +03:00
Ivailo Monev
3fcfdb2687 kdeui: KAction constructors optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 19:17:10 +03:00
Ivailo Monev
558295b483 kdeui: KAction::shortcut() optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 18:46:59 +03:00
Ivailo Monev
048737d48c kdeui: remove bogus bits in KAction::setGlobalShortcut()
the keycode for invalid shortcuts (QKeySequence) is zero, the key could be
zero if alternative shortcut is not set and there is only primary shortcut.
also, Katie's QKeySequence supports only two key combinations now - one for
primary and one for alternative, see the following commit in the Katie
repo:
d03db175529e800f62acd858badb5622be2e00af

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-27 17:23:59 +03:00
Ivailo Monev
bd063c8b56 generic: remove dead and irrelevant links references
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-08-10 14:26:19 +03:00
Ivailo Monev
45658d0d7c kdeui: format and indent
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-29 18:20:49 +03:00
Ivailo Monev
e5f56675d2 generic: call QCoreApplication::applicationName() as static method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-19 01:19:01 +03:00
Ivailo Monev
0d50d69dbb generic: remove irrelevant TODO files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-05 02:50:54 +03:00
Ivailo Monev
520cf5a629 generic: headers inclusions review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-02 11:31:52 +03:00
Ivailo Monev
6424bc5ab8 kdeui: correct QFontDatabase::standardSizes() usage in KFontSizeAction
since it is a static method there is no need to create QFontDatabase object

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-17 15:18:57 +02:00
Ivailo Monev
9b41127ecb generic: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-13 00:40:18 +02:00
Ivailo Monev
803e38914d kdeui: include now required system limits header
was previously included by qcontiguouscache header

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-10-31 05:55:19 +02:00
Ivailo Monev
718ccc145f kdecore: remove redundant KEncodingDetector class
use QTextCodec::codecForUtfText() or QTextCodec::codecForText() instead

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-30 20:47:46 +03:00
Ivailo Monev
e6ea319726 kdeui: remove unused private classes members
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-29 21:47:31 +03:00
Ivailo Monev
e88c621aa2 generic: authorization reimplementation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-25 19:27:41 +03:00
Ivailo Monev
1b5c5fe630 generic: do not use QStringListIterator for iterating
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-21 10:18:04 +03:00
Ivailo Monev
d05992bda9 kdeui: drop gesture support
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-09-21 04:41:08 +03:00
Ivailo Monev
08f290fa8b generic: cast pointers with QObject as base class via qobject_cast<T>()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-06-01 18:06:11 +00:00
Ivailo Monev
da9a1745c5 generic: remove most compiler checks
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2021-01-09 16:39:44 +02:00