Commit graph

470 commits

Author SHA1 Message Date
Ivailo Monev
520cf5a629 generic: headers inclusions review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-02 11:31:52 +03:00
Ivailo Monev
04cbca81e2 plasma: remove unused Plasma/Animator service type
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-02 10:41:25 +03:00
Ivailo Monev
8e7bab7ff6 plasma: Plasma::Service documentation review
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-02 10:35:17 +03:00
Ivailo Monev
0d51245c32 plasma: remove unused header inclusions and dataengine property
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-02 07:29:36 +03:00
Ivailo Monev
a5e996209f plasma: rework services to not use files describing operations
the benfit of this is that a lot of disk I/O and parsing will be avoided
leading to faster plasma-desktop startup for example, also service
plugins are not a thing

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-02 06:54:16 +03:00
Ivailo Monev
2133884b4f plasma: drop support for registering operations from non-scheme files
no setter for operation names and non-virtual description/parameters
getters make this feature a no-no

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-02 03:48:22 +03:00
Ivailo Monev
2858f3be71 plasma: const-ify the service job parameters
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-02 02:45:51 +03:00
Ivailo Monev
7c8aed76ae plasma: remove redundant Plasma::ConfigLoader::findItemByName() method
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-06-02 01:35:59 +03:00
Ivailo Monev
963e5e8735 plasma: prepare for Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-30 04:14:59 +03:00
Ivailo Monev
f8131668c3 plasma: MOC warning fix
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 08:56:47 +03:00
Ivailo Monev
c9e7213de4 plasma: remove unused qClamp() function
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 03:23:55 +03:00
Ivailo Monev
39ea2ed450 plasma: remove unused headers inclusions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 03:23:35 +03:00
Ivailo Monev
d9a7e6b119 plasma: remove unused private members and forward-declarations of non-existing classes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 03:17:06 +03:00
Ivailo Monev
b91e927ffa plasma: remove non-operational service monitor
was used for remote widgets and their services

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 02:58:32 +03:00
Ivailo Monev
8fb3054aa1 plasma: remove unused private member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 02:51:12 +03:00
Ivailo Monev
d0b26513c1 plasma: remove unused storagetest header
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 02:50:16 +03:00
Ivailo Monev
e567fdd4cd plasma: log the service monitor engine and location as strings instead of pair
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 01:47:14 +03:00
Ivailo Monev
913bc263e7 plasma: minor Plasma::PlasmoidService constructor optimization
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 01:40:45 +03:00
Ivailo Monev
a6ad214588 plasma: remove unused Plasma::PlasmoidServiceJob member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-22 01:39:22 +03:00
Ivailo Monev
6e8feccb93 plasma: remove unused source and header files
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 22:38:30 +03:00
Ivailo Monev
0fcbeab9fb plasma: drop JS animations
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 21:44:37 +03:00
Ivailo Monev
0dd99c3650 plasma: remove unused animations
besides being unused grow does the same as zoom/geometry animation,
the declarative component also provides rotation animation

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 20:40:31 +03:00
Ivailo Monev
7169fd5be7 plasma: remove redundant Plasma::ExtenderItem::sizeHint() reimplementation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 02:21:39 +03:00
Ivailo Monev
da13cb0c57 plasma: remove redundant Plasma::ExtenderGroup::resizeEvent() reimplementation
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 02:16:01 +03:00
Ivailo Monev
154542354d plasma: const-ify some variables
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-21 02:13:00 +03:00
Ivailo Monev
b0becab9c2 plasma: remove check for non-existing iconRepresentation property in widget snapshotter
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-20 21:09:08 +03:00
Ivailo Monev
36c233341a plasma: remove unused and mapped animations
Plasma::Animator::AppearAnimation and Plasma::Animator::DisappearAnimation
are mapped to Plasma::Animator::ZoomAnimation by plasma-desktop

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2023-05-20 05:22:55 +03:00
Ivailo Monev
c545d14cf7 generic: remove binary compat bits
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-20 11:56:02 +02:00
Ivailo Monev
ec2e04c3d8 plasma: remove duplicate header inclusions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 13:30:11 +02:00
Ivailo Monev
f0a1b5fb6b plasma: adjust to Katie changes
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 11:12:26 +02:00
Ivailo Monev
3ce0161856 plasma: remove unused and private Plasma::Animator member
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 10:16:01 +02:00
Ivailo Monev
f6dba585d7 plasma: remove declaration of non-existing Plasma::Animator signals
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 10:12:01 +02:00
Ivailo Monev
716152020d plasma: remove unused Plasma::Animator::Movement enum
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 10:11:38 +02:00
Ivailo Monev
6fec902232 plasma: remove declaration of non-existing SlideAnimationPrivate class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 10:04:55 +02:00
Ivailo Monev
5933638f18 plasma: remove unused Plasma::AnimatorPrivate member and methods, also the custom easing type
the animations use either QEasingCurve or JS code (which will eventually
be converted to sub-class of QEasingCurve for performance reasons)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-12 10:00:51 +02:00
Ivailo Monev
110e53a48e plasma: remove unused X-Plasma-Args property
according to the chanages log (see kde-workspace/plasma/design/CHANGELOG-4.4)
it was used by the mediawiki runner which is no longer supported

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-11 07:32:35 +02:00
Ivailo Monev
69f56fa9d8 plasma: remove unused Plasma::ComboBoxPrivate members
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 03:08:57 +02:00
Ivailo Monev
97372a82ef plasma: remove unused AbstractDialogManager class
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-09 00:06:27 +02:00
Ivailo Monev
3fca1f6504 plasma: pass the script data directly to QScriptEngine::evaluate()
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 10:06:36 +02:00
Ivailo Monev
0aa020de88 plasma: remove duplicate animation registration
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-08 09:49:47 +02:00
Ivailo Monev
aef479ab03 plasma: do not guess the mask color in FrameSvg::mask()
using the mask created by QPixmap::mask() is much more reliable way
to get one, fixes masking in case compositor is not active for example

side note: feels good to finally land the fix for masking

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-06 09:26:21 +02:00
Ivailo Monev
a3d14ed9f8 plasma: query KWindowSystem directly for the compositor state
because Plasma::Theme (and Plasma::ThemePrivate indirectly) may be created
before QCoreApplication/QApplication instance by Theme::defaultTheme()
and application instance is required for QX11Info::display() to return
non-null (which KWindowSystem uses but has fallback in case it is null
in KWindowSystem::compositingActive())

note that KWindowSystem::compositingActive() returns cached value if
XFixes is available

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-06 10:27:10 +02:00
Ivailo Monev
bc067dbdfa kio: drop support for putting slaves on hold
with klauncher no longer responsible for KIO slave the next step is to
make them plugins and the feature to put them on hold will be of no value
because QLibrary reuses library/plugin instances and creating a new
slave object will be cheap

in other words the performance will be similar to that of KFileMetaInfo
for which I also wrote the plugins myself - they are pretty quick
compared to what strigi was doing and with more flexible configuration
interface but it took some effort to get there

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-06 04:22:23 +02:00
Ivailo Monev
148110f398 generic: drop locolor support
`apt-file` search yeilds 221 files matching (8 packages provide such),
it is also unused by plasma even tho there are leftovers from support for it

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-05 01:30:27 +02:00
Ivailo Monev
a684811e80 plasma: remove duplicate header inclusions
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-03 03:54:58 +02:00
Ivailo Monev
0f0c306927 plasma: move bufferPixmap variable to the scope it is used in
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-12-03 00:57:54 +02:00
Ivailo Monev
ce4f5b3c14 plasma: build fix for the case when NDEBUG is not defined
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-30 10:15:50 +02:00
Ivailo Monev
a8ec0ae048 plasma: remove binary compat bits
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-28 01:28:02 +02:00
Ivailo Monev
98f1b0b90a plasma: fix shortcuts
who tought using the same shortcut for multiple actions is going to work?
the single character shortcuts are very likely to conflict with other
shortcuts aswell

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-26 11:47:09 +02:00
Ivailo Monev
e50350ac20 plasma: remove redundant QString construct in correctPathCase() function
path is a QString constant reference

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
2022-11-23 22:02:32 +02:00